all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Robert Cochran <robert+Emacs@cochranmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/
Date: Wed, 21 Feb 2018 14:26:46 -0500	[thread overview]
Message-ID: <CAM-tV-8zer5DNk20aZ-PBXNYg6wyXEgdcF4EZ3LkuzNr_Y5vkQ@mail.gmail.com> (raw)
In-Reply-To: <87o9kii4an.fsf@cochranmail.com>

On Wed, Feb 21, 2018 at 1:30 PM, Robert Cochran
<robert+Emacs@cochranmail.com> wrote:

> This patch is rather large - the email patch form is 600k. The reason
> for this is that I've touched quite a number of files - over 1,000
> according to the Gitlab interface.

If you instead set byte-compile-error-on-warn to t by default (e.g.,
on the command line) and just set it to nil in files which trigger a
warning, would the patch be bigger or larger?

By the way, I think it would be better to set it in the local
variables list at the end of the file, rather than in the first line.
For lexical-binding it's required to put it there for technical
reasons, but I think those don't apply to byte-compile-error-on-warn,
and that first line can get a bit crowded.



  parent reply	other threads:[~2018-02-21 19:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 18:30 [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/ Robert Cochran
2018-02-21 18:42 ` Eli Zaretskii
2018-02-22  2:51   ` Robert Cochran
2018-02-22  6:56     ` Eli Zaretskii
2018-02-21 19:24 ` Stefan Monnier
2018-02-22  3:05   ` Robert Cochran
2018-02-22  5:24     ` Stefan Monnier
2018-02-22  7:18       ` Eli Zaretskii
2018-02-23  9:47       ` Richard Stallman
2018-02-24 11:08         ` Eli Zaretskii
2018-02-24 23:33           ` Richard Stallman
2018-02-25  3:33             ` Eli Zaretskii
2018-02-25 13:13           ` Stefan Monnier
2018-02-25 15:33             ` Eli Zaretskii
2018-02-22  7:13     ` Eli Zaretskii
2018-02-21 19:26 ` Noam Postavsky [this message]
2018-02-22  2:29   ` Robert Cochran
2018-02-22  3:24     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV-8zer5DNk20aZ-PBXNYg6wyXEgdcF4EZ3LkuzNr_Y5vkQ@mail.gmail.com \
    --to=npostavs@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=robert+Emacs@cochranmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.