From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation Date: Wed, 10 Jan 2018 10:57:34 -0500 Message-ID: References: <87wp0yhsgu.fsf@cochranmail.com> <87vaggrfqo.fsf@cochranmail.com> <87r2r2txqp.fsf@cochranmail.com> <87373fpujo.fsf@cochranmail.com> <87zi5mcjnh.fsf@cochranmail.com> <83inc968gs.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1515599754 10450 195.159.176.226 (10 Jan 2018 15:55:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 Jan 2018 15:55:54 +0000 (UTC) Cc: Stefan Monnier , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 10 16:55:50 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZIjE-0002Al-QN for ged-emacs-devel@m.gmane.org; Wed, 10 Jan 2018 16:55:48 +0100 Original-Received: from localhost ([::1]:50363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZIlC-00032q-Ro for ged-emacs-devel@m.gmane.org; Wed, 10 Jan 2018 10:57:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZIl1-00030u-Sb for emacs-devel@gnu.org; Wed, 10 Jan 2018 10:57:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZIl1-0004im-5j for emacs-devel@gnu.org; Wed, 10 Jan 2018 10:57:39 -0500 Original-Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]:37996) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZIky-0004gA-OO; Wed, 10 Jan 2018 10:57:36 -0500 Original-Received: by mail-wr0-x231.google.com with SMTP id 60so8769813wrl.5; Wed, 10 Jan 2018 07:57:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=nqfElQhYEI0zWGe38/UocDEw5zG3WwrgAInDHaEE2ic=; b=ZXHIoZ3CFFSsg6ohTGlxVa4VMBrAiGRuwEVKnn2rRdgaTCYdPBQqKk6tU9lVxWKTGV nMwVsMlM7+h/xQMdZK/NnFLjskuWpwoKG9vV5+3qtwkNqbO6zIOvzU7IRtY46vusVZhC aJMaRcSL/qyzAbxB8eaW0xvOXgSEoP632zoDe0Q6D6bUEszD85Qa6OhBPz00srhZ3ouj 3y3Z80WoIqwj+pSw17I1VuCbWK5604qZBGaoVeC2OcrfN6q4ind++W3vNR29AmyG0atQ gdlvAhdPI9AkeajkXEadlbq9RIg2Y3NIkmr/1I3TtQ3E7kiS9KMWE/M+rmILJI7AwjUN AdTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=nqfElQhYEI0zWGe38/UocDEw5zG3WwrgAInDHaEE2ic=; b=gwh1pYX9MNdNBJWMQLg9UajBKRlWY3jzcXv57PJR7qhxoGR63qzQM9v8zJS6g/UPs0 irh+Cx4tlrnRgBfcuFCP2loADpiQvGWdlRQvYIBVpoUwiSMtYIsKgTPYuxoKOhp8+6eI Njb3edCOXyQVHGrNY0Vt7rku8k48R0YmzTV6mchrobha61jBvC+nTT/vQZOTrHrE03bN FLwKHyNhcY/lHeRIm6KF7esXP4bmGFutcVTNK5aCScSp3F2H90eni3icWoOcFGwLhosf WeaMeudlxiRmO+glXHyXCtAC3S1ngLE7AbezuyCZb3y27uH7r0wvJEmnOpgHlKDH665/ ihDQ== X-Gm-Message-State: AKGB3mIGWocm15+ohNAoD9anf1Kj0Uwp1w33hXKSXtVfGlwoeKBqq39e FCB25kL3OkDLL6D9r3A6i05Tu88jHbDPYaLDi60= X-Google-Smtp-Source: ACJfBovVTV+dafQP08MvNL6QQ3+sb2rydDdjterKHGK/eLAwCF3UFRJzQsWIJlLfuQkmbv2hFNlXvAqEi4X+6GDrT2A= X-Received: by 10.223.182.76 with SMTP id i12mr17726771wre.92.1515599855432; Wed, 10 Jan 2018 07:57:35 -0800 (PST) Original-Received: by 10.223.142.53 with HTTP; Wed, 10 Jan 2018 07:57:34 -0800 (PST) In-Reply-To: <83inc968gs.fsf@gnu.org> X-Google-Sender-Auth: JjwNSMvvhiP7FxHNJqCs8bBYcnA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221796 Archived-At: On Wed, Jan 10, 2018 at 10:26 AM, Eli Zaretskii wrote: >> From: Robert Cochran >> Date: Tue, 09 Jan 2018 22:28:18 -0800 >> Cc: emacs-devel@gnu.org >> >> Yeah, I noticed I forgot the autoload cookie, so I knew I had to do it >> over again anyways. >> >> Thus, new (and hopefully) final version of the patch. >> >> Please let me know if I need to do anything else. > > I think we'd like a comment before the autoload cookie explaining why > we do things this way. Since this autoload vs :safe property consideration applies more generally, shouldn't we rather explain in it in the manual?