From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#27873: 26.0.50; M-x grep broken Date: Sun, 30 Jul 2017 16:34:23 -0400 Message-ID: References: <87a83m7xf4.fsf@users.sourceforge.net> <87379d8z7n.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1501446919 29469 195.159.176.226 (30 Jul 2017 20:35:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Jul 2017 20:35:19 +0000 (UTC) Cc: 27873@debbugs.gnu.org To: Eric Hanchrow Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 30 22:35:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbuvb-00076r-Of for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jul 2017 22:35:07 +0200 Original-Received: from localhost ([::1]:56426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbuvh-0006pA-MX for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jul 2017 16:35:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbuvb-0006mi-Bo for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 16:35:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbuvW-0000rx-Dw for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 16:35:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbuvW-0000rF-8y for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 16:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dbuvV-0006UK-Sz for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 16:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jul 2017 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27873-submit@debbugs.gnu.org id=B27873.150144687124902 (code B ref 27873); Sun, 30 Jul 2017 20:35:01 +0000 Original-Received: (at 27873) by debbugs.gnu.org; 30 Jul 2017 20:34:31 +0000 Original-Received: from localhost ([127.0.0.1]:34560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbuv0-0006Ta-UI for submit@debbugs.gnu.org; Sun, 30 Jul 2017 16:34:31 -0400 Original-Received: from mail-oi0-f53.google.com ([209.85.218.53]:33420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbuuz-0006TN-Lg for 27873@debbugs.gnu.org; Sun, 30 Jul 2017 16:34:29 -0400 Original-Received: by mail-oi0-f53.google.com with SMTP id a9so169085883oih.0 for <27873@debbugs.gnu.org>; Sun, 30 Jul 2017 13:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3X0X0PyJukmtuaFsmfkDI3H1ywHUhLsboyDEhCI7xVI=; b=VPcRtpU65EGN+RvJlh6N8sGJdGAo4GJMLX7gkLbGss5WN0spziasX0erj0+UXho1+a Zs+Q7MWHazS7REK0wzTUGH2lOwMu5bFKP4CemVTI9SMtdCr7G3ZQ4L9mB4UPF9H0TJkV QLlNQMDQhDaAerTXuHNISIPxuOODaLE0sO5a1kplm88kgU+nsEpLvoiYnwH+eH54l5Lh mrsReicL43UEXs3hd5Qw7WTMNBJx+r4EI+WwPw18xNLh/LgeTTwhhgqxjDYDhs0qWnK0 DhB+WlqkbeuAhR2aSv/W0Oor6uNOijQhVfZOFmjjtQQfZyDv3ngrEpaa64onWR/fCvPm OtnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3X0X0PyJukmtuaFsmfkDI3H1ywHUhLsboyDEhCI7xVI=; b=GVdkQyblcYIyGOWt8kwj9njUdthvS2mPhWYQPjfdweYuGkHVWt04dI+0w4zZ7gBX0s kySNsg3mOo7/GXJu6yuRZYZRFoYaOPhGI/Ds9m5LE7CWxo9xreWjLEwBiD7xGUmYoCGk u1KGFeW564BRtwYiKkIchmCGKzhkdGoRh6v9CaZRFSN0WiGOmdyFPLQduuuYV8hwIALQ IeikAGRWl1ifBmNCnjDuFVJtu/+r1rXBNUmNkVmFDxWAlIP3/f/wm1zIuINE1ruSgvKU agzQ6ibsVY7LmvTbE+JhPHk0GvOuce+cn9WJUqyVW9bMOe6kueuRChs6Uo3yKpQVkxor SXPA== X-Gm-Message-State: AIVw110Icbhr5XvidreAImkYWELzb8JJk8Rx6QjZF/+kg8gyQHh7nz5c 1tLJ/4a4EepY/79ThSDG3C/HcQwu5g== X-Received: by 10.202.208.79 with SMTP id h76mr13902898oig.65.1501446863987; Sun, 30 Jul 2017 13:34:23 -0700 (PDT) Original-Received: by 10.74.113.6 with HTTP; Sun, 30 Jul 2017 13:34:23 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: fw68FyabCC5b7HSBrfLnEqDiXK4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135172 Archived-At: On Sun, Jul 30, 2017 at 4:25 PM, Eric Hanchrow wrote: > I suspect you've subtly changed the semantics of the grep command, by > assuming that the hits are teminated by a 0 byte. This is a good thing, but > it seems to have broken a command I've written myself -- that is, when I run > > cd /Users/erichanchrow/git-repositories/3rd-party/emacs/ && git grep > --perl-regexp -I -n --ignore-case -e hanchrow > > I see ... well, it's hard to describe, but the hits aren't highlighted in > the color I expect, and C-x ` just says "Moved past last grep hit". But, > not surprisingly, if I add --null to that command line, it works nicely. > > So now I will need to adjust my command based on which version of grep.el > I've got. Is there some programmatic way that I can tell which version I've > got? I.e., perhaps I can write something like "if boundp > 'grep-with-null-regexp-alist then add --null to my command, else leave it > out"? It should work to just customize `grep-use-null-filename-separator' to nil. Then you should have the old behaviour again. I'm currently leaning towards making it default to nil actually, to avoid the hassle in cases like the one you've described above (see also Bug#27840).