Re: [elpa] master b5f4061: Drop forced lambda's from stream (Bug#30626)

Re: [elpa] master b5f4061: Drop forced lambda's from stream (Bug#30626)

[Stefan Monnier]

>     Let the stream id distinguish between forced and unforced stream
>     values.  When the value is forced, replace the lambda with its result.
>     This lets the lambda and anything it references be garbage collected.

Doesn't the same "memory leak" affect thunks?
How 'bout the patch below


        Stefan
        

diff --git a/lisp/emacs-lisp/thunk.el b/lisp/emacs-lisp/thunk.el
index e1370c4591..8d28570dc2 100644
--- a/lisp/emacs-lisp/thunk.el
+++ b/lisp/emacs-lisp/thunk.el
@@ -54,16 +54,15 @@ thunk-delay
   "Delay the evaluation of BODY."
   (declare (debug t))
   (cl-assert lexical-binding)
-  (let ((forced (make-symbol "forced"))
-        (val (make-symbol "val")))
-    `(let (,forced ,val)
-       (lambda (&optional check)
-         (if check
-             ,forced
-           (unless ,forced
-             (setf ,val (progn ,@body))
-             (setf ,forced t))
-           ,val)))))
+  `(let (forced
+         (val (lambda () ,@body)))
+     (lambda (&optional check)
+       (if check
+           forced
+         (unless forced
+           (setf val (funcall val))
+           (setf forced t))
+         val))))
 
 (defun thunk-force (delayed)
   "Force the evaluation of DELAYED.

Re: [elpa] master b5f4061: Drop forced lambda's from stream (Bug#30626)

[Noam Postavsky]

On Tue, 4 Jun 2019 at 09:27, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> >     Let the stream id distinguish between forced and unforced stream
> >     values.  When the value is forced, replace the lambda with its result.
> >     This lets the lambda and anything it references be garbage collected.
>
> Doesn't the same "memory leak" affect thunks?

Yes.

> How 'bout the patch below

Looks good to me. I would have done something like that if I'd thought of it.

Re: [elpa] master b5f4061: Drop forced lambda's from stream (Bug#30626)

[Stefan Monnier]

>> >     Let the stream id distinguish between forced and unforced stream
>> >     values.  When the value is forced, replace the lambda with its result.
>> >     This lets the lambda and anything it references be garbage collected.
>> Doesn't the same "memory leak" affect thunks?
> Yes.

Thanks, pushed,


        Stefan