From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24956: 26.0.50; On Windows, setting PATH in compilation-environment has no effect Date: Tue, 22 Nov 2016 17:35:17 -0500 Message-ID: References: <87wpg383pb.fsf@telefonica.net> <83k2c1esbp.fsf@gnu.org> <83wpg1ce8b.fsf@gnu.org> <83shqoaqhy.fsf@gnu.org> <8337ij8pwj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113d7e18086cf90541eb636d X-Trace: blaine.gmane.org 1479854222 30138 195.159.176.226 (22 Nov 2016 22:37:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 22 Nov 2016 22:37:02 +0000 (UTC) Cc: =?UTF-8?Q?=C3=93scar?= Fuentes , 24956@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 22 23:36:58 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9JgP-0007Zj-H0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Nov 2016 23:36:57 +0100 Original-Received: from localhost ([::1]:58327 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9JgT-0006y8-59 for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Nov 2016 17:37:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9Jfc-0005wW-7V for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 17:36:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9JfW-0000Ny-Vv for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 17:36:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9JfW-0000Nn-SB for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 17:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c9JfW-0003ft-NN for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2016 17:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2016 22:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24956-submit@debbugs.gnu.org id=B24956.147985412513999 (code B ref 24956); Tue, 22 Nov 2016 22:36:02 +0000 Original-Received: (at 24956) by debbugs.gnu.org; 22 Nov 2016 22:35:25 +0000 Original-Received: from localhost ([127.0.0.1]:38691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9Jev-0003dj-2D for submit@debbugs.gnu.org; Tue, 22 Nov 2016 17:35:25 -0500 Original-Received: from mail-oi0-f47.google.com ([209.85.218.47]:34081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9Jet-0003dM-UY for 24956@debbugs.gnu.org; Tue, 22 Nov 2016 17:35:24 -0500 Original-Received: by mail-oi0-f47.google.com with SMTP id y198so34450028oia.1 for <24956@debbugs.gnu.org>; Tue, 22 Nov 2016 14:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=wP3sQ+/Qblnil9EFaUmtY0GQuW7I1hKPr6shhSfLQas=; b=radgWhR/4oZaNmBQc6unFpKMUYSFhd8Q2zb795c+zmB6H6vou7HGuCO5Zig/cnYEb/ n3iOYOhnzKRSvhzjqNLFgzfroXrC5qCEj3ETunTcgSwxIlRwpAe/6MWwbUUoO5ixocp4 dHU3nDwmKKqK1zThTxe7FCWZx/UNqcca+zS1gz32abo/hyQuuhZIaGJxDPp0pylaaxjh lSu+b4Dyvye6uIHWWniDUgUVvoL0VFs1xIC/+IYreQog1rmOMRAvCLdOKaEmXd5M/D7p hMuGLcneSc9023HndNOgnuBOIH654z/V2p0WzEh0zNDSXR2Z24Qcjk5tULa9QeynTIfF NtNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=wP3sQ+/Qblnil9EFaUmtY0GQuW7I1hKPr6shhSfLQas=; b=BMLy/fQ8PwaY5WPfr4h2Gp5s72GGSFAm8Oe6UWYslWWspfU6ClSJdyJZyfMzzN7cB7 GU8v4FHkM8y1lXwph5cWpEvbnrh1Ed5TsmHzsZL//8acOvzBPsalkb7pE3fBK3dT2t6a 7MZsbTVQ8VhknMd9q2K4vGySgxPB855JAY2VQZHPK6OEvp88GySaeDQA/yN2E2EhHKGZ wVExmvo6o1tfaMb0YHmMbao3lOEoeJntnHTZQ5WOumm64yVmNx1kJGPMjjnWwCznJsef GO2SreEZxXcB6Ryuxaa036Ta3fb1y4lzZPrhUsih3U1HUIxB+UmK9LmYSLP+W6hb53c0 nTpQ== X-Gm-Message-State: AKaTC01hTVwQ+Av9DTGwt6vkBy2CR1mbsSorwjh+xn+H12ExtNolY3beHwTzQnQC82LRoOzOLdICq8ui79vYRQ== X-Received: by 10.157.53.50 with SMTP id o47mr13747086otc.19.1479854118156; Tue, 22 Nov 2016 14:35:18 -0800 (PST) Original-Received: by 10.157.4.67 with HTTP; Tue, 22 Nov 2016 14:35:17 -0800 (PST) In-Reply-To: <8337ij8pwj.fsf@gnu.org> X-Google-Sender-Auth: WmKT9Mi8NwiuLM4-aeRMU5jh_LU X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125998 Archived-At: --001a113d7e18086cf90541eb636d Content-Type: text/plain; charset=UTF-8 On Tue, Nov 22, 2016 at 11:01 AM, Eli Zaretskii wrote: > > Why not compare in using _strnicmp instead of Fcompare_strings? That > would save you the need to cons Lisp strings, and will be more > efficient (Fcompare_strings is quite complex). Not that speed matters > in this case, but it's just looks strange to me. Am I missing > something? Oops. Looking at Fupcase, I had somehow thought that unibyte vs multibyte would be a problem (and hence I should use Fcompare_strings to hide the details), but actually (as I think you've mentioned before) that's not the case for environment variables. Here's a new patch. --001a113d7e18086cf90541eb636d Content-Type: application/octet-stream; name="v3-0001-Upcase-Path-and-ComSpec-in-process-environment.patch" Content-Disposition: attachment; filename="v3-0001-Upcase-Path-and-ComSpec-in-process-environment.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ivu2vdep0 RnJvbSBlY2I4YTdlYTAyODIzNWU2N2E5NTVlNjNjNWVlMWNhNWQ1NzRiMDRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBGcmksIDE4IE5vdiAyMDE2IDE2OjI2OjUzIC0wNTAwClN1YmplY3Q6IFtQQVRDSCB2M10g VXBjYXNlIFBhdGggYW5kIENvbVNwZWMgaW4gcHJvY2Vzcy1lbnZpcm9ubWVudAoKU2luY2UgMjAx Ni0wNy0xOCAiS2VlcCB3MzIgZW52aXJvbm1lbnQgc2V0dGluZ3MgaW50ZXJuYWwgb25seSIsIHRo ZQp1cGNhc2luZyBvZiBlbnZpcm9ubWVudCB2YXJpYWJsZXMgIlBhdGgiIGFuZCAiQ29tU3BlYyIg b2NjdXJlZCBhZnRlcgppbml0aWFsaXppbmcgcHJvY2Vzcy1lbnZpcm9ubWVudC4gIFRoaXMgbWVh bnQgdGhhdCBMaXNwIGNvZGUgdHJ5aW5nIHRvCm92ZXJyaWRlICJQQVRIIiBlbnZpcm9ubWVudCBo YWQgbm8gZWZmZWN0IChCdWcgIzI0OTU2KS4KCiogc3JjL3czMi5jIChpbml0X2Vudmlyb25tZW50 KTogVXBjYXNlIHRoZSAiUGF0aCIgYW5kICJDb21TcGVjIiBlbnRyaWVzCmluIFZwcm9jZXNzX2Vu dmlyb25tZW50LgotLS0KIHNyYy93MzIuYyB8IDI1ICsrKysrKysrKysrKysrKysrKysrKy0tLS0K IDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL3NyYy93MzIuYyBiL3NyYy93MzIuYwppbmRleCBhZDdkOTRhLi4wODZjMWFjIDEwMDY0 NAotLS0gYS9zcmMvdzMyLmMKKysrIGIvc3JjL3czMi5jCkBAIC0yODYzLDEyICsyODYzLDI5IEBA IGluaXRfZW52aXJvbm1lbnQgKGNoYXIgKiogYXJndikKICAgICAgVGhlIHNhbWUgYXBwbGllcyB0 byBDT01TUEVDLiAgKi8KICAgewogICAgIGNoYXIgKiogZW52cDsKKyAgICBjb25zdCBjaGFyICpw YXRoID0gIlBBVEg9IjsKKyAgICBpbnQgcGF0aF9sZW4gPSBzdHJsZW4gKHBhdGgpOworICAgIGNv bnN0IGNoYXIgKmNvbXNwZWMgPSAiQ09NU1BFQz0iOworICAgIGludCBjb21zcGVjX2xlbiA9IHN0 cmxlbiAoY29tc3BlYyk7CiAKICAgICBmb3IgKGVudnAgPSBlbnZpcm9uOyAqZW52cDsgZW52cCsr KQotICAgICAgaWYgKF9zdHJuaWNtcCAoKmVudnAsICJQQVRIPSIsIDUpID09IDApCi0JbWVtY3B5 ICgqZW52cCwgIlBBVEg9IiwgNSk7Ci0gICAgICBlbHNlIGlmIChfc3RybmljbXAgKCplbnZwLCAi Q09NU1BFQz0iLCA4KSA9PSAwKQotCW1lbWNweSAoKmVudnAsICJDT01TUEVDPSIsIDgpOworICAg ICAgaWYgKF9zdHJuaWNtcCAoKmVudnAsIHBhdGgsIHBhdGhfbGVuKSA9PSAwKQorICAgICAgICBt ZW1jcHkgKCplbnZwLCBwYXRoLCBwYXRoX2xlbik7CisgICAgICBlbHNlIGlmIChfc3RybmljbXAg KCplbnZwLCBjb21zcGVjLCBjb21zcGVjX2xlbikgPT0gMCkKKyAgICAgICAgbWVtY3B5ICgqZW52 cCwgY29tc3BlYywgY29tc3BlY19sZW4pOworCisgICAgLyogTWFrZSB0aGUgc2FtZSBtb2RpZmlj YXRpb24gdG8gYHByb2Nlc3MtZW52aXJvbm1lbnQnIHdoaWNoIGhhcworICAgICAgIGFscmVhZHkg YmVlbiBpbml0aWFsaXplZCBpbiBzZXRfaW5pdGlhbF9lbnZpcm9ubWVudC4gICovCisgICAgZm9y IChMaXNwX09iamVjdCBlbnYgPSBWcHJvY2Vzc19lbnZpcm9ubWVudDsgQ09OU1AgKGVudik7IGVu diA9IFhDRFIgKGVudikpCisgICAgeworICAgICAgTGlzcF9PYmplY3QgZW50cnkgPSBYQ0FSIChl bnYpOworICAgICAgaWYgKF9zdHJuaWNtcCAoU0RBVEEgKGVudHJ5KSwgcGF0aCwgcGF0aF9sZW4p ID09IDApCisgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgcGF0aF9sZW47IGkrKykKKyAgICAg ICAgICBTU0VUIChlbnRyeSwgaSwgcGF0aFtpXSk7CisgICAgICBlbHNlIGlmIChfc3RybmljbXAg KFNEQVRBIChlbnRyeSksIGNvbXNwZWMsIGNvbXNwZWNfbGVuKSA9PSAwKQorICAgICAgICBmb3Ig KGludCBpID0gMDsgaSA8IGNvbXNwZWNfbGVuOyBpKyspCisgICAgICAgICAgU1NFVCAoZW50cnks IGksIGNvbXNwZWNbaV0pOworICAgIH0KICAgfQogCiAgIC8qIFJlbWVtYmVyIHRoZSBpbml0aWFs IHdvcmtpbmcgZGlyZWN0b3J5IGZvciBnZXRjd2QuICAqLwotLSAKMi42LjIud2luZG93cy4xCgo= --001a113d7e18086cf90541eb636d--