From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106) Date: Fri, 31 Mar 2017 10:17:51 -0400 Message-ID: References: <20170328002231.12647.93735@vcs0.savannah.gnu.org> <20170328002231.E5CCC220D2@vcs0.savannah.gnu.org> <87lgrm6qed.fsf@holos> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1490969886 13543 195.159.176.226 (31 Mar 2017 14:18:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 31 Mar 2017 14:18:06 +0000 (UTC) Cc: Stefan Monnier , Emacs developers To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 31 16:18:02 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctxNC-0002TA-Ca for ged-emacs-devel@m.gmane.org; Fri, 31 Mar 2017 16:17:54 +0200 Original-Received: from localhost ([::1]:41320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctxNI-0000Xf-4O for ged-emacs-devel@m.gmane.org; Fri, 31 Mar 2017 10:18:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctxNC-0000XL-24 for emacs-devel@gnu.org; Fri, 31 Mar 2017 10:17:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctxNB-0002WN-5m for emacs-devel@gnu.org; Fri, 31 Mar 2017 10:17:54 -0400 Original-Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]:34899) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctxNB-0002Ve-0y for emacs-devel@gnu.org; Fri, 31 Mar 2017 10:17:53 -0400 Original-Received: by mail-oi0-x22f.google.com with SMTP id f193so61827298oib.2 for ; Fri, 31 Mar 2017 07:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YIllDhE1tSbopnON3auSb5RLzS13GSvTcN4BU++txRQ=; b=b8Fjat328UhHHXZiV2KOj6NjYDofr+pWtRtamMNQNKxJUzYcYZ6PfXO6surQIZBhZc xCS5nDcWwWBel5bJewez4I8NO5TDV+7Xe3x/2Jqy9UgsEjPuSuMdT3D0eE+bjTZ1Z0dQ pAsUoataR1JzQ1T1m0OIa1MpmlDpa6jbHw28CeF0yaJACtmHvuYVZ1Dt4Yr4OnyLTvou U+IWkn0/jgtxoYWqnf5Pox3gjqCOi7ojHfvQ87H9hr3UgmRC6pYx1+sMtMj0UPh8ofXb NKj7Ppl390u37IssW0A2o23QIKH/Hd4B4CsPWl7y9x8n9gM9DpZb/U235OItfVi/+33Y BIYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YIllDhE1tSbopnON3auSb5RLzS13GSvTcN4BU++txRQ=; b=YOoJnoVIJ1XNVr7UyexBAv4PGMQbuRiw8pqFM5Jd1Zqr/vrnuKp33N3eebIO2PMgiA 4zClTR2Tpwtc2xbh4RUW8SG/i3sAjg1JuUXborIDXD2XNABotv+JalT8ATAFi9atKxfk Dx5XIe4MWJnys00Rt+gB2x0wRhKdqOaNIZQR0U3eHoT0ttuV43dqCO6h7edagsoK6qPD brAK40DHuMLO4tM5LRzXWjcbnei7b1Ib803heCbwlHR7dk792y59pPqZC93fl5Kr6XX5 NHStPVI3qIgN3SAABD0+0KS1wDSNWtriN8tf2yWIBmkxz56AYp71Kbd1IfHGmsTouuYC 9RoA== X-Gm-Message-State: AFeK/H1R98UkB/C5nm0U29Gsj1Di8vBdusJOBfFvHMvjeWtMhxhydohp30OFn55IpzNXtfzR1lGwcSDrKzzX1g== X-Received: by 10.157.13.72 with SMTP id 66mr1963451oti.6.1490969872143; Fri, 31 Mar 2017 07:17:52 -0700 (PDT) Original-Received: by 10.157.80.133 with HTTP; Fri, 31 Mar 2017 07:17:51 -0700 (PDT) In-Reply-To: <87lgrm6qed.fsf@holos> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213564 Archived-At: On Fri, Mar 31, 2017 at 12:06 AM, Mark Oteiza wrote: > > These changes break isearching through an info manual--in particular, an > incremental search can no longer cross nodes. > > I-search: cats [(user-error Search failed: `cats' (end of node))] Oops, indeed my fix is no good. I should have defined a new `user-search-failed' with `user-error' and `search-failed' as parents and signaled that instead of switching to plain `user-error'. I will send a patch along those lines to Bug#6106 in a day or two.