From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: replacing ldefs-boot.el Date: Fri, 25 Nov 2016 16:11:32 -0500 Message-ID: References: <87bmxa6o37.fsf@russet.org.uk> <83y40e7y65.fsf@gnu.org> <87twb16dta.fsf@russet.org.uk> <83vavh8qci.fsf@gnu.org> <87a8csij8c.fsf@russet.org.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1480108337 17006 195.159.176.226 (25 Nov 2016 21:12:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 25 Nov 2016 21:12:17 +0000 (UTC) Cc: Eli Zaretskii , Emacs developers To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 25 22:12:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cANmz-0002rT-48 for ged-emacs-devel@m.gmane.org; Fri, 25 Nov 2016 22:12:09 +0100 Original-Received: from localhost ([::1]:47915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cANn2-0004Sj-O9 for ged-emacs-devel@m.gmane.org; Fri, 25 Nov 2016 16:12:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cANmS-0004Sc-Lq for emacs-devel@gnu.org; Fri, 25 Nov 2016 16:11:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cANmR-00013R-PA for emacs-devel@gnu.org; Fri, 25 Nov 2016 16:11:36 -0500 Original-Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]:35082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cANmQ-00012W-50; Fri, 25 Nov 2016 16:11:34 -0500 Original-Received: by mail-oi0-x229.google.com with SMTP id b126so92477423oia.2; Fri, 25 Nov 2016 13:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Sgwtc5RsVjvlX9si9e/nUuMjbLz1XhXC5++CiJiJxhA=; b=Ue9SdObX89hb34ItaNoR/SMBRlVoUW4G9Nw788stlUo+EFMlR9LpP4AzgyhzYRpZpf f5xBu+Z1lCEW2tiFgpo4vNFRgvRHKv5V9boPozGja1x9BCKcMfe8Ebk0A2YqddflMm1b btiY7wqS7g7wfGJxtaLgIIg/+7T4fAKL1oZEzO21fNMFp3oQwwJNAZBPlBcHK88vg67i xU2Zv0bw2Qk10xccruAT8IOolkcJObNuBGmCK4tKpcNmZpL+d+7MM/Xl7t9HjZkvvq1F u1oFwyhaO3nDTXfoSMSR12agMkDjRzV1lvyYM0c6MocgBz/K+VkZu63m1P5Qyw8D82/t VV8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Sgwtc5RsVjvlX9si9e/nUuMjbLz1XhXC5++CiJiJxhA=; b=Mt6J6P6GVqPaFKSp8NjXStXQ+QaYLg7FxNRK0kFUzzW1jL3blmqn5sQumz8mMAVsji NhoOyaAew/9IMDcaUSTmw/r7OKhlxMxbZYFkK8oOtRDMtfti+rFgwPby64CVWeRWW8m3 ITRC4MBW6HbO8oVlKcnpNcDIUKuDZPcEUXLJXW/pzTDHI5MQxeffCirGnB+UsVbcNyVr zwI7gn6tcns1kkrgBRQvP/13+OQpIJc1j99gE7SKkquj7ASG9aBBbBXqRFLFo0tnjTic RDqITHFqtZlkz8OA3SBu9EEB4AEG2AYKZeKwammaRyXvHYHmNCe2NodIyIP7hmCpo+7o /x/Q== X-Gm-Message-State: AKaTC02hBEa0BkQdSsmMXXkusvXf3DK1nWUBoJkFHopUD31NnZ948Paq2e1vJIGhIzpDIfQXCgkeurCjxyqXqg== X-Received: by 10.157.58.119 with SMTP id j110mr5701051otc.208.1480108293457; Fri, 25 Nov 2016 13:11:33 -0800 (PST) Original-Received: by 10.157.4.67 with HTTP; Fri, 25 Nov 2016 13:11:32 -0800 (PST) In-Reply-To: <87a8csij8c.fsf@russet.org.uk> X-Google-Sender-Auth: oUsvEmOTYpOtts0dbCs7IgnjtUU X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209593 Archived-At: On Mon, Nov 21, 2016 at 5:03 PM, Phillip Lord wrote: > > ldefs-boot-auto.el is now autogenerated from a make target at top level. > It works but augmenting eval.c, so that when an autoload happens, Emacs > writes to system stdout the equivalent autoload form. A complete > bootstrap build will, therefore, print all the autoloads that are > actually used. There's some lisp in admin/ldefs-clean.el which removes > everything except these lisp forms. > > Advantages: > > - we still have an autogenerated file in the repo, but it is very much > smaller (160 lines vs 40k). > > Disadvantages: > > - generating ldefs-boot-auto is a lot slower (i.e. cp loaddefs.el > ldefs-boot.el vs a complete bootstrap build of Emacs). > Is it possible another disadvantage would be that ldefs-boot-auto requires regeneration more often (because the list of autoloads used is more precise)? I notice several almost duplicated lines in ldefs-boot-auto.el, like (autoload 'byte-compile "bytecomp" nil nil nil) (autoload 'byte-compile "bytecomp" nil nil t) byte-compile isn't a macro; I think you should put your addition to Fautoload_do_load after the "if (EQ (macro_only, Qmacro))" check to avoid falsely identifying macros. Instead of printing the autoload lines directly to stderr and then cleaning up afterwards, wouldn't it be simpler to collect them into a hashtable, and write to a file at the end? And doesn't this change in Makefile.in break parallel 'make bootstrap' invocations? -bootstrap: bootstrap-clean +bootstrap: bootstrap-clean bootstrap-build + +bootstrap-build: