From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist Date: Tue, 9 Apr 2019 10:13:58 -0400 Message-ID: References: <83y34k728d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000001eea3d0586199186" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="121891"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33016@debbugs.gnu.org, Klaus-Dieter Bauer To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 09 16:15:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDrWs-000VS4-El for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 16:15:14 +0200 Original-Received: from localhost ([127.0.0.1]:42351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDrWr-00065c-EJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 10:15:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDrWh-00064A-F3 for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 10:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDrWg-0000s7-DW for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 10:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38268) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDrWg-0000s1-7i for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 10:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDrWg-0002ic-1X for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2019 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2019 14:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33016 X-GNU-PR-Package: emacs Original-Received: via spool by 33016-submit@debbugs.gnu.org id=B33016.155481925910373 (code B ref 33016); Tue, 09 Apr 2019 14:15:01 +0000 Original-Received: (at 33016) by debbugs.gnu.org; 9 Apr 2019 14:14:19 +0000 Original-Received: from localhost ([127.0.0.1]:51812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDrVy-0002hE-Vr for submit@debbugs.gnu.org; Tue, 09 Apr 2019 10:14:19 -0400 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:43001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDrVw-0002gw-CC for 33016@debbugs.gnu.org; Tue, 09 Apr 2019 10:14:16 -0400 Original-Received: by mail-oi1-f177.google.com with SMTP id w139so13626311oie.9 for <33016@debbugs.gnu.org>; Tue, 09 Apr 2019 07:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Bj/9Soz6z+HLXjLELv7LepKqPpBvMOH6fKyBZXVTe5Y=; b=BgagIx+yF6sTdXom8ndTijb5wruvRFHlPuoAmgBESdqBeR3+k0xyIevP1Z+yO0s4Go nh+kmmDADU7bQxADTmPwAXR0+uwhs1Ny5x7h3zj0U51tc/G3PW/XW/+8JsYC4MCBDM9U 3PsHLzH7jdZ/j4j7ly28pD6BM85Pv2MOO7nCMOfzzvfYaEsOTjtZTNlzh3WV6mv6SGgJ e2bmxIlM4tc8xWG/03Ln4svjg0enAXxengrRTD6d8r4hOmcsaWXUjrFqWKoSA3RzZHOh 7q9Yf3Js3vQqpgBwX4Km1dJizsEkPI74jpt9SzVoB0ze1LhzuA4KmCzKzlqWAjQ9dmEH 16Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bj/9Soz6z+HLXjLELv7LepKqPpBvMOH6fKyBZXVTe5Y=; b=P2It/5QDABN3TuNg1zDQLqyK+UD6cFJF1LBe3AghyrcO1xRQ0njNlgOw7xWp7iC+hM qBX+cW+pbs13vhZIGJTFw773HU+1tdAr70czAOO29N9CK8YaqLFWpkTwucdT31QK5iJq RW8xetJlEUwHusbUqMw8SgQp+dSpz5+mo28o7tjQtVvku9UsbiqqYB28ZmpBHJbuu5mj 6NqQIaHJW8y8JBXNyv0zlz2+/sPBB3eZDDxaZdqE0A5/ZGCv2OV/oPbz3U1AolhTkPct YXRSHnAr7OG15C9SXVkRdsmRy72iDswQeyoWcjr7qoJRgEbxvjX+XK36i2SjKlq97urG /Q+Q== X-Gm-Message-State: APjAAAXDyfUjprFuHnbOBQxhIrbnY0xdAp8hL3PkQBWiw8B6ViTUoFc+ jY/qXs9PlbH5y5Xwu8zIhz/sx4CLnm9F1hG3g6s= X-Google-Smtp-Source: APXvYqyrTgc8y8RtQofoptcku/ze+GfCSXoVOfG0w5MJhs3sfdp8GTGlOBws53Mi28VJUGPCOU8Yd3j4jn2fsvt5xdA= X-Received: by 2002:aca:bf08:: with SMTP id p8mr18828567oif.173.1554819250557; Tue, 09 Apr 2019 07:14:10 -0700 (PDT) In-Reply-To: <83y34k728d.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157415 Archived-At: --0000000000001eea3d0586199186 Content-Type: text/plain; charset="UTF-8" On Mon, 8 Apr 2019 at 14:59, Eli Zaretskii wrote: > > The confusing thing here is that the error is signaled between > > block_input()...unblock_input(), which prevents the debugger from > > triggering. > > The attached patch fixes this by moving the signal to after the unblock_input(). > > Thanks, but could we have a test for this, please? Yes (I had initially thought it wouldn't work because of the way ert uses the debugger internally, but it actually turns out fine). By the way, I modified the error message in call_process in addition to create_process for completeness, but I can't see a way to trigger this for call_process: it searches for PROGRAM and signals an error early, regardless of whether the filename is absolute or not. --0000000000001eea3d0586199186 Content-Type: application/octet-stream; name="v2-0001-Let-debugger-handle-process-spawn-errors-on-w32-B.patch" Content-Disposition: attachment; filename="v2-0001-Let-debugger-handle-process-spawn-errors-on-w32-B.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ju9v47zb0 RnJvbSBkNzc2MmYyNTk5Y2JkMmZlZDFiNjYxYjYwZGFjZjZmZDQ0NGE3ZjM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBNb24sIDggQXByIDIwMTkgMTc6NTc6MjIgLTA0MDAKU3ViamVjdDogW1BBVENIIHYyXSBM ZXQgZGVidWdnZXIgaGFuZGxlIHByb2Nlc3Mgc3Bhd24gZXJyb3JzIG9uIHczMgogKEJ1ZyMzMzAx NikKClNpbmNlIGNoaWxkX3NldHVwKCkgaXMgY2FsbGVkIGJldHdlZW4gYmxvY2tfaW5wdXQoKS4u LnVuYmxvY2tfaW5wdXQoKSwKd2hlbiBhbiBlcnJvciBpcyBzaWduYWxlZCB0aGUgTGlzcCBkZWJ1 Z2dlciBpcyBwcmV2ZW50ZWQgZnJvbQpzdGFydGluZy4gIFRoZXJlZm9yZSwgbGV0IHRoZSBjYWxs ZXJzIHNpZ25hbCB0aGUgZXJyb3IgaW5zdGVhZCAod2hpY2gKdGhleSBhbHJlYWR5IGRvIGZvciBu b24tdzMyIHBsYXRmb3JtcywganVzdCB0aGUgZXJyb3IgbWVzc2FnZSBuZWVkcyBhbgp1cGRhdGUp LgoqIHNyYy9jYWxscHJvYy5jIChjaGlsZF9zZXR1cCkgW1dJTkRPV1NOVF06IERvbid0IGNhbGwK cmVwb3J0X2ZpbGVfZXJyb3IgaGVyZS4KKGNhbGxfcHJvY2VzcykgW1dJTkRPV05UXToKKiBzcmMv cHJvY2Vzcy5jIChjcmVhdGVfcHJvY2VzcykgW1dJTkRPV1NOVF06IENhbGwgcmVwb3J0X2ZpbGVf ZXJybm8KaGVyZSBpbnN0ZWFkLCBhZnRlciB0aGUgdW5ibG9ja19pbnB1dCgpIGNhbGwsIHNhbWUg YXMgZm9yICFXSU5ET1dTTlQuCiogc3JjL2xpc3AuaCAoQ0hJTERfU0VUVVBfRVJST1JfREVTQyk6 IE5ldyBwcmVwcm9jZXNzb3IgZGVmaW5lLgoqIHRlc3Qvc3JjL3Byb2Nlc3MtdGVzdHMuZWwgKG1h a2UtcHJvY2Vzcy13MzItc3Bhd24tbm9uZXhpc3RlbnQpOiBOZXcKdGVzdC4KLS0tCiBzcmMvY2Fs bHByb2MuYyAgICAgICAgICAgIHwgIDcgKystLS0tLQogc3JjL2xpc3AuaCAgICAgICAgICAgICAg ICB8ICA2ICsrKysrKwogc3JjL3Byb2Nlc3MuYyAgICAgICAgICAgICB8ICAyICstCiB0ZXN0L3Ny Yy9wcm9jZXNzLXRlc3RzLmVsIHwgMTIgKysrKysrKysrKysrCiA0IGZpbGVzIGNoYW5nZWQsIDIx IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2NhbGxwcm9j LmMgYi9zcmMvY2FsbHByb2MuYwppbmRleCBhM2QwOTYwLi4yY2RmODRkIDEwMDY0NAotLS0gYS9z cmMvY2FsbHByb2MuYworKysgYi9zcmMvY2FsbHByb2MuYwpAQCAtNjgxLDcgKzY4MSw3IEBAIGNh bGxfcHJvY2VzcyAocHRyZGlmZl90IG5hcmdzLCBMaXNwX09iamVjdCAqYXJncywgaW50IGZpbGVm ZCwKICAgdW5ibG9ja19pbnB1dCAoKTsKIAogICBpZiAocGlkIDwgMCkKLSAgICByZXBvcnRfZmls ZV9lcnJubyAoIkRvaW5nIHZmb3JrIiwgUW5pbCwgY2hpbGRfZXJybm8pOworICAgIHJlcG9ydF9m aWxlX2Vycm5vIChDSElMRF9TRVRVUF9FUlJPUl9ERVNDLCBRbmlsLCBjaGlsZF9lcnJubyk7CiAK ICAgLyogQ2xvc2Ugb3VyIGZpbGUgZGVzY3JpcHRvcnMsIGV4Y2VwdCBmb3IgY2FsbHByb2NfZmRb Q0FMTFBST0NfUElQRVJFQURdCiAgICAgIHNpbmNlIHdlIHdpbGwgdXNlIHRoYXQgdG8gcmVhZCBp bnB1dCBmcm9tLiAgKi8KQEAgLTExNzQsNyArMTE3NCw3IEBAIGV4ZWNfZmFpbGVkIChjaGFyIGNv bnN0ICpuYW1lLCBpbnQgZXJyKQogICAgZXhlY3V0YWJsZSBkaXJlY3RvcnkgYnkgdGhlIHBhcmVu dC4KIAogICAgT24gR05VaXNoIGhvc3RzLCBlaXRoZXIgZXhlYyBvciByZXR1cm4gYW4gZXJyb3Ig bnVtYmVyLgotICAgT24gTVMtV2luZG93cywgZWl0aGVyIHJldHVybiBhIHBpZCBvciBzaWduYWwg YW4gZXJyb3IuCisgICBPbiBNUy1XaW5kb3dzLCBlaXRoZXIgcmV0dXJuIGEgcGlkIG9yIHJldHVy biAtMSBhbmQgc2V0IGVycm5vLgogICAgT24gTVMtRE9TLCBlaXRoZXIgcmV0dXJuIGFuIGV4aXQg c3RhdHVzIG9yIHNpZ25hbCBhbiBlcnJvci4gICovCiAKIENISUxEX1NFVFVQX1RZUEUKQEAgLTEz MTksOSArMTMxOSw2IEBAIGNoaWxkX3NldHVwIChpbnQgaW4sIGludCBvdXQsIGludCBlcnIsIGNo YXIgKipuZXdfYXJndiwgYm9vbCBzZXRfcGdycCwKICAgLyogU3Bhd24gdGhlIGNoaWxkLiAgKFNl ZSB3MzJwcm9jLmM6c3lzX3NwYXdudmUpLiAgKi8KICAgY3BpZCA9IHNwYXdudmUgKF9QX05PV0FJ VCwgbmV3X2FyZ3ZbMF0sIG5ld19hcmd2LCBlbnYpOwogICByZXNldF9zdGFuZGFyZF9oYW5kbGVz IChpbiwgb3V0LCBlcnIsIGhhbmRsZXMpOwotICBpZiAoY3BpZCA9PSAtMSkKLSAgICAvKiBBbiBl cnJvciBvY2N1cnJlZCB3aGlsZSB0cnlpbmcgdG8gc3Bhd24gdGhlIHByb2Nlc3MuICAqLwotICAg IHJlcG9ydF9maWxlX2Vycm9yICgiU3Bhd25pbmcgY2hpbGQgcHJvY2VzcyIsIFFuaWwpOwogICBy ZXR1cm4gY3BpZDsKIAogI2Vsc2UgIC8qIG5vdCBXSU5ET1dTTlQgKi8KZGlmZiAtLWdpdCBhL3Ny Yy9saXNwLmggYi9zcmMvbGlzcC5oCmluZGV4IGEwYTdjYmQuLjZmMzkyNjUgMTAwNjQ0Ci0tLSBh L3NyYy9saXNwLmgKKysrIGIvc3JjL2xpc3AuaApAQCAtNDQ3Nyw2ICs0NDc3LDEyIEBAIGV4dGVy biB2b2lkIHNldHVwX3Byb2Nlc3NfY29kaW5nX3N5c3RlbXMgKExpc3BfT2JqZWN0KTsKICNlbHNl CiAjIGRlZmluZSBDSElMRF9TRVRVUF9UWVBFIGludAogI2VuZGlmCisjaWZkZWYgV0lORE9XU05U CisjIGRlZmluZSBDSElMRF9TRVRVUF9FUlJPUl9ERVNDICJTcGF3bmluZyBjaGlsZCBwcm9jZXNz IgorI2Vsc2UKKyMgZGVmaW5lIENISUxEX1NFVFVQX0VSUk9SX0RFU0MgIkRvaW5nIHZmb3JrIgor I2VuZGlmCisKIGV4dGVybiBDSElMRF9TRVRVUF9UWVBFIGNoaWxkX3NldHVwIChpbnQsIGludCwg aW50LCBjaGFyICoqLCBib29sLCBMaXNwX09iamVjdCk7CiBleHRlcm4gdm9pZCBpbml0X2NhbGxw cm9jXzEgKHZvaWQpOwogZXh0ZXJuIHZvaWQgaW5pdF9jYWxscHJvYyAodm9pZCk7CmRpZmYgLS1n aXQgYS9zcmMvcHJvY2Vzcy5jIGIvc3JjL3Byb2Nlc3MuYwppbmRleCA4MDJhYzAyLi5mZjA4NjU3 IDEwMDY0NAotLS0gYS9zcmMvcHJvY2Vzcy5jCisrKyBiL3NyYy9wcm9jZXNzLmMKQEAgLTIyMzIs NyArMjIzMiw3IEBAIGNyZWF0ZV9wcm9jZXNzIChMaXNwX09iamVjdCBwcm9jZXNzLCBjaGFyICoq bmV3X2FyZ3YsIExpc3BfT2JqZWN0IGN1cnJlbnRfZGlyKQogICB1bmJsb2NrX2lucHV0ICgpOwog CiAgIGlmIChwaWQgPCAwKQotICAgIHJlcG9ydF9maWxlX2Vycm5vICgiRG9pbmcgdmZvcmsiLCBR bmlsLCB2Zm9ya19lcnJubyk7CisgICAgcmVwb3J0X2ZpbGVfZXJybm8gKENISUxEX1NFVFVQX0VS Uk9SX0RFU0MsIFFuaWwsIHZmb3JrX2Vycm5vKTsKICAgZWxzZQogICAgIHsKICAgICAgIC8qIHZm b3JrIHN1Y2NlZWRlZC4gICovCmRpZmYgLS1naXQgYS90ZXN0L3NyYy9wcm9jZXNzLXRlc3RzLmVs IGIvdGVzdC9zcmMvcHJvY2Vzcy10ZXN0cy5lbAppbmRleCA1ZGJmNDQxLi43Nzk2NjVhZCAxMDA2 NDQKLS0tIGEvdGVzdC9zcmMvcHJvY2Vzcy10ZXN0cy5lbAorKysgYi90ZXN0L3NyYy9wcm9jZXNz LXRlc3RzLmVsCkBAIC0yMTUsNiArMjE1LDE4IEBAIHByb2Nlc3MtdGVzdHMtLW1peGFibGUKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy10by1saXN0ICJzdGRv dXRcbiIpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctdG8t bGlzdCAic3RkZXJyXG4iKSkpKSkpCiAKKyhlcnQtZGVmdGVzdCBtYWtlLXByb2Nlc3MtdzMyLXNw YXduLW5vbmV4aXN0ZW50ICgpCisgICJDaGVjayB0aGF0IGRlYnVnZ2VyIHJ1bnMgb24gYG1ha2Ut cHJvY2VzcycgZmFpbHVyZSAoQnVnIzMzMDE2KS4iCisgIChza2lwLXVubGVzcyAoZXEgc3lzdGVt LXR5cGUgJ3dpbmRvd3MtbnQpKQorICAobGV0KiAoKGRlYnVnLW9uLWVycm9yIHQpCisgICAgICAg ICAoaGF2ZS1jYWxsZWQtZGVidWdnZXIgbmlsKQorICAgICAgICAgKGRlYnVnZ2VyIChsYW1iZGEg KCZyZXN0IF8pIChzZXRxIGhhdmUtY2FsbGVkLWRlYnVnZ2VyIHQpKSkpCisgICAgKHNob3VsZCAo ZXEgOmdvdC1lcnJvciA7OyBOT1RFOiBgc2hvdWxkLWVycm9yJyB3b3VsZCBpbmhpYml0IGRlYnVn Z2VyLgorICAgICAgICAgICAgICAgIChjb25kaXRpb24tY2FzZS11bmxlc3MtZGVidWcgKCkKKyAg ICAgICAgICAgICAgICAgICAgKG1ha2UtcHJvY2VzcyA6bmFtZSAidGVzdCIgOmNvbW1hbmQgJygi YzovTm8tU3VjaC1Db21tYW5kIikpCisgICAgICAgICAgICAgICAgICAoZXJyb3IgOmdvdC1lcnJv cikpKSkKKyAgICAoc2hvdWxkIGhhdmUtY2FsbGVkLWRlYnVnZ2VyKSkpCisKIChlcnQtZGVmdGVz dCBtYWtlLXByb2Nlc3MvZmlsZS1oYW5kbGVyL2ZvdW5kICgpCiAgICJDaGVjayB0aGF0IHRoZSDi gJg6ZmlsZS1oYW5kbGVy4oCZIGFyZ3VtZW50IG9mIOKAmG1ha2UtcHJvY2Vzc+KAmQogd29ya3Mg YXMgZXhwZWN0ZWQgaWYgYSBmaWxlIG5hbWUgaGFuZGxlciBpcyBmb3VuZC4iCi0tIAoyLjYuMi53 aW5kb3dzLjEKCg== --0000000000001eea3d0586199186--