From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25025@debbugs.gnu.org, "Clément Pit--Claudel" <clement.pit@gmail.com>
Subject: bug#25025: python-shell-calculate-command is wrong
Date: Fri, 2 Dec 2016 09:16:04 -0500 [thread overview]
Message-ID: <CAM-tV-8PpGFer2wy9AjheipgUzLKCAFBT5T-N8t40oy1bNpgfA@mail.gmail.com> (raw)
In-Reply-To: <83k2biokad.fsf@gnu.org>
On Fri, Dec 2, 2016 at 2:35 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> --- a/lisp/progmodes/python.el
>> +++ b/lisp/progmodes/python.el
>> @@ -2379,7 +2379,7 @@ python-shell-internal-get-process-name
>> (defun python-shell-calculate-command ()
>> "Calculate the string used to execute the inferior Python process."
>> (format "%s %s"
>> - (shell-quote-argument python-shell-interpreter)
>> + (combine-and-quote-strings (list python-shell-interpreter))
>> python-shell-interpreter-args))
>
> Isn't combine-and-quote-strings wrong for quoting shell commands?
> AFAIR, it doesn't DTRT with some special characters that can appear in
> file names on Unix. Am I mistaken?
It's not a shell command though, hence this bug.
>
> But if my fears are unjustified, sure, why not? Clément, WDYT?
next prev parent reply other threads:[~2016-12-02 14:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 6:24 bug#25025: python-shell-calculate-command is wrong Fabrice Popineau
2016-11-25 7:03 ` Clément Pit--Claudel
2016-11-25 8:32 ` Eli Zaretskii
2016-11-25 14:44 ` Clément Pit--Claudel
2016-11-25 14:59 ` Noam Postavsky
2016-11-26 18:43 ` Eli Zaretskii
2016-11-27 0:50 ` Noam Postavsky
2016-11-27 2:35 ` Clément Pit--Claudel
2016-11-27 15:56 ` Eli Zaretskii
2016-11-27 16:06 ` npostavs
2016-11-27 16:12 ` Eli Zaretskii
2016-11-28 8:42 ` Andreas Röhler
2016-11-28 14:15 ` npostavs
2016-11-28 16:43 ` Andreas Röhler
2016-11-30 0:39 ` npostavs
2016-11-30 6:39 ` Andreas Röhler
2016-11-30 17:12 ` Clément Pit--Claudel
2016-11-30 0:36 ` npostavs
2016-11-30 1:35 ` Clément Pit--Claudel
2016-11-30 1:56 ` npostavs
2016-11-30 15:55 ` Eli Zaretskii
2016-11-30 22:10 ` Noam Postavsky
2016-12-01 17:10 ` Eli Zaretskii
2016-12-02 1:12 ` npostavs
2016-12-02 7:35 ` Eli Zaretskii
2016-12-02 14:16 ` Noam Postavsky [this message]
2016-12-02 14:51 ` Eli Zaretskii
2016-12-02 15:07 ` npostavs
2016-12-02 15:46 ` Eli Zaretskii
2016-12-02 16:15 ` Clément Pit--Claudel
2016-12-02 16:41 ` Noam Postavsky
2016-12-02 16:58 ` Clément Pit--Claudel
2016-12-09 5:29 ` npostavs
2017-08-16 11:08 ` npostavs
2017-08-16 14:32 ` Eli Zaretskii
2017-08-16 16:50 ` Noam Postavsky
2017-08-16 16:57 ` Eli Zaretskii
2017-08-16 19:27 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-8PpGFer2wy9AjheipgUzLKCAFBT5T-N8t40oy1bNpgfA@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=25025@debbugs.gnu.org \
--cc=clement.pit@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.