bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Drew Adams]

emacs -Q

C-x (
C-f C-f C-f
C-x )

M-x name-last-kbd-macro RET foo RET
M-x edit-kbd-macro
C-h l

Get error:

 Macros with mouse clicks are not supported by this command

Sometimes I do not see this problem, but most of the time I do.
There is no such problem with Emacs 24.5 or prior, at least.


In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32)
 of 2017-10-13 built on LAPHROAIG
Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Defining kbd macro...
Keyboard macro defined
Formatting keyboard macro...
edmacro-fix-menu-commands: Macros with mouse clicks are not supported by this command
Configured using:
 'configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Eli Zaretskii]

> Date: Wed, 22 Nov 2017 08:13:45 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> 
> emacs -Q
> 
> C-x (
> C-f C-f C-f
> C-x )
> 
> M-x name-last-kbd-macro RET foo RET
> M-x edit-kbd-macro
> C-h l
> 
> Get error:
> 
>  Macros with mouse clicks are not supported by this command

Not reproducible on my system.

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Noam Postavsky]

On Wed, Nov 22, 2017 at 11:13 AM, Drew Adams <drew.adams@oracle.com> wrote:

> Get error:
>
>  Macros with mouse clicks are not supported by this command
>
> Sometimes I do not see this problem, but most of the time I do.
> There is no such problem with Emacs 24.5 or prior, at least.

I can get this error with the following (also in 24.5):

emacs -Q

<click somewhere>
M-x edit-kbd-macro
C-h l

I guess the times when you see the problem are when the lossage
happens to include a mouse click?

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Stefan Kangas]

Noam Postavsky <npostavs@users.sourceforge.net> writes:

> On Wed, Nov 22, 2017 at 11:13 AM, Drew Adams <drew.adams@oracle.com> wrote:
>
>> Get error:
>>
>>  Macros with mouse clicks are not supported by this command
>>
>> Sometimes I do not see this problem, but most of the time I do.
>> There is no such problem with Emacs 24.5 or prior, at least.
>
> I can get this error with the following (also in 24.5):
>
> emacs -Q
>
> <click somewhere>
> M-x edit-kbd-macro
> C-h l
>
> I guess the times when you see the problem are when the lossage
> happens to include a mouse click?

I can't reproduce this on current master with the above recipe.  Are you
still seeing this?

Best regards,
Stefan Kangas

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Noam Postavsky]

found 29397 26.3
tags 29397 fixed
close 29397 27.1
quit

Stefan Kangas <stefan@marxist.se> writes:
>>
>> emacs -Q
>>
>> <click somewhere>
>> M-x edit-kbd-macro
>> C-h l
>>
> I can't reproduce this on current master with the above recipe.  Are you
> still seeing this?

I can reproduce on emacs-26, but not on master; so I'll close the bug as
fixed in 27.1.

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Drew Adams]

> >> Get error:
> >>
> >>  Macros with mouse clicks are not supported by this command
> >>
> >> Sometimes I do not see this problem, but most of the time I do.
> >> There is no such problem with Emacs 24.5 or prior, at least.
> >
> > I can get this error with the following (also in 24.5):
> >
> > emacs -Q
> >
> > <click somewhere>
> > M-x edit-kbd-macro
> > C-h l
> >
> > I guess the times when you see the problem are when the lossage
> > happens to include a mouse click?
> 
> I can't reproduce this on current master with the above recipe.  Are you
> still seeing this?

Yes. I just tried it with `emacs -Q' with Emacs 26.3.  (I can't speak for master.)

The first time I tried the recipe I did not get the error; `C-h l' acted normally.

I followed the recipe again, in the same session, having done nothing in the meantime, I believe, and I got the error.  The second time I followed the recipe I used `C-b C-b C-b', but otherwise I did the same thing.

I think you just have to try a few times and you will see the error.  At least if you have the MS Windows Emacs 26.3 build (64-bit).  That's what I'm using.

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Drew Adams]

Did it again (new Emacs session (-Q)), but with debug-on-error.

It worked correctly the first time, raised the error the second time.  Here's the backtrace:

Debugger entered--Lisp error: (error "Macros with mouse clicks are not supported by this command")
  signal(error ("Macros with mouse clicks are not supported by this command"))
  error("Macros with mouse clicks are not %s" "supported by this command")
  edmacro-fix-menu-commands([(help-echo #<frame emacs@DRADAMS-LAP1 0000000400a4eb80> "mouse-2: visit this file in other window" #<window 3 on *scratch*> #<killed buffer> 1261) 24 107 return 134217848 115 101 116 backspace backspace backspace 116 111 103 103 108 101 45 108 backspace 100 101 108 tab backspace backspace 98 tab 101 tab return up up up right right right right right right 24 40 6 6 6 24 41 134217848 110 97 ...])
  edit-kbd-macro("\010l" nil)
  funcall-interactively(edit-kbd-macro "\010l" nil)
  call-interactively(edit-kbd-macro record nil)
  command-execute(edit-kbd-macro record)
  execute-extended-command(nil "edit-kbd-macro" "edit-kb")
  funcall-interactively(execute-extended-command nil "edit-kbd-macro" "edit-kb")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Drew Adams]

> > emacs -Q
> >
> > C-x (
> > C-f C-f C-f
> > C-x )
> >
> > M-x name-last-kbd-macro RET foo RET
> > M-x edit-kbd-macro
> > C-h l
> >
> > Get error:
> >  Macros with mouse clicks are not supported by this command
> 
> Not reproducible on my system.

Perhaps it's a problem with the build, then.

But I suggest you keep trying.  As stated, occasionally
I do not see it, but I see it nearly all the time (with
this build).

bug#29397: 26.0.90; regression: `C-h l' from `edit-kbd-macro' raises error

[Eli Zaretskii]

> Date: Wed, 22 Nov 2017 09:18:03 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: 29397@debbugs.gnu.org
> 
> But I suggest you keep trying.

I did, and failed.