From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function. Date: Sat, 15 Feb 2020 09:55:36 -0500 Message-ID: References: <20191030121649.15369.13207@vcs0.savannah.gnu.org> <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org> <87eeyutgwa.fsf@gnus.org> <333d1d46-ab79-5818-4367-b28ed915aff6@yandex.ru> <87a79itfzp.fsf@gnus.org> <875zk6tfo7.fsf@gnus.org> <871ruuou5c.fsf@gnus.org> <7fbe5ad6-2ea6-5a5d-d77e-6df2ba143eb4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="24095"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Stefan Monnier , Emacs developers To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 15 15:56:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2ys9-00067l-V8 for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Feb 2020 15:56:45 +0100 Original-Received: from localhost ([::1]:51852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2ys9-0004zV-1W for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Feb 2020 09:56:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39066) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2yrM-0004Rc-Qu for emacs-devel@gnu.org; Sat, 15 Feb 2020 09:55:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2yrL-0000Fy-MG for emacs-devel@gnu.org; Sat, 15 Feb 2020 09:55:56 -0500 Original-Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:34472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2yrL-0000Bm-70 for emacs-devel@gnu.org; Sat, 15 Feb 2020 09:55:55 -0500 Original-Received: by mail-ot1-x335.google.com with SMTP id j16so12015074otl.1 for ; Sat, 15 Feb 2020 06:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BCnDfCfgtelcdUagLJo6IJeWwygD0N4LFKokrX/FySQ=; b=Ula/WbMTYPn9V5BCls49d6OVZc5jNvokJ/uac3PmVjNd3cxnXCnxpT24CT5ze8yh/D V8HQ3CKrgDbv0gWoMk4DqTBSZ53b0p7MlrRx0pJlE/LrzeTa43t4mllvve+nyJyw6uVM YH8ba6ehmFtU98Wrwi16D7O7Fqv9HLKbFt3HqZv69D5fzt0D6KOPzz67pmmjCqo6Jl4n hfxj18aRPtjNhr6YiL41kFNXW7dKHwNwihkHZjTcFBgWtDlw3lHolwgRNDJeekvH2153 z7C4TmL2/RjkWDmzTIYgycdvkaI8BzyxnjrfHIw3MXYtOMxYecAcGr2w7p+JuO/XY2Zu a6Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BCnDfCfgtelcdUagLJo6IJeWwygD0N4LFKokrX/FySQ=; b=kF3al50cAhIpAuR0vdV9Y0nU71dPJtqoaE/2M+xiEpJ3Fuyeop9Li/t4Bu6E5z6vwd XUayJ07I6G575NBgJ2q+UcuZ91Gui2mr1jHmVp5MswXNq+l/uZ7C4r2SSUt7qxF1TBsX NzA3DoyUEhcDYBu9jMNvZ1ZeW9bFQmdHgew5atqZbA8KPReZprjMfwu2EhvB0VJehOmh 3lLaJJJphLzLoSshFXPnOYarE9yGFc1OpzW50DCeLOV8W46JU9Fqnmo4RiEqLv82EHgS kgYs2VVuaCPtL35yam5LVKzz7cjqgwLSTQUp89Pnq0g0r8Kx8aXrgcpTw3RzjXLybX4i Ol8A== X-Gm-Message-State: APjAAAXnKC1X8LI4E1OpC61hhGqZxXjiQQ/tc935U0vbMjJi5hzeotRG m01lTufdGNAQ+9qNZHMv39sPBNXOVY1uD1kGdZ0= X-Google-Smtp-Source: APXvYqzEcp/KcxMGGQe2x9cgRSMqCTj19M5YfD+jm8t/zQbkk1xT5CWMrnyj2VsljbTq++7c8alKYSlQ0bpp3d9dDNo= X-Received: by 2002:a05:6830:98:: with SMTP id a24mr5893520oto.115.1581778553296; Sat, 15 Feb 2020 06:55:53 -0800 (PST) In-Reply-To: <7fbe5ad6-2ea6-5a5d-d77e-6df2ba143eb4@yandex.ru> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::335 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244948 Archived-At: On Fri, 13 Dec 2019 at 08:03, Dmitry Gutov wrote: >> - (innermost-start >> + (list-start > > Sounds ambiguous: the point is that it's innermost, among possible other > list starts. >> - (last-complete-sexp-start >> + (last-sexp-start > > Same (but, like, in reverse): "complete" is important. Not sure I agree, but I can live with the current names. > > - (comment-nesting nil :documentation "\ > > + (comment nil :documentation "\ > > Doesn't this name imply some other value? Like a string (comment opener > or its contents)? Hmm, you might be right about that. How about 'comment-depth': two characters shorter, and the other names also use "depth" rather than "nesting". > > - (comment-or-string-start > > + (context-start > > nil :documentation > > "character address of start of comment or string; nil if not in one.") > > That kind of implies that strings and comments are the most important > contexts when parsing a file. Yeah, I think was I looking at syntax-ppss-context when I originally wrote this, but in that case there is an argument to tell what "context" refers to, so I agree it doesn't really make sense here. > > - (open-paren-positions > > + (open-parens > > nil :documentation > > "List of positions of currently open parens, outermost first.") > > - (two-character-syntax nil :documentation "\ > > + (syntax-sequence nil :documentation "\ > > When the last position scanned holds the first character of a > > (potential) two character construct, the syntax of that position, > > otherwise nil. That construct can be a two character comment > > These look okay to me. I'm actually feeling that the two-character-syntax one should be left as is, it's kind of obscure so having a longer and more explicit name seems better. > min-depth too, but, like last-complete-sexp-start, these fields in > values returned by syntax-ppss are unreliable/undefined, so they won't > be used in most Lisp programs anyway. I might be biased by having worked on the lisp indentation code which uses those fields quite a bit.