From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569) Date: Tue, 18 Jul 2017 18:45:56 -0400 Message-ID: References: <20170718103950.22436.83344@vcs0.savannah.gnu.org> <20170718103952.4E6F720E35@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1500417976 12834 195.159.176.226 (18 Jul 2017 22:46:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Jul 2017 22:46:16 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier , Tak Kunihiro Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 19 00:46:05 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXbFf-0002XZ-BH for ged-emacs-devel@m.gmane.org; Wed, 19 Jul 2017 00:45:59 +0200 Original-Received: from localhost ([::1]:58969 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXbFk-0001Gp-Uw for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 18:46:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXbFe-0001Gi-DC for emacs-devel@gnu.org; Tue, 18 Jul 2017 18:45:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXbFd-0003Jm-LW for emacs-devel@gnu.org; Tue, 18 Jul 2017 18:45:58 -0400 Original-Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]:33327) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXbFd-0003Jf-GL for emacs-devel@gnu.org; Tue, 18 Jul 2017 18:45:57 -0400 Original-Received: by mail-oi0-x22a.google.com with SMTP id p188so29859545oia.0 for ; Tue, 18 Jul 2017 15:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Q7Qu+h7wgfx8IMwW4MdXZNXa1VQueD6fFGiZPQpvoos=; b=OhTgDoxMX6uum9sxpvDQpwOHk14WTDn1ZS1Y852nEeVdnGRLp8jYPGVF9q8zlDdAGh ssDk/ZUmDWzHg2FYeyv5q/bCt51AMN6dMM2fFoO7u1PZA7+6gByaKm344mLhI7N9o0X1 YGtIzUtmiFcxIs77pj1X+bPGgK7ZK+07/NfOaN5mIFNo/fg1y2+RsIdFtUr5ykb+Pq5X jLvV6PpYSaf4KT+vuiHtA1YCMAQGH7MQtBfqtZOeX1ZGbR4Q59deli1znxJiEwXCCo7t QaCIJGyUHeFfybYe9kqJ5MhWfgJ6nCFYgBpYE14tlT+1MaLB56J445E5iBG9EkYqc/pd kPfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Q7Qu+h7wgfx8IMwW4MdXZNXa1VQueD6fFGiZPQpvoos=; b=H6DqH7X7Ixt5w0vefq+KIQTr9NkC+IAPHFaYjRcuF4XsvB/Vc4IzYwbxYy2+W0M2OV GlNZX2M46dK5YWpHHznLYLxrzB54ZtmkjSZ8wKIV3klhuyVCH19BQdhpW6S35vAxhGWg 5Esd7FEE1FA7+fYwWkPFjjmVX3o200nBTTPWD8Znn1QeVcz8zo/aVb/95JfnUbhRlVSS dVrUe/7oUEOtHnd/YkX2e+2tKyXlNe5tr7u/wDj4QmuHDZouEXK7TAO0k2PadO3o7MKy TNKAkpBrEIAGgSrqg9tOa70LWuaOQHKEfLjqimqzyVe3HCnXyAZID/miLOi+sgBcfcGQ 8MWA== X-Gm-Message-State: AIVw112rGVX2Z/SOdGZdMhk8R39EY3Zzf7AeQ+6iWEFla9s4wsZZkoco S2HYkBSUWPaczruHdyhuu96sArfBRA== X-Received: by 10.202.69.197 with SMTP id s188mr2382418oia.148.1500417956693; Tue, 18 Jul 2017 15:45:56 -0700 (PDT) Original-Received: by 10.74.113.91 with HTTP; Tue, 18 Jul 2017 15:45:56 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: a3euwfK-FeeVFT5D2aP7-jH04Ug X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216866 Archived-At: On Tue, Jul 18, 2017 at 2:14 PM, Stefan Monnier wrote: >> Actually, now that I think more on this, could `popup-menu' behave >> more like `universal-argument' (apart from actually setting any prefix >> arg)? It feels kind of prefixy. > > Not sure exactly what you have in mind, Yes, that idea was rather vague and half-baked. While looking at other mouse menus, I found this alternate solution to Bug#27569 (following the technique used for C-down-mouse-3): (define-key global-map [mouse-3] `(menu-item "Edit menu" menu-bar-edit-menu :filter ,(lambda (_) menu-bar-edit-menu))) ;; delete-selection now works correctly with yank invoked via the mouse-3 menu (delete-selection-mode +1) So perhaps my change to popup-menu isn't really needed...