From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Lisp watchpoints Date: Sun, 29 Nov 2015 19:57:05 -0500 Message-ID: References: <83wpt922dn.fsf@gnu.org> <87bnadjb7o.fsf@igel.home> <83lh9gokfm.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1448845040 4067 80.91.229.3 (30 Nov 2015 00:57:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2015 00:57:20 +0000 (UTC) Cc: John Wiegley , Andreas Schwab , Stefan Monnier , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 30 01:57:16 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a3CmK-00035P-60 for ged-emacs-devel@m.gmane.org; Mon, 30 Nov 2015 01:57:16 +0100 Original-Received: from localhost ([::1]:38424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3CmO-0001Gh-2W for ged-emacs-devel@m.gmane.org; Sun, 29 Nov 2015 19:57:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3CmC-0001Eu-Sd for emacs-devel@gnu.org; Sun, 29 Nov 2015 19:57:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3CmC-0003D0-1l for emacs-devel@gnu.org; Sun, 29 Nov 2015 19:57:08 -0500 Original-Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]:34426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3CmA-0003Cm-D1; Sun, 29 Nov 2015 19:57:06 -0500 Original-Received: by ioir85 with SMTP id r85so157903643ioi.1; Sun, 29 Nov 2015 16:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=eyKdlzel9KYOJIDtzPcnWFfZWdiA1G4eyedJdDVzcKw=; b=rLL6xRSbK2k6qKAMpCuWC5bWwvrhHJO1TCc7e+sROp12TXaEF57Eifu0JPmrybk2mv x6xq3RhhBcHlVfVg7TWrBzJMzb4QAXtQNM7nzGOgUwE5Ulx6LY120ovcfmBMNBLhOfTw A/qwGN4Xr1riudB5DeEW5qG0qd5/IWX+J6rAjh5w6CrC6T/4ELjJPYTO2gevsv2qkvox S89Sung8m4maYc63B2DDSAQjnT7NcRtPEIrATsRcePVVhXY6RO9NI1UavYlz3LERnMnK ngLRmw2JGHiCsHtP+0ASUxEhowJF3HEMnHfrmSKGtY5t9Y4E6BY+wrnPQrC+Aee5f0ge 32Sw== X-Received: by 10.107.167.68 with SMTP id q65mr54747733ioe.120.1448845025859; Sun, 29 Nov 2015 16:57:05 -0800 (PST) Original-Received: by 10.79.119.2 with HTTP; Sun, 29 Nov 2015 16:57:05 -0800 (PST) In-Reply-To: <83lh9gokfm.fsf@gnu.org> X-Google-Sender-Auth: HTLGADnDAOjQUNIXuD8xIEHwmEw X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c06::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195592 Archived-At: On Sun, Nov 29, 2015 at 11:10 AM, Eli Zaretskii wrote: >> Date: Sun, 29 Nov 2015 09:12:34 -0500 >> From: Noam Postavsky >> Cc: John Wiegley , Eli Zaretskii , >> Stefan Monnier , emacs-devel@gnu.org >> >> > Ffuncall does all necessary checks. >> >> It would signal in case of error right? Currently the code is ignoring >> bad watcher elements (including out of range integers), but perhaps >> it's actually better to signal an error. > > No, I think it would be better to report an error, and then continue, > perhaps after removing the watch. I'm thinking to just call display-warning then (removing the element looks like too much work to be worthwhile, having to modify the list while iterating over it is kind of annoying). I noticed that display_malloc_warning passes intern ("emergency") as the LEVEL, but it should be intern (":emergency") (with a colon), right?