* Tests involving post-command-hook
@ 2018-07-31 22:10 Stephen Berman
2018-07-31 23:50 ` Noam Postavsky
2018-08-01 11:51 ` Stefan Monnier
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Berman @ 2018-07-31 22:10 UTC (permalink / raw)
To: emacs-devel
I'm using ERT to test for the hl-line face property and it appears that
in the test environment, the function hl-line-highlight is not
automatically run from post-command-hook as it should be, although I use
call-interactively to mimic a command invocation. It works only if I
explicitly call run-hooks. I also see this without ERT:
(let ((buf (get-buffer-create "*hl-line-test*")))
(with-current-buffer buf
(erase-buffer)
(insert "This is a test.\n")
(hl-line-mode)
(call-interactively (lambda () (interactive) (forward-line -1)))
;; (run-hooks 'post-command-hook)
(if (eq 'hl-line (get-char-property (point) 'face))
(message "test1 passed")
(message "test1 failed"))
(hl-line-mode -1)
(erase-buffer)
(insert "This is a test.\n")
(call-interactively (lambda () (interactive) (forward-line -1)))
(hl-line-mode)
(if (eq 'hl-line (get-char-property (point) 'face))
(message "test2 passed")
(message "test2 failed"))
(hl-line-mode -1)
(erase-buffer)
(insert "This is line 1.\nThis is line 2.\n")
(call-interactively (lambda () (interactive) (forward-line -1)))
(hl-line-mode)
(if (eq 'hl-line (get-char-property (point) 'face))
(message "test3.1 passed")
(message "test3.1 failed"))
(call-interactively (lambda () (interactive) (forward-line -1)))
;; (run-hooks 'post-command-hook)
(if (eq 'hl-line (get-char-property (point) 'face))
(message "test3.2 passed")
(message "test3.2 failed")))
(hl-line-mode -1))
Evaluating this in emacs -Q or loading it with emacs --batch yields
this:
test1 failed
test2 passed
test3.1 passed
test3.2 failed
The two successful tests are because hl-line-mode calls
hl-line-highlight before adding it to post-command-hook. Uncommenting
the two (run-hooks 'post-command-hook) lines yields this, which is what
I expected without run-hooks (and what I see when testing without them
interactively):
test1 passed
test2 passed
test3.1 passed
test3.2 passed
Is this behavior of post-command-hook expected and if so, is using
run-hooks in ERT valid, i.e. is it still really testing hl-line-mode
behavior?
Steve Berman
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Tests involving post-command-hook
2018-07-31 22:10 Tests involving post-command-hook Stephen Berman
@ 2018-07-31 23:50 ` Noam Postavsky
2018-08-01 8:47 ` Stephen Berman
2018-08-01 11:51 ` Stefan Monnier
1 sibling, 1 reply; 5+ messages in thread
From: Noam Postavsky @ 2018-07-31 23:50 UTC (permalink / raw)
To: Stephen Berman; +Cc: Emacs developers
On 31 July 2018 at 18:10, Stephen Berman <stephen.berman@gmx.net> wrote:
> Is this behavior of post-command-hook expected and if so, is using
> run-hooks in ERT valid, i.e. is it still really testing hl-line-mode
> behavior?
Asking whether it's "really" testing seems in danger of getting
philosophical, but you might also want to look at ert-simulate-command
which runs those hooks (it doesn't perfectly simulate everything
though).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Tests involving post-command-hook
2018-07-31 23:50 ` Noam Postavsky
@ 2018-08-01 8:47 ` Stephen Berman
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Berman @ 2018-08-01 8:47 UTC (permalink / raw)
To: Noam Postavsky; +Cc: Emacs developers
On Tue, 31 Jul 2018 19:50:14 -0400 Noam Postavsky <npostavs@gmail.com> wrote:
> On 31 July 2018 at 18:10, Stephen Berman <stephen.berman@gmx.net> wrote:
>
>> Is this behavior of post-command-hook expected and if so, is using
>> run-hooks in ERT valid, i.e. is it still really testing hl-line-mode
>> behavior?
>
> Asking whether it's "really" testing seems in danger of getting
> philosophical, but you might also want to look at ert-simulate-command
> which runs those hooks (it doesn't perfectly simulate everything
> though).
Thanks, this indeed works just like calling run-hooks. I didn't mean to
wax philosophical, just wondering whether running a hook function
explicitly in a test when it isn't automatically run as expected is
legitimate in the test environment, and given the existence of
ert-simulate-command, I conclude the answer is yes. Thanks (once again)
for the pointer.
Steve Berman
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Tests involving post-command-hook
2018-07-31 22:10 Tests involving post-command-hook Stephen Berman
2018-07-31 23:50 ` Noam Postavsky
@ 2018-08-01 11:51 ` Stefan Monnier
2018-08-01 12:37 ` Stephen Berman
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2018-08-01 11:51 UTC (permalink / raw)
To: emacs-devel
> I'm using ERT to test for the hl-line face property and it appears that
> in the test environment, the function hl-line-highlight is not
> automatically run from post-command-hook as it should be, although I use
> call-interactively to mimic a command invocation. It works only if I
pre/post-command-hook is run by the command *loop*, not by call-interactively.
The command loop is the chunk of C code which does something like:
(while t
(let ((keys (read-key-sequence)))
(run-hooks 'pre-command-hook)
(call-interactively (key-binding keys))
(run-hooks 'post-command-hook)
(redisplay)))
We don't want call-interactively to run those hooks, because commands
may internally call call-interactively themselves.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Tests involving post-command-hook
2018-08-01 11:51 ` Stefan Monnier
@ 2018-08-01 12:37 ` Stephen Berman
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Berman @ 2018-08-01 12:37 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On Wed, 01 Aug 2018 07:51:06 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> I'm using ERT to test for the hl-line face property and it appears that
>> in the test environment, the function hl-line-highlight is not
>> automatically run from post-command-hook as it should be, although I use
>> call-interactively to mimic a command invocation. It works only if I
>
> pre/post-command-hook is run by the command *loop*, not by call-interactively.
>
> The command loop is the chunk of C code which does something like:
>
> (while t
> (let ((keys (read-key-sequence)))
> (run-hooks 'pre-command-hook)
> (call-interactively (key-binding keys))
> (run-hooks 'post-command-hook)
> (redisplay)))
>
> We don't want call-interactively to run those hooks, because commands
> may internally call call-interactively themselves.
My misunderstanding, thanks for clarifying. In any case, as Noam
Postavsky pointed out, I can get the job done with ert-simulate-command.
Steve Berman
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-01 12:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-31 22:10 Tests involving post-command-hook Stephen Berman
2018-07-31 23:50 ` Noam Postavsky
2018-08-01 8:47 ` Stephen Berman
2018-08-01 11:51 ` Stefan Monnier
2018-08-01 12:37 ` Stephen Berman
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.