From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5f72004: Revert "Fix command repetition with lexical-binding (Bug#29334)" Date: Mon, 8 Jan 2018 21:32:00 -0500 Message-ID: References: <20180107024858.4583.97855@vcs0.savannah.gnu.org> <20180107024859.76DAA2020F@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="f403045e9af637b8c105624eb8e2" X-Trace: blaine.gmane.org 1515465021 15977 195.159.176.226 (9 Jan 2018 02:30:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 Jan 2018 02:30:21 +0000 (UTC) To: Stefan Monnier , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 09 03:30:17 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYjg2-0003MD-Fj for ged-emacs-devel@m.gmane.org; Tue, 09 Jan 2018 03:30:10 +0100 Original-Received: from localhost ([::1]:47402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYji0-0006XC-CH for ged-emacs-devel@m.gmane.org; Mon, 08 Jan 2018 21:32:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYjhr-0006VQ-D0 for emacs-devel@gnu.org; Mon, 08 Jan 2018 21:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYjhq-0002At-H2 for emacs-devel@gnu.org; Mon, 08 Jan 2018 21:32:03 -0500 Original-Received: from mail-wr0-x22a.google.com ([2a00:1450:400c:c0c::22a]:42166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYjhq-0002AT-5m for emacs-devel@gnu.org; Mon, 08 Jan 2018 21:32:02 -0500 Original-Received: by mail-wr0-x22a.google.com with SMTP id w107so12680917wrb.9 for ; Mon, 08 Jan 2018 18:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=KBeSwnWgXitZw2y3Zu7zEdmmTb992z6oc4eQkeW1OgI=; b=jPHnDXfdbQfNRObTU1ng8Pr9DVc7Ku2NN0Sn4bdLhecskeIpme0mxsjvr3NkEulglf NU5qAXQcJrZwoVeDRM46yix/Vr3xgm28rCBOzjRp48zxm3kuBXlerfjUI1qUEVpHQbDA nCS3aPZs5FvL06FDsUaHTvWkePDu4MQukMzzqWhGBeAZqHiHl9pJVg8N2AGOhHCpmPdx a799Iif2MAISoK6KXnPYtVHTw9+JO1Tc6W1elUyNzSxW9POjfB5Thg4Id3Ojrezp2vfU UN6Lw2dKiWCbaj1BZpfV3wb+ZfvJO5Avhqb5lRGU+PtKii0YL08LfrAvXP99KTwPTk5t e7wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=KBeSwnWgXitZw2y3Zu7zEdmmTb992z6oc4eQkeW1OgI=; b=ANIS2t1lE1pJdqbgFPEkCt2U/BQxl4InB68LL9PruIP4nMg57VGvgpwGn64bDGhi+k DUFpjHgxDmhaas2KwDXrllPg0eI6obFUdWad67ETnX44Osq7i010bSq9Ub5lu5Th/eur ygWuFjCwRELbFSjOcAaW94dWT+LJdXs7hZYkMA3P+UP21WGAU+ayi71qqlkTZ6qvD25S el6sMHr785hGOuh0LLtIUN4yOxIyYdTN757aWaEKleun+8jHDZBEXyUBnUEKLUfqS051 XArzXHfNkC2hhWIY1go+stPlvn+tMfJL5fZUAWelYXu7cNGTZ7Rxfql5VS8xe46uBSJ1 c4lA== X-Gm-Message-State: AKGB3mL0ApwiA3oMOLAn2OlFU9xgqPA9zB0QM71U+j68W5pb56Vv2Rk6 sIddkwEQYpav1giI0IBaOzLLoEOv8QVLaaWrflI= X-Google-Smtp-Source: ACJfBosKsDQeY6jxNo0KEYFIcsA+deh5cF68OjedHYCA0Do3Cue9KBwTT2zkVYWrynfKWqOQl/bhq3YOlrfO+CKmlH8= X-Received: by 10.223.162.199 with SMTP id t7mr12434338wra.130.1515465121144; Mon, 08 Jan 2018 18:32:01 -0800 (PST) Original-Received: by 10.223.142.53 with HTTP; Mon, 8 Jan 2018 18:32:00 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221737 Archived-At: --f403045e9af637b8c105624eb8e2 Content-Type: text/plain; charset="UTF-8" On Sun, Jan 7, 2018 at 10:36 AM, Stefan Monnier wrote: >> --- a/src/callint.c >> +++ b/src/callint.c >> @@ -357,9 +357,7 @@ invoke it. If KEYS is omitted or nil, the return value of >> /* Compute the arg values using the user's expression. */ >> specs = Feval (specs, >> CONSP (funval) && EQ (Qclosure, XCAR (funval)) >> - ? CAR_SAFE (XCDR (funval)) >> - : COMPILEDP (funval) && INTEGERP (AREF (funval, COMPILED_ARGLIST)) >> - ? Qt : Qnil); >> + ? CAR_SAFE (XCDR (funval)) : Qnil); > Why? This looks wrong. Hmm, I just reverted to the previous code without actually thinking about it. But after checking this more closely, I find that passing non-nil LEXICAL to `eval' doesn't really do anything for compiled functions anyway: the "lexicalness" has already been applied when compiling. E.g., the above change has no effect on the attached tests. --f403045e9af637b8c105624eb8e2 Content-Type: application/octet-stream; name="callint-tests.el" Content-Disposition: attachment; filename="callint-tests.el" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jc70nytf0 Ozs7IGNhbGxpbnQtdGVzdHMuZWwgLS0tIHRlc3RzIGZvciBzcmMvY2FsbGludC5jIC0qLSBsZXhp Y2FsLWJpbmRpbmc6IHQgLSotCgo7OyBDb3B5cmlnaHQgKEMpIDIwMTggRnJlZSBTb2Z0d2FyZSBG b3VuZGF0aW9uLCBJbmMuCgo7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgRW1hY3MuCgo7OyBH TlUgRW1hY3MgaXMgZnJlZSBzb2Z0d2FyZTogeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29y IG1vZGlmeQo7OyBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBM aWNlbnNlIGFzIHB1Ymxpc2hlZCBieQo7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBl aXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgo7OyAoYXQgeW91ciBvcHRpb24pIGFu eSBsYXRlciB2ZXJzaW9uLgoKOzsgR05VIEVtYWNzIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3Bl IHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCjs7IGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0 aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCjs7IE1FUkNIQU5UQUJJTElUWSBvciBG SVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKOzsgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KCjs7IFlvdSBzaG91bGQgaGF2ZSByZWNl aXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCjs7IGFsb25nIHdp dGggR05VIEVtYWNzLiAgSWYgbm90LCBzZWUgPGh0dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMv Pi4KCjs7OyBDb21tZW50YXJ5OgoKOzs7IENvZGU6CgoocmVxdWlyZSAnZXJ0KQoocmVxdWlyZSAn Ynl0ZWNvbXApCgoKOzsgTk9URTogV2UncmUgcHVycG9zZWx5IGNoZWNraW5nIHRoZSBkeW5hbWlj IHZhbHVlIG9mIHRoZSBzeW1ib2wKOzsgYGNhbGxpbnQtdGVzdHMteCcgKGl0IHNob3VsZCBiZSB2 b2lkKSwgd2hpY2ggbmFtZXMgYSAqbGV4aWNhbCoKOzsgdmFyaWFibGUuCgooZXJ0LWRlZnRlc3Qg Y2FsbGludC1pbnRlcmFjdGl2ZS1mb3JtLWJpbmRpbmctMSAoKQogICJUZXN0IHRoYXQgaW50ZXJh Y3RpdmUgZm9ybSBldmFsdWF0aW9uIHVzZXMgbGV4aWNhbCBiaW5kaW5nLiIKICAobGV0ICgoZnVu CiAgICAgICAgIChsYW1iZGEgKGEgYikKICAgICAgICAgICAoaW50ZXJhY3RpdmUKICAgICAgICAg ICAgKGxpc3QgKGJvdW5kLWFuZC10cnVlLXAgY2FsbGludC10ZXN0cy14KQogICAgICAgICAgICAg ICAgICAoZnVuY2FsbCAobGV0KiAoKGNhbGxpbnQtdGVzdHMteCA0MikpCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGxhbWJkYSAoKSBjYWxsaW50LXRlc3RzLXgpKSkpKQogICAgICAgICAg IChsaXN0IGEgYikpKSkKICAgIChlcnQtaW5mbyAoImludGVycCIpCiAgICAgIChzaG91bGQgKGVx dWFsIChjYWxsLWludGVyYWN0aXZlbHkgZnVuKQogICAgICAgICAgICAgICAgICAgICAnKG5pbCA0 MikpKSkKICAgIChzZXRxIGZ1biAoYnl0ZS1jb21waWxlIGZ1bikpCiAgICAoZXJ0LWluZm8gKCJj b21waWxlZCIpCiAgICAgIChzaG91bGQgKGVxdWFsIChjYWxsLWludGVyYWN0aXZlbHkgZnVuKQog ICAgICAgICAgICAgICAgICAgICcobmlsIDQyKSkpKSkpCgooZXJ0LWRlZnRlc3QgY2FsbGludC1p bnRlcmFjdGl2ZS1mb3JtLWJpbmRpbmctMiAoKQogICJUZXN0IHRoYXQgaW50ZXJhY3RpdmUgZm9y bSBldmFsdWF0aW9uIHVzZXMgbGV4aWNhbCBiaW5kaW5nLiIKICA7OyBPdXRlciBsZXhpY2FsIGVu dmlyb25tZW50IGlzIG5vdCBwcmVzZXJ2ZWQgaW5zaWRlIGludGVyYWN0aXZlCiAgOzsgZm9ybXMs IHNvIHRoaXMgdGVzdCBmYWlscy4KICA6ZXhwZWN0ZWQtcmVzdWx0IDpmYWlsZWQKICAobGV0ICgo ZnVuCiAgICAgICAgIChsZXQgKChjYWxsaW50LXRlc3RzLXggNDIpKQogICAgICAgICAgIChsYW1i ZGEgKGEgYikKICAgICAgICAgICAgIChpbnRlcmFjdGl2ZSAobGlzdCAoYm91bmQtYW5kLXRydWUt cCBjYWxsaW50LXRlc3RzLXgpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2FsbGlu dC10ZXN0cy14KSkKICAgICAgICAgICAgIChsaXN0IGEgYiBjYWxsaW50LXRlc3RzLXgpKSkpKQog ICAgKGVydC1pbmZvICgiaW50ZXJwIikKICAgICAgKHNob3VsZCAoZXF1YWwgKGNhbGwtaW50ZXJh Y3RpdmVseSBmdW4pCiAgICAgICAgICAgICAgICAgICAgICcobmlsIDQyIDQyKSkpKQogICAgKGVy dC1pbmZvICgiY29tcGlsZWQiKQogICAgICAoc2hvdWxkIChlcXVhbCAoY2FsbC1pbnRlcmFjdGl2 ZWx5IChieXRlLWNvbXBpbGUgZnVuKSkKICAgICAgICAgICAgICAgICAgICAnKG5pbCA0MiA0Mikp KSkpKQoKOzs7IGNhbGxpbnQtdGVzdHMuZWwgZW5kcyBoZXJlCg== --f403045e9af637b8c105624eb8e2--