From: Noam Postavsky <npostavs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 7a0170d 2/2: Don't put whitespace between open paren and comment in Lisp modes (Bug#19740)
Date: Thu, 6 Jul 2017 09:00:00 -0400 [thread overview]
Message-ID: <CAM-tV-8-8kXG-0ut20Bx+8MwqNoA5DgTrqvQ9nVUW5XpRvJSnQ@mail.gmail.com> (raw)
In-Reply-To: <jwvvan6urnl.fsf-monnier+emacsdiffs@gnu.org>
On Thu, Jul 6, 2017 at 12:17 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> +(defun lisp-comment-indent ()
>> + "Like `comment-indent-default', but don't put space after open paren."
>> + (let ((pt (point)))
>> + (skip-syntax-backward " ")
>> + (if (eq (preceding-char) ?\()
>> + (cons (current-column) (current-column))
>
> This gives:
>
> (let (;sf
> (x 3))
> 4)
>
> whereas I'd expect to use comment-column here.
> IOW we should check that this is a double-semi-colon comment before
> applying the new rule.
Oops, good point. Fixed.
[1: 386918f0b8]: 2017-07-06 08:59:32 -0400
Fix lisp-comment-indent for single-semicolon case
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=386918f0b807116051facbe51a2bee342de37841
prev parent reply other threads:[~2017-07-06 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170706025511.4777.72770@vcs0.savannah.gnu.org>
[not found] ` <20170706025513.40F1C22DC4@vcs0.savannah.gnu.org>
2017-07-06 4:17 ` [Emacs-diffs] master 7a0170d 2/2: Don't put whitespace between open paren and comment in Lisp modes (Bug#19740) Stefan Monnier
2017-07-06 13:00 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-8-8kXG-0ut20Bx+8MwqNoA5DgTrqvQ9nVUW5XpRvJSnQ@mail.gmail.com \
--to=npostavs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.