From: Noam Postavsky <npostavs@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Tom Tromey <tom@tromey.com>, Pip Cet <pipcet@gmail.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: Merging bignum to master
Date: Mon, 13 Aug 2018 21:12:01 -0400 [thread overview]
Message-ID: <CAM-tV--xgAbYd7nrq2ezk63azTO_nk8xy94zVt5Y-gZrKLDzXw@mail.gmail.com> (raw)
In-Reply-To: <611579fd-52f2-0104-ef82-a7a4a3929700@cs.ucla.edu>
On 13 August 2018 at 18:58, Paul Eggert <eggert@cs.ucla.edu> wrote:
> meantime I installed the attached first patch to fix a glitch I saw in this
> area while looking at the current XFIXNUMPTR uses.
> --- a/src/lisp.h
> +++ b/src/lisp.h
> @@ -1189,9 +1189,15 @@ XFIXNUMPTR (Lisp_Object a)
> }
>
> INLINE Lisp_Object
> +make_pointer_integer_unsafe (void *p)
> +{
> + return TAG_PTR (Lisp_Int0, p);
> +}
> +
> +INLINE Lisp_Object
> make_pointer_integer (void *p)
> {
> - Lisp_Object a = TAG_PTR (Lisp_Int0, p);
> + Lisp_Object a = make_pointer_integer_unsafe (p);
I use ./configure --enable-check-lisp-object-type, and this gives me
CC dispnew.o
In file included from dispnew.c:27:0:
lisp.h: In function ‘make_pointer_integer_unsafe’:
lisp.h:568:28: error: expected expression before ‘{’ token
# define LISP_INITIALLY(w) {w}
^
lisp.h:790:3: note: in expansion of macro ‘LISP_INITIALLY’
LISP_INITIALLY ((Lisp_Word) ((untagged_ptr) (ptr) + LISP_WORD_TAG (tag)))
^~~~~~~~~~~~~~
lisp.h:1194:10: note: in expansion of macro ‘TAG_PTR’
return TAG_PTR (Lisp_Int0, p);
^~~~~~~
next prev parent reply other threads:[~2018-08-14 1:12 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 19:47 Merging bignum to master Tom Tromey
2018-08-11 21:28 ` Basil L. Contovounesios
2018-08-12 16:34 ` Tom Tromey
2018-08-13 12:21 ` Basil L. Contovounesios
2018-08-14 0:21 ` Andy Moreton
2018-08-15 23:41 ` Andy Moreton
2018-08-16 15:38 ` Basil L. Contovounesios
2018-08-19 8:26 ` Paul Eggert
2018-08-17 14:58 ` Eli Zaretskii
2018-08-12 6:29 ` Ulrich Mueller
2018-08-12 8:09 ` Paul Eggert
2018-08-12 17:21 ` Ulrich Mueller
2018-08-12 18:20 ` Eli Zaretskii
2018-08-12 19:30 ` Ulrich Mueller
2018-08-13 0:15 ` Paul Eggert
2018-08-12 18:05 ` Eli Zaretskii
2018-08-12 23:53 ` Paul Eggert
2018-08-13 0:20 ` Tom Tromey
2018-08-13 7:51 ` Andreas Schwab
2018-08-13 8:06 ` Ulrich Mueller
2018-08-13 9:14 ` Paul Eggert
2018-08-14 23:09 ` Paul Eggert
2018-08-16 2:46 ` Richard Stallman
2018-08-13 23:31 ` Richard Stallman
2018-08-14 1:41 ` Paul Eggert
2018-08-16 2:41 ` Richard Stallman
2018-08-16 19:31 ` Paul Eggert
2018-08-16 22:02 ` Stefan Monnier
2018-08-12 7:37 ` John Wiegley
2018-08-12 18:21 ` Eli Zaretskii
2018-08-12 11:48 ` Pip Cet
2018-08-12 16:02 ` Tom Tromey
2018-08-13 22:58 ` Paul Eggert
2018-08-14 1:12 ` Noam Postavsky [this message]
2018-08-14 13:04 ` Pip Cet
2018-08-14 18:01 ` Paul Eggert
2018-08-15 15:20 ` Pip Cet
2018-08-15 16:17 ` Paul Eggert
2018-08-15 23:57 ` Andy Moreton
2018-08-16 22:00 ` Stefan Monnier
2018-08-20 16:28 ` Some vars now limited to fixnum size. (Was: Merging bignum to master) Karl Fogel
2018-08-20 16:54 ` Paul Eggert
2018-08-20 17:27 ` Eli Zaretskii
2018-08-20 17:27 ` Paul Eggert
2018-08-20 18:00 ` Eli Zaretskii
2018-08-20 19:55 ` Pip Cet
2018-08-20 23:15 ` Paul Eggert
2018-08-21 15:01 ` Some vars now limited to fixnum size Tom Tromey
2018-08-21 16:36 ` Andy Moreton
2018-08-21 18:46 ` Paul Eggert
2018-08-22 15:39 ` Tom Tromey
2018-08-21 3:38 ` Some vars now limited to fixnum size. (Was: Merging bignum to master) Richard Stallman
2018-08-21 4:09 ` Paul Eggert
2018-08-22 4:03 ` Richard Stallman
2018-08-22 4:53 ` Paul Eggert
2018-08-20 17:25 ` Eli Zaretskii
2018-08-14 0:51 ` Merging bignum to master Andy Moreton
2018-08-15 15:46 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV--xgAbYd7nrq2ezk63azTO_nk8xy94zVt5Y-gZrKLDzXw@mail.gmail.com \
--to=npostavs@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=pipcet@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.