From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Glenn Morris <rgm@gnu.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 491531b: Avoid ert test failures
Date: Sat, 22 Apr 2017 23:23:08 -0400 [thread overview]
Message-ID: <CAM-tV--wq25+8fX9WxaEOpPrKy5Ag6Bs3mUVNb71Qr__3QXOAw@mail.gmail.com> (raw)
In-Reply-To: <mbvaq0t9ns.fsf@fencepost.gnu.org>
>> Anyway, I was considering fixing this by using (bound-and-true-p
>> byte-compile-macro-environment) instead of loading `bytecomp', which
>> almost seems to work except that eval-tests--bugs-24912-and-24913
>> fails because `should-error' fails to catch the error from
>> byte-compile.
Actually the issue there was just a missing defvar for
`byte-compile-debug'. There should have been a compile warning about
an unused local variable except that loading the compiler defines this
variable. Fixed in [1: b20d05c6d7].
[1: b20d05c6d7]: 2017-04-22 23:17:59 -0400
Don't require bytecomp for running ert tests
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b20d05c6d76ddaf7e70da1430c9aac56ef1d6b31
prev parent reply other threads:[~2017-04-23 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 2:35 master 491531b: Avoid ert test failures Noam Postavsky
2017-04-19 20:38 ` Glenn Morris
2017-04-23 3:23 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV--wq25+8fX9WxaEOpPrKy5Ag6Bs3mUVNb71Qr__3QXOAw@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.