From: Noam Postavsky <npostavs@users.sourceforge.net>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert
Date: Mon, 30 Jan 2017 21:53:11 -0500 [thread overview]
Message-ID: <CAM-tV--mHGyX=S4A=VTZim8pFrtKO=_2T37s0315sfc-3n9ypQ@mail.gmail.com> (raw)
In-Reply-To: <ac130f0b-9d0e-6983-3bfe-f8ee961c8f2c@gmail.com>
On Sun, Jan 29, 2017 at 4:09 PM, Clément Pit-Claudel
<cpitclaudel@gmail.com> wrote:
>> Um, should this be
>>
>> (funcall debugger 'error `(cl-assertion-failed ,form ,string ,@sargs))
>>
>> or
>>
>> (funcall debugger 'error `(cl-assertion-failed (,form ,string ,@sargs)))
>>
>> I'm getting confused with all the levels of nesting and funcall/apply.
>
>
> I think the second one. `debugger' gets two arguments, 'error and a list of arguments to `signal'. That list should have two entries: `cl-assertion-failed' and `(,form ,string ,@sargs).
>
Pushed to emacs-25 [1: 72ef710].
1: 2017-01-30 21:45:02 -0500 72ef710f6e1c8e334fd50da9480a8cb151e823a2
Fix call to debugger on assertion failure
next prev parent reply other threads:[~2017-01-31 2:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161105015720.6371.89806@vcs.savannah.gnu.org>
[not found] ` <20161105015720.88A6322012D@vcs.savannah.gnu.org>
2016-11-05 17:22 ` [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Stefan Monnier
2016-11-06 18:28 ` Noam Postavsky
2016-11-06 22:47 ` Stefan Monnier
2016-11-08 1:12 ` Noam Postavsky
2016-11-08 13:17 ` Stefan Monnier
2016-11-08 14:32 ` Stefan Monnier
2016-11-09 0:55 ` Noam Postavsky
2017-01-28 1:16 ` Clément Pit--Claudel
2017-01-28 1:59 ` Noam Postavsky
2017-01-28 3:30 ` Clément Pit--Claudel
2017-01-28 3:46 ` Noam Postavsky
2017-01-29 15:37 ` Noam Postavsky
2017-01-29 21:09 ` Clément Pit-Claudel
2017-01-31 2:53 ` Noam Postavsky [this message]
2016-11-06 19:03 ` Philipp Stephani
2017-01-28 1:13 ` Clément Pit-Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV--mHGyX=S4A=VTZim8pFrtKO=_2T37s0315sfc-3n9ypQ@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.