From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: with-temp-buffer: should we set buffer-undo-list to t? Date: Sun, 12 Mar 2017 09:38:16 -0400 Message-ID: References: <22724.36280.852934.614634@gargle.gargle.HOWL> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1489325932 25644 195.159.176.226 (12 Mar 2017 13:38:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 12 Mar 2017 13:38:52 +0000 (UTC) Cc: Emacs developers To: raman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 12 14:38:47 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cn3ht-00066Z-Kp for ged-emacs-devel@m.gmane.org; Sun, 12 Mar 2017 14:38:45 +0100 Original-Received: from localhost ([::1]:47116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn3hz-0003LM-Fc for ged-emacs-devel@m.gmane.org; Sun, 12 Mar 2017 09:38:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cn3hS-0003LH-57 for emacs-devel@gnu.org; Sun, 12 Mar 2017 09:38:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cn3hR-0001rs-Aj for emacs-devel@gnu.org; Sun, 12 Mar 2017 09:38:18 -0400 Original-Received: from mail-ot0-x232.google.com ([2607:f8b0:4003:c0f::232]:34188) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cn3hR-0001rP-5E for emacs-devel@gnu.org; Sun, 12 Mar 2017 09:38:17 -0400 Original-Received: by mail-ot0-x232.google.com with SMTP id o24so99582845otb.1 for ; Sun, 12 Mar 2017 06:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Bql/wrX3AteBwYDcGqRQYPKjGKdInyhmdcZONogCrRg=; b=KOwrwyKUJyi3XCjjCl0S0+H4FoZMitonsBC/rqnufi2oLrmeCywODdq04SWjdGqruz AcLv++M1Lp4z0VhXDFIep39OkQrvA1lBB5GPf4x3Uqq8Gmw6DZ+i18An89HDUdtZ+QVn pH9fme/rsj6vfHE+wbrSfFerZWgyodh7Fw3ITOBpjKDfL9hDr3npZRecFbVmadVrHiHn cYddGNfb3hcKcTk17PxThC13ip/HbYNZnUBEd5s0iCMZxvq+Ws5w2I2czvZqvRVYfzmN bzK0iKeRXH+IPYTh+WcxXQCi00t/ohT1BrvC/mlhWJQXCXzJNfiDTaHWNgtWgt3yYkhU 3ahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Bql/wrX3AteBwYDcGqRQYPKjGKdInyhmdcZONogCrRg=; b=m9rmjvtP92tqRyP9kqnfSlDqLhuBwE57doZw+VpuIgur1OcQvFhuBnX7iZsylj4bic f7jrqRmCmubO+GMGagZPjT1SdqSjonbhvRXMB8DFm6foWrE5dFlXYokm8PxVRpruosqT 6f7NO9SB/2/hwCVvAowBF8Bs7+pSRarsvBfvcC90Y2LIJyjM8LnO35qaQxk99O7V6zAb VBfw2C1dR3wUhlLpvAZf1xS2l/nD/29+eoKptwUKb+f3Fpy86kydIBDeuEAkm/68TZiz IjFH2hardauLCwNkcY18dOufLkIFlFD6+kcSFtxGOILRlT45hXRt+FHDZhXGqB2KM1fN OUKg== X-Gm-Message-State: AFeK/H2h9++skH3ma+nhmhuORSUpNYKPwUFzv+nCqwZCrILWHZuyZ7msfwiUMIqPwhUwq+j98YRy9pXNgc3HtQ== X-Received: by 10.157.68.163 with SMTP id v35mr13637742ote.55.1489325896401; Sun, 12 Mar 2017 06:38:16 -0700 (PDT) Original-Received: by 10.157.80.172 with HTTP; Sun, 12 Mar 2017 06:38:16 -0700 (PDT) In-Reply-To: <22724.36280.852934.614634@gargle.gargle.HOWL> X-Google-Sender-Auth: vEfQ07b-pgApGj2yZsm_eE3JPgw X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212941 Archived-At: On Sat, Mar 11, 2017 at 6:52 PM, wrote: > Would setting buffer-undo-list to t in the macro definition of > with-temp-buffer help save some work? > > At present we dont do this, and as a consequence, operations within > body of with-tem-buffer may well push entries on the undo stack that > just get thrown away. Seems it already happens: (with-temp-buffer buffer-undo-list) ;=> t get-buffer-create has this code: bset_undo_list (b, SREF (name, 0) != ' ' ? Qnil : Qt); So buffers starting with a space have the undo list set to t.