From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: 1) (elisp) `Advising Named Functions', 2) search filtering example
Date: Mon, 17 Oct 2016 08:20:31 -0400 [thread overview]
Message-ID: <CAM-tV--cV0HvqLpSLYXMuzfvD+6wnpn4Eq4it28Q=s6LfN-aNw@mail.gmail.com> (raw)
In-Reply-To: <5a44a850-e4fc-4c9f-a266-c74766810ba1@default>
On Mon, Oct 17, 2016 at 1:25 AM, Drew Adams <drew.adams@oracle.com> wrote:
> 1. Node `Advising Named Functions' of the Elisp manual says this:
>
> For these reasons, advice should be reserved for the cases
> where you cannot modify a function’s behavior in any other way.
> If it is possible to do the same thing via a hook, that is
> preferable. ...
>
> In particular, Emacs’s own source files should not put advice
> on functions in Emacs. (There are currently a few exceptions
> to this convention, but we aim to correct them.)
>
> Is that still true? Is this the policy, even with the new
> advice system?
>
> If so, then it seems that it is being ignored, as new advice
> has been added to `isearch-filter-predicate' in `dired-aux.el'
> and `wdired.el'.
`advice-add' puts advice on a function, `add-function' does not.
`isearch-filter-predicate' is not a function, it's a variable
containing a function value.
next prev parent reply other threads:[~2016-10-17 12:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 5:25 1) (elisp) `Advising Named Functions', 2) search filtering example Drew Adams
2016-10-17 12:20 ` Noam Postavsky [this message]
2016-10-17 14:02 ` Drew Adams
2016-10-17 14:37 ` Noam Postavsky
2016-10-17 14:52 ` Stefan Monnier
2016-10-17 15:40 ` Drew Adams
2016-10-17 15:51 ` Stefan Monnier
2016-10-17 17:05 ` Drew Adams
2016-10-17 17:47 ` Stefan Monnier
2016-10-17 15:40 ` Drew Adams
2016-10-17 16:16 ` Noam Postavsky
2016-10-17 17:05 ` Drew Adams
2016-10-17 17:53 ` Stefan Monnier
2016-10-17 18:41 ` Drew Adams
2016-10-17 19:25 ` Stefan Monnier
2016-10-18 19:47 ` Richard Stallman
2016-10-19 6:15 ` Eli Zaretskii
2016-10-19 20:00 ` Richard Stallman
2016-10-19 20:18 ` Stefan Monnier
2016-10-20 7:17 ` Eli Zaretskii
2016-10-20 7:06 ` Eli Zaretskii
2016-10-20 18:06 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV--cV0HvqLpSLYXMuzfvD+6wnpn4Eq4it28Q=s6LfN-aNw@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.