From: Noam Postavsky <npostavs@users.sourceforge.net>
To: 23126@debbugs.gnu.org
Cc: david lopez villegas <davidlvillegas@gmail.com>
Subject: bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25
Date: Sat, 4 Jun 2016 13:47:21 -0400 [thread overview]
Message-ID: <CAM-tV--V52xwVYQLMPZO=5obk7g-VCUTBbO9_LPNyTMFDB=kZg@mail.gmail.com> (raw)
In-Reply-To: <CAPfyOjfftRPmcXjTwgST8su5CBjyXk_VLAdamD5q1UFYk7+i2w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
tag 23126 + patch
quit
I guess the point of having python.el in ELPA is to support older
emacs, so we should avoid calling format-message rather than require
Emacs 25? Patch attached.
[-- Attachment #2: 0001-Make-python.el-work-in-Emacs-24.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]
From c7b8c9832a71a28052b1388bf9664c4e00fcb586 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sat, 4 Jun 2016 13:32:50 -0400
Subject: [PATCH] Make python.el work in Emacs 24
* lisp/progmodes/python.el (python-define-auxiliary-skeleton): Only use
format-message if fbound (Bug#23126).
---
lisp/progmodes/python.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index 343023f..d12d98a 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -4045,8 +4045,8 @@ python-define-auxiliary-skeleton
(declare (indent 2))
(let* ((name (symbol-name name))
(function-name (intern (concat "python-skeleton--" name)))
- (msg (format-message
- "Add `%s' clause? " name)))
+ (msg (funcall (if (fboundp 'format-message) 'format-message format)
+ "Add `%s' clause? " name)))
(when (not skel)
(setq skel
`(< ,(format "%s:" name) \n \n
--
2.8.0
next prev parent reply other threads:[~2016-06-04 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 12:37 bug#23126: 24.3; format-message, phyton.el in GNU ELPA doesn't specify that it is required Emacs 25 david lopez villegas
2016-06-04 17:47 ` Noam Postavsky [this message]
2016-06-14 5:37 ` Glenn Morris
2016-06-14 5:40 ` Glenn Morris
2016-06-14 12:19 ` Noam Postavsky
2016-06-14 22:48 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV--V52xwVYQLMPZO=5obk7g-VCUTBbO9_LPNyTMFDB=kZg@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=23126@debbugs.gnu.org \
--cc=davidlvillegas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.