From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Juliusz Chroboczek <jch@irif.fr>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: semantics of thread-signal
Date: Sun, 11 Dec 2016 21:06:38 -0500 [thread overview]
Message-ID: <CAM-tV--TwYcv3GRH3HgV0Xzk7va3cO8bqQBrbxiJgmT4H09KnQ@mail.gmail.com> (raw)
In-Reply-To: <871sxe2b8d.fsf@irif.fr>
On Sun, Dec 11, 2016 at 8:21 PM, Juliusz Chroboczek <jch@irif.fr> wrote:
>>> I assumed this to mean that the condition will only be delivered when
>>> one of these functions is called, but your comment seems to imply that
>>> it's meant to deliver the condition as soon as possible.
>
>> My interpretation is that mutex-lock (and the others) block the thread
>> until something happens (e.g., another thread calls mutex-unlock), and
>> thread-signal is another thing which can end the blocking (and also
>> trigger a signal when the thread next runs).
>
> Reasonable enough. Perhaps somebody could clarify the docs?
>
Something like this?
--- i/doc/lispref/threads.texi
+++ w/doc/lispref/threads.texi
@@ -82,9 +82,11 @@ Basic Thread Functions
@defun thread-signal thread error-symbol data
Like @code{signal} (@pxref{Signaling Errors}), but the signal is
delivered in the thread @var{thread}. If @var{thread} is the current
-thread, then this just calls @code{signal} immediately.
-@code{thread-signal} will cause a thread to exit a call to
-@code{mutex-lock}, @code{condition-wait}, or @code{thread-join}.
+thread, then this just calls @code{signal} immediately. Otherwise,
+@var{thread} will receive the signal as soon as it becomes current.
+If @var{thread} was blocked by a call to @code{mutex-lock},
+@code{condition-wait}, or @code{thread-join}; @code{thread-signa} will
+unblock it.
@end defun
>
> The manual says:
>
> However, the Emacs thread support has been designed in a way to
> later allow more fine-grained concurrency, and correct programs
> should not rely on cooperative threading.
>
> So if thread-signal can be delivered asynchronously, this will cause
> trouble when Emacs moves to kernel threads.
Hmm, if we really want to be safe for preemptive threads, we would
probably need to add some way to block asynch signals, and
unwind-protect would use that during the unwind forms. It would also
be needed between calling make-foo and setting the value of foo.
next prev parent reply other threads:[~2016-12-12 2:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 0:16 semantics of thread-signal (WAS: Crashing the new thread code) Noam Postavsky
2016-12-12 1:21 ` semantics of thread-signal Juliusz Chroboczek
2016-12-12 2:06 ` Noam Postavsky [this message]
2016-12-12 16:08 ` Eli Zaretskii
2016-12-13 2:46 ` Noam Postavsky
2016-12-12 3:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV--TwYcv3GRH3HgV0Xzk7va3cO8bqQBrbxiJgmT4H09KnQ@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=emacs-devel@gnu.org \
--cc=jch@irif.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.