From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#5950: defvaralias after defvar should be warned in runtime Date: Fri, 3 Aug 2018 16:23:22 -0400 Message-ID: References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1533327731 5657 195.159.176.226 (3 Aug 2018 20:22:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Aug 2018 20:22:11 +0000 (UTC) Cc: IRIE Shinsuke , 5950@debbugs.gnu.org, Stefan Monnier To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 03 22:22:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flgaM-0001MW-1n for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Aug 2018 22:22:06 +0200 Original-Received: from localhost ([::1]:52958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flgcS-0000Br-EH for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Aug 2018 16:24:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flgcI-0000Bk-5S for bug-gnu-emacs@gnu.org; Fri, 03 Aug 2018 16:24:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flgcF-0000fT-1C for bug-gnu-emacs@gnu.org; Fri, 03 Aug 2018 16:24:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35208) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flgcE-0000fO-Qk for bug-gnu-emacs@gnu.org; Fri, 03 Aug 2018 16:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1flgcE-0003Lo-Is for bug-gnu-emacs@gnu.org; Fri, 03 Aug 2018 16:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Aug 2018 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 5950-submit@debbugs.gnu.org id=B5950.153332781112754 (code B ref 5950); Fri, 03 Aug 2018 20:24:02 +0000 Original-Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 20:23:31 +0000 Original-Received: from localhost ([127.0.0.1]:40226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flgbi-0003Jc-UL for submit@debbugs.gnu.org; Fri, 03 Aug 2018 16:23:31 -0400 Original-Received: from mail-oi0-f43.google.com ([209.85.218.43]:36618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flgbh-0003J8-1l for 5950@debbugs.gnu.org; Fri, 03 Aug 2018 16:23:29 -0400 Original-Received: by mail-oi0-f43.google.com with SMTP id n21-v6so12059544oig.3 for <5950@debbugs.gnu.org>; Fri, 03 Aug 2018 13:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ieCS/OnKl1oMDfAT/gglWKx8+ZBkLJoEHRXh5Wd109k=; b=stoVDpIFH1K5aCn06Dz+UZJh7C8njxRZeIQ0wAPQ6NtQdcFFkU3tNEx8Jh+bSqcF+l l6sGOMQOwE6amyGFJFED3ukaDccWAKswhpkAbxuri0ek8XJuxKducqd6YtU1s3//Pj9x aU4DMB8i1D8DRwcLE00nHnIx2jJuFO4ttZR664gkuOru9Vq5W8b1DzpOmjusnWLk1TrY pBzCVVMVm6ZtwO8b72fPLu0gybBw2K0gH8jUd+IAgPorOrIsVPc2K1i0ntkSgpke5laQ +IpziLfn2H4oR4XBliLjvILvROxg20/CN34x0uZ5FyDyGQ8HWx02rUlU5ZDQ0uoc+A/x 2KwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ieCS/OnKl1oMDfAT/gglWKx8+ZBkLJoEHRXh5Wd109k=; b=kPK0/99KrbXGeMMZif7kGQb3wlQNJb6HRw9564D5+zotrNlLeyfbowd4l0ZVI2f+EL eEZAamo6dNsxO0Kc6UkAp3kpdkW7xdFY62ma6JfDhpbYFJ/fN2KeWnymYwKe2YF/HxX/ WaB91bmbTbSdLl27AXl+X4ga9+QbXWR39bIlSvJPhERwTWbYAoRavynRLl7dq+OMem5+ 6qsMAM7ZH4wr2to04C8tSW2w4P1X5EgrV26QRjmH2EanALOfQW1BMB3C079Xm/accwNv nFb8390E6LA0Hi3qVFccK2pySmVmQW/LlMT/bzDHJ1qvoGnrDP0YaHTDgMpNZ4wnDHLf H8Pw== X-Gm-Message-State: AOUpUlGeEOAnTbjSDkfqKqzhSlntw0AaK5XaTJaa3JE4CJWK3x90vCRT oafeVujScNRUu5wLEx87E/N3qrmAsriukjR+o4Q= X-Google-Smtp-Source: AAOMgpdfWs6BIoFdnhL0tRPSXSMUnIh1DEBwniLypSRvyvVzTW6f29LtXZX6jJhuS3/R6JsrJ1F0HQk+W9BhGttvDg4= X-Received: by 2002:aca:100f:: with SMTP id 15-v6mr4992784oiq.110.1533327803417; Fri, 03 Aug 2018 13:23:23 -0700 (PDT) Original-Received: by 2002:a9d:3495:0:0:0:0:0 with HTTP; Fri, 3 Aug 2018 13:23:22 -0700 (PDT) In-Reply-To: <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149246 Archived-At: On 2 August 2018 at 23:33, Cl=C3=A9ment Pit-Claudel = wrote: > On 2018-08-02 13:03, Stefan Monnier wrote: >>>> The typical failure case goes like this, user does this: >>>> >>>> (setq the-package-setting 'foo) >>>> (require 'the-package) >>>> >>>> And the-package.el does this: >>>> >>>> (defvar the-package-real-setting 'bar) >>>> ;; Oops! User's setting of `foo' is overwritten here: >>>> (defvaralias 'the-package-setting 'the-package-real-setting) >>> >>> Thanks. Should the warning be disabled when both variables are >>> already `defvar'd, then? >> >> Why? Replace `setq` with `defvar` in the above scenario and you have >> the same problem. > > Do you? I thought the problem was that you were overwriting a user settin= g=E2=80=A6 if you change the first setq into a defvar, where's the user set= ting that you're overwriting? If the user writes defvar instead of setq, it has the exact same effect: they've set the-package-setting to foo, which will be overwritten to bar, same as before.