From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Date: Thu, 21 Jul 2016 17:27:49 -0400 Message-ID: References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> <87a8hbdcfd.fsf@users.sourceforge.net> <83d1m7yssc.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1469136515 2590 80.91.229.3 (21 Jul 2016 21:28:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 21:28:35 +0000 (UTC) Cc: Michael Heerdegen , 23648@debbugs.gnu.org, Paul Pogonyshev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 21 23:28:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQLW4-0000Ad-Ml for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 23:28:24 +0200 Original-Received: from localhost ([::1]:43794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQLW3-0005N1-Su for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 17:28:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQLVm-000576-GX for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 17:28:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQLVi-0008NL-9f for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 17:28:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQLVi-0008NH-5X for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 17:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQLVh-0001eO-U7 for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 17:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jul 2016 21:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.14691364776333 (code B ref 23648); Thu, 21 Jul 2016 21:28:01 +0000 Original-Received: (at 23648) by debbugs.gnu.org; 21 Jul 2016 21:27:57 +0000 Original-Received: from localhost ([127.0.0.1]:60652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQLVd-0001e4-8K for submit@debbugs.gnu.org; Thu, 21 Jul 2016 17:27:57 -0400 Original-Received: from mail-oi0-f52.google.com ([209.85.218.52]:35509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQLVb-0001dr-Dx for 23648@debbugs.gnu.org; Thu, 21 Jul 2016 17:27:55 -0400 Original-Received: by mail-oi0-f52.google.com with SMTP id l72so136881781oig.2 for <23648@debbugs.gnu.org>; Thu, 21 Jul 2016 14:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=UMIyvJSfdyrJvdn/Q98hoSQo0piEZReNNjk/7CPFZQE=; b=wJX0n5sskFdZuToSD3x/7qtWSOGOaxP3zgYPWYCcG7Va+Udb0OLMrxvm18h3zWuUmZ CbDZ6jY1VnNIm+XgKAMXk1Kfi+MLAL/8lw10da2JtV4+vFXztKWz8RbNNF+Rf9I+O5bl vscybbNItJIMfWy6dmKB0g1kMHUFZXedt5vm3Ozm/AwzOpsGdcXWX8PWplo6idzXvWrx kDD0lkagn0ooAohufSs51QIo7uYpAJhxOsZhuZ1e5/EpSa/eMHJ+aBKt9YSAGfpgQOL1 QsiuRkC5G1U21rOdAliVFMcBlWQXazPNH8vU4m2FPnldoFca0avfwYsw6fCPcaLpUMLV wZgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=UMIyvJSfdyrJvdn/Q98hoSQo0piEZReNNjk/7CPFZQE=; b=W4ENFNcyY8J3+IodyRqvRVpGb8RKI6Zo/s5tAz9ZmiRbWqqvEYwy4tf+9hfI32UNRO wGaVFBiQHn/7ZlHdzk+TDySK6jU+1NKqzb6GWBSRx7B8ZTdchW5bwXM5jr6Nnqgtrc6d S8OCHDxVx2KGgFWdSxSxNTKoeyVCF1cWnufp1HcTjo21g2LCl5NTeamo55B7JRD0CRWf q7hbbS2fUZA+KlF5gjEQv1EiWA/wKh+zmoHOr/VWRFK3NLWGf8YIBWh6d7sFzOHDek3f /JxSf37Qowh4yt3L+VlFNA3vC7P3Kqp95r2Mte0856Ph1VHU14dqPVy/adHPut4XNjxI QXEw== X-Gm-Message-State: AEkoout7kpVex770Av3pdt6N4Z7DibtAXXEF2bQIPk3lVhlGMMa3OEJpzeFk9hspSHt/xOcSo2+wYhoReRx6Pg== X-Received: by 10.202.245.214 with SMTP id t205mr217959oih.202.1469136469672; Thu, 21 Jul 2016 14:27:49 -0700 (PDT) Original-Received: by 10.157.7.161 with HTTP; Thu, 21 Jul 2016 14:27:49 -0700 (PDT) In-Reply-To: <83d1m7yssc.fsf@gnu.org> X-Google-Sender-Auth: Etm8zZskMPUnvHXqmXxa4LSn_Cg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121396 Archived-At: On Thu, Jul 21, 2016 at 10:22 AM, Eli Zaretskii wrote: > Thanks, but I think we are mis-communicating. What I need is not a > demonstration of the bug in action; I already got that. What I asked > for is different: > >> How probable is the situation where this problem pops up? And when >> was the bug introduced? > > You already answered the second question. For the first, I expected > to see something done frequently by either users or Lisp programs, > which bumps into this bug. Evaluating macroexpand, twice, with > completion in-between, doesn't qualify in my book as a frequent user > action, I hope you will agree (even if you personally happen to use it > quite a lot). > > So I'm still looking for the answer to the "how probable" question. I > need that to make up my mind about the urgency of the fix. Ah, okay. The probability of a user hitting this depends on how likely they are to perform completion inside a declare form. This depends on the kind of code the user writes, so it's hard to put a number on it. Also, if the user has a package like company enabled that performs completion during idle time, then just moving point through a declare form should be enough to trigger it, so in this case it might depend also on the kind of code the user reads. If the user never opens an elisp file with declare forms, then they certainly won't hit this. Once the user has triggered the problem via completion, all compilation of defuns (e.g. during package installation/upgrade) with declare forms will be broken (as well as loading uncompiled defuns with declare forms). Admittedly only gv-expander (along with gv-setter, but that one doesn't get unlearned) is vital to correct compilation, the rest (advertised-calling-convention obsolete interactive-only pure side-effect-free compiler-macro doc-string indent) are only optimizations or advisory in nature.