From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: RE: master 491531b: Avoid ert test failures Date: Tue, 18 Apr 2017 22:35:56 -0400 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1492569400 20240 195.159.176.226 (19 Apr 2017 02:36:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Apr 2017 02:36:40 +0000 (UTC) To: Glenn Morris , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 19 04:36:35 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0fTr-00056v-MZ for ged-emacs-devel@m.gmane.org; Wed, 19 Apr 2017 04:36:31 +0200 Original-Received: from localhost ([::1]:45398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0fTx-0002Va-Jp for ged-emacs-devel@m.gmane.org; Tue, 18 Apr 2017 22:36:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0fTN-0002VV-Hm for emacs-devel@gnu.org; Tue, 18 Apr 2017 22:36:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0fTM-000486-JZ for emacs-devel@gnu.org; Tue, 18 Apr 2017 22:36:01 -0400 Original-Received: from mail-oi0-x22d.google.com ([2607:f8b0:4003:c06::22d]:33206) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d0fTK-000466-Pu; Tue, 18 Apr 2017 22:35:58 -0400 Original-Received: by mail-oi0-x22d.google.com with SMTP id b187so13018989oif.0; Tue, 18 Apr 2017 19:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=Jvjsq0N+Ofw3hvjL6x/tIpyBNCdy31imx5GNf1H+e1c=; b=Wo9j2zox/ShtSCmHNUKjMtNIGJUNmaEVoyW+624ZiYMV+zGrTlP/HW8sYoJplV9daw 6fHixU9NLzz2rS0JVm+AUvMZpO4rXqgvK3jjAAFBrUG8B9el/XU06BlswSz88Brpvjr1 VS3s1eSZLA3PIrQsagG10y7vS+qb7Qr07z3Y+z3iuqZKH07p62FszJ6+tTV4+2QRgwJe ozvqNULQFOWTheHwwXgpvNi+m4DijmJbduQztZagiPmUM63a6B+untTkeccy646Wn1kQ JVzbvy1WGUWUyKaWsL7AKv+f+fPXhC+MywVpdX/6xkcojJARbJwWvAJi7yGGKjEj2k9+ 7gMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=Jvjsq0N+Ofw3hvjL6x/tIpyBNCdy31imx5GNf1H+e1c=; b=MqKn7fB1u1ne6XwEOYr6XHl9O2Qhelsy+X7P6dh/wcopA5GIIggTJ42lU1ev6Pl68x 0RekQA9mB11sIA6P2wAhPRkRra2/QAQiQbFyoIqRsCbqv1216P9+nQAQT2EnRuHatHA0 MG9+1HAHCL+e5fCwbfrNfzIlA8W4oHV7lFWykQ98P39DOlkIFocK5np3zu2Z9Pb+wZGg UZf9hEnfiuJC+/G0MPCTRc4gIIkMy/EGfAxJwUW/HAGxELijpHQIj10MKqdzhOEM88ES /MhoR+5ZNckgxCuBbjQqCh7IQ1dWLJ2mdM02eyBIduDOsrBbeaK9sJRkS16xQ+NVLHVg emGQ== X-Gm-Message-State: AN3rC/6b6imiaXdknEQ78KfRsLkk+FM8M7gt2eatY+Zi1sZgk/skPACk FnbsbfL/skoG0B4SFdpupCSSgh5wcHL+ X-Received: by 10.202.89.139 with SMTP id n133mr251783oib.70.1492569357251; Tue, 18 Apr 2017 19:35:57 -0700 (PDT) Original-Received: by 10.157.9.178 with HTTP; Tue, 18 Apr 2017 19:35:56 -0700 (PDT) X-Google-Sender-Auth: 5K42Z8pVdzVDjE-_mS-ndsRby80 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214106 Archived-At: > Avoid ert test failures > > * lisp/emacs-lisp/ert.el (ert--expand-should-1): > Avoid errors related to undefined byte-compile-macro-environment. > Somehow masked until very recently because loading seq (eg) > loads bytecomp. http://hydra.nixos.org/build/51730765 > --- > (defun ert--expand-should-1 (whole form inner-expander) > "Helper function for the `should' macro and its variants." > + (require 'bytecomp) ; FIXME? > (let ((form > (macroexpand form (append byte-compile-macro-environment > (cond I introduced this dependency in [1: 58e418d2ce]. I did notice the error once locally, and then it didn't come up again; I'm not quite understanding how the masking works. Anyway, I was considering fixing this by using (bound-and-true-p byte-compile-macro-environment) instead of loading `bytecomp', which almost seems to work except that eval-tests--bugs-24912-and-24913 fails because `should-error' fails to catch the error from byte-compile. That can be fixed by adding (require 'bytecomp) in that test, but maybe it's better just to leave the require in ert? 1: 2016-12-06 22:20:23 -0500 58e418d2ceb82501f03d9c3316fd0a46faf7f0eb Fix ert-tests when running compiled