Re: [elpa] master 74aa97f: * packages/yasnippet: Fix some compilation warnings

Re: [elpa] master 74aa97f: * packages/yasnippet: Fix some compilation warnings

[Noam Postavsky]

On Wed, Jun 22, 2016 at 8:53 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> branch: master
> commit 74aa97f31a5bc11009ce5bfddfd9fcbde1bbc89b
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * packages/yasnippet: Fix some compilation warnings

The changes look good, but I wasn't getting any compilation warnings
before. Is there some settings that I should enable to get them?

> @@ -4523,7 +4522,7 @@ and return the directory.  Return nil if not found."
>                               yas-after-exit-snippet-hook
>                               yas-before-expand-snippet-hook
>                               yas-buffer-local-condition
> -                             yas-dont-activate
> +                             yas-dont-activate-functions

Not needed because these are just backwards compat aliases, there
aren't any yas/dont-activate-functions reference out there.

Re: [elpa] master 74aa97f: * packages/yasnippet: Fix some compilation warnings

[Stefan Monnier]

>> * packages/yasnippet: Fix some compilation warnings
> The changes look good, but I wasn't getting any compilation warnings
> before. Is there some settings that I should enable to get them?

I force lexical-binding mode everywhere.

You can get most of those warnings by setting
byte-compile-force-lexical-warnings to non-nil.

>> -                             yas-dont-activate
>> +                             yas-dont-activate-functions

> Not needed because these are just backwards compat aliases, there
> aren't any yas/dont-activate-functions reference out there.

AFAICT yas-dont-activate is the obsolete alias, which is why I thought
it's better to use yas-dont-activate-functions here, which is the
non-obsolete version of it.


        Stefan