all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: 10416@debbugs.gnu.org
Subject: bug#10416: 24.0.92; #'test-completion is inconsistent with symbol hash keys in COLLECTION
Date: Tue, 7 Jun 2016 23:42:20 -0400	[thread overview]
Message-ID: <CAM-tV--7JobFBaBgJ6Cf97XWCnjMoyF-XkL5mVB+2-Owo_Z7hw@mail.gmail.com> (raw)
In-Reply-To: <20224.27302.821804.284656@parhasard.net>

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

tag 10416 + patch
quit

In 24.5 the 3rd case is fixed, but the docs are still contradictory as
of 25.0.94. Here is a patch to make manual agree with code and
docstrings.

[-- Attachment #2: 0001-Fix-documentation-of-completion-functions.patch --]
[-- Type: text/x-diff, Size: 1208 bytes --]

From dc25b98bf90b68b78c8b3baf4dcc0bbc609bd2d2 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Tue, 7 Jun 2016 23:37:05 -0400
Subject: [PATCH] Fix documentation of completion functions

So that the behavior matches the match code (and docstrings).

* doc/lispref/minibuf.texi (Basic Completion): Symbol keys of hash table
are not ignored.
---
 doc/lispref/minibuf.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/lispref/minibuf.texi b/doc/lispref/minibuf.texi
index 6f41090..1fa2536 100644
--- a/doc/lispref/minibuf.texi
+++ b/doc/lispref/minibuf.texi
@@ -733,8 +733,8 @@ Basic Completion
 If @var{collection} is an obarray (@pxref{Creating Symbols}), the names
 of all symbols in the obarray form the set of permissible completions.
 
-If @var{collection} is a hash table, then the keys that are strings
-are the possible completions.  Other keys are ignored.
+If @var{collection} is a hash table, then the keys that are strings or
+symbols are the possible completions.  Other keys are ignored.
 
 You can also use a function as @var{collection}.  Then the function is
 solely responsible for performing completion; @code{try-completion}
-- 
2.8.0


  parent reply	other threads:[~2016-06-08  3:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-01 14:16 bug#10416: 24.0.92; #'test-completion is inconsistent with symbol hash keys in COLLECTION Aidan Kehoe
2012-01-01 22:59 ` Stefan Monnier
2012-01-02  0:11   ` Aidan Kehoe
2012-01-03 22:07     ` Stefan Monnier
2012-01-02  0:21   ` Aidan Kehoe
2016-06-08  3:42 ` Noam Postavsky [this message]
2016-06-18 16:32 ` Noam Postavsky
2016-06-18 17:20   ` Eli Zaretskii
2016-06-18 19:09     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV--7JobFBaBgJ6Cf97XWCnjMoyF-XkL5mVB+2-Owo_Z7hw@mail.gmail.com \
    --to=npostavs@users.sourceforge.net \
    --cc=10416@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.