From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Fix for org-mode fontification (Bug#25132) fix on emacs-25? Date: Tue, 21 Mar 2017 09:23:34 -0400 Message-ID: References: <83a88fwbld.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1490102632 19987 195.159.176.226 (21 Mar 2017 13:23:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 21 Mar 2017 13:23:52 +0000 (UTC) Cc: Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 21 14:23:46 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqJlF-0004CO-6s for ged-emacs-devel@m.gmane.org; Tue, 21 Mar 2017 14:23:41 +0100 Original-Received: from localhost ([::1]:40268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqJlK-0002yO-Vb for ged-emacs-devel@m.gmane.org; Tue, 21 Mar 2017 09:23:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqJlC-0002xX-CI for emacs-devel@gnu.org; Tue, 21 Mar 2017 09:23:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqJlB-00016K-GD for emacs-devel@gnu.org; Tue, 21 Mar 2017 09:23:38 -0400 Original-Received: from mail-ot0-x232.google.com ([2607:f8b0:4003:c0f::232]:34607) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqJl9-00015s-VA; Tue, 21 Mar 2017 09:23:36 -0400 Original-Received: by mail-ot0-x232.google.com with SMTP id o24so151075803otb.1; Tue, 21 Mar 2017 06:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=OmOtPCx1t5Lz5tkCeNrd8HgpxnAkQjby7L3sCDNJT9c=; b=nL73hUkjN7Xg/G+/josVbxGsZemcZLX+9ojw8Lib/tnrAX5bZFH1t9ULtZKM+odQXB SAm39w81fJxfb97rXwiWKa94cfxVsxE+/nDWpkOvXycmXR0y+uzwy6i50wn4TnVkaeqe F1Cmw3zbYg5Jp2YbQrNhLLgQzeEY/wY7yn7VTDeTFesIxHnhCHt3g9powAN2XgMSL51t vLWJpINWUEzt3dwB7BnQeyuKV3zeHARRnosZQyLewHM/0DVIU6kO/M7Xl4Za+bsqahY7 0u7RYSxwc5FHdooKgTnfwirnk/uzDeT0CJTtUsTQmGlEzwzJOH6C4++0Fu1M+7nmJfOA x4RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=OmOtPCx1t5Lz5tkCeNrd8HgpxnAkQjby7L3sCDNJT9c=; b=YA/us8YqLluDqt5Jm179BQNr7hWb+jAvA1gwlwtbSEPR8cecLySvf6k2mYA3uXajwX CBhwFacGSwrEBJ5TIzq0jr29THgORES4QSAPdBh0CJukBidXBYeC3Jh7sJmGOh2QEBYd N/1DJvUrZ8LNZqQOiLkcYMuM5zrMpJIyvGfpxDlwtoaAgm4NQNvrCS0kGItdYFvCTpPW LtiQT30jpu8UJI/UH5VBGhJx95tuslQVGTMW3O9Aeks1/p3AW+0OeEnE1QILOdFHl3jq mhDQ+3Nv/i8YTcd9ALjgHkE5Bu6lg8mF/+rp4RP5xzUzOfUBEZ3Ey+m00udVcT+bNLW8 ZWIQ== X-Gm-Message-State: AFeK/H0zNu7K3ohRSE0cWiW/oeDdx6UhZkhk521KJmOR4DxT8QdivHyOB5h4SoYEVQSMXjxd7ZKTiusPly+k0Q== X-Received: by 10.157.15.161 with SMTP id d30mr17745046otd.221.1490102615020; Tue, 21 Mar 2017 06:23:35 -0700 (PDT) Original-Received: by 10.157.80.172 with HTTP; Tue, 21 Mar 2017 06:23:34 -0700 (PDT) In-Reply-To: <83a88fwbld.fsf@gnu.org> X-Google-Sender-Auth: 1FCnKemnQhaR2-XNwqA7bZadTZQ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213199 Archived-At: On Mon, Mar 20, 2017 at 11:30 PM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Mon, 20 Mar 2017 22:11:45 -0400 >> >> I goofed when pushing the fix for Bug#25132, for some reason I decided >> to extend let-binding wider than my initial patch. This causes a >> fontification error when combined with some other (undetermined, but >> Spacemacs was mentioned) packages [1]. >> >> Fixed with the diff below (ignoring whitespace changes for >> readability) which narrows the scope of the let-binding (the >> let-binding was introduced for 25.2 to fix #25132). Should this go to >> emacs-25? > > Yes, emacs-25 is fine for this. Thanks. Done [1: d38fd9229c]. 1: 2017-03-21 09:19:57 -0400 d38fd9229c07c531ebc0bec0ea65f7d7dffcd983 Narrow scope of modification hook renabling in org-src fontification