From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame Date: Mon, 7 May 2018 14:08:19 -0400 Message-ID: References: <87sh747vsf.fsf@tcd.ie> <87efiona6i.fsf@gmail.com> <87muxcomoy.fsf@tcd.ie> <87bmdsn3z3.fsf@gmail.com> <5AEFF179.3090706@gmx.at> <83bmdrqrdd.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1525716437 29687 195.159.176.226 (7 May 2018 18:07:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 May 2018 18:07:17 +0000 (UTC) Cc: 31373@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 07 20:07:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFkXX-0007dW-QF for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 May 2018 20:07:11 +0200 Original-Received: from localhost ([::1]:47502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFkZe-0000RS-Pd for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 May 2018 14:09:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFkZO-0000LX-Bx for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 14:09:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFkZJ-00065e-Uw for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 14:09:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45199) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFkZJ-00065Z-RX for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 14:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fFkZJ-0006Hu-Ly for bug-gnu-emacs@gnu.org; Mon, 07 May 2018 14:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 May 2018 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31373-submit@debbugs.gnu.org id=B31373.152571650724114 (code B ref 31373); Mon, 07 May 2018 18:09:01 +0000 Original-Received: (at 31373) by debbugs.gnu.org; 7 May 2018 18:08:27 +0000 Original-Received: from localhost ([127.0.0.1]:53093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFkYk-0006Gs-Ia for submit@debbugs.gnu.org; Mon, 07 May 2018 14:08:26 -0400 Original-Received: from mail-ot0-f170.google.com ([74.125.82.170]:47008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFkYj-0006Gf-2R for 31373@debbugs.gnu.org; Mon, 07 May 2018 14:08:25 -0400 Original-Received: by mail-ot0-f170.google.com with SMTP id t1-v6so32996228ott.13 for <31373@debbugs.gnu.org>; Mon, 07 May 2018 11:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mvrI72FCINkFxTK6VRRySFHqxETCTsGvoFKK9OSNn2Y=; b=gjf2nfnurwhttuzZCN0iN5q4Sh0fptPmDi3xKcRlZQHlbJ0iQTDGCt2KpqCv6HPD0Q fLAfHR/JRbvNT7OmkoJ5n6bhZ94XB+byFsv5eTXHZd06t7voR3vNarLTMNG4LpsVkdxG WO7pvrivqXJQVmeOq6fOBjgYJVwzIs73TgjmzEIgPVyOgl1jvHIamlvwlyFrSnBTiij5 15R+YMN+ahbeH/QgDKs37J/InCZIbG38tZW3880vOxyg9UDTb8ZrO2clhzS6yizPphrO OCBqefxzFvFJ4SsuomGz9NWqHjN0M3CWGP8s0c91OfxRuEJlg6PWs39Zv6SsLAnWz7UW A/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mvrI72FCINkFxTK6VRRySFHqxETCTsGvoFKK9OSNn2Y=; b=H26nnqPwRUZ2Z+HoobTw2CRw9rzx+k/bBjUGRuOo3UrROWoE8FJq9FKDsPoAaOvl2I nZ10e6gT3Rk/MuLWRL1dk7lklVSYHrlLmHLRc7usk8g+J5dCD4uUGrwcOQpOpKCMS35S xacVas8FL0eymVe88hivot4021v+GTQfWHbOD8TKnvRbRWeXWA8s5VVExTg7/d4HLESe lzz16ChdNuPXLsIQPYyRBMGx7UHuDligD2l9aAkU1URyN3TwKTLxUpSk+TQnJI8KM7oY g5UOvIwhqKPSkzMVBQur0qUDDfjN3vyyrB6zRskzer7pf6RAD3rMC2aLcffDHOngmO0N 3W+A== X-Gm-Message-State: ALQs6tBkZVOvvpoXiebro0ftUy9m027dBCkP0kgisMxRwbh2AWl12y+X Tx4ihgemoZro0b9TskErlfinytYXBafF11N9NDg= X-Google-Smtp-Source: AB8JxZqF1yHv/aPbsyrSWoy0snSyL36SIoWXcZzjojGmqzUS5nmG4qRbGZXo4JVyKlpAlgbuxxCmPdVvL/G2UAbIOI0= X-Received: by 2002:a9d:501a:: with SMTP id a26-v6mr18111985oth.82.1525716499435; Mon, 07 May 2018 11:08:19 -0700 (PDT) Original-Received: by 10.74.5.135 with HTTP; Mon, 7 May 2018 11:08:19 -0700 (PDT) In-Reply-To: <83bmdrqrdd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146064 Archived-At: On 7 May 2018 at 13:59, Eli Zaretskii wrote: >> Date: Mon, 07 May 2018 08:26:01 +0200 >> From: martin rudalics >> >> - if (XFRAME (frame)->output_data.x->parent_desc == children[i] >> - || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i]) >> + if (FRAME_X_P (frame) >> + && (XFRAME (frame)->output_data.x->parent_desc == children[i] >> + || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i])) >> >> Thank you. Eli, I think Noam should push this to 26.1, if still >> possible. > > Why? The workaround is very simple: don't call that function in a > daemon session that has no GUI frames. Ah, I think you missed that the segfault happens in a daemon session that *does* have GUI frames. I would also note that w32_frame_list_z_order makes the equivalent FRAME_W32_P check via x_window_to_frame.