all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31373@debbugs.gnu.org
Subject: bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame
Date: Mon, 7 May 2018 14:08:19 -0400	[thread overview]
Message-ID: <CAM-tV--2a8bJHOoMoQibSPiy8-3sewO4JvgTUJNToO9GS2P7ZA@mail.gmail.com> (raw)
In-Reply-To: <83bmdrqrdd.fsf@gnu.org>

On 7 May 2018 at 13:59, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 07 May 2018 08:26:01 +0200
>> From: martin rudalics <rudalics@gmx.at>
>>
>> -         if (XFRAME (frame)->output_data.x->parent_desc == children[i]
>> -             || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i])
>> +            if (FRAME_X_P (frame)
>> +                && (XFRAME (frame)->output_data.x->parent_desc == children[i]
>> +                    || FRAME_OUTER_WINDOW (XFRAME (frame)) == children[i]))
>>
>> Thank you.  Eli, I think Noam should push this to 26.1, if still
>> possible.
>
> Why?  The workaround is very simple: don't call that function in a
> daemon session that has no GUI frames.

Ah, I think you missed that the segfault happens in a daemon session
that *does* have GUI frames.

I would also note that w32_frame_list_z_order makes the equivalent
FRAME_W32_P check via x_window_to_frame.





  reply	other threads:[~2018-05-07 18:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-06 13:34 bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame Basil L. Contovounesios
2018-05-06 14:14 ` Noam Postavsky
2018-05-06 14:58   ` Basil L. Contovounesios
2018-05-06 16:28     ` Noam Postavsky
2018-05-06 16:49       ` Eli Zaretskii
2018-05-06 17:09         ` Noam Postavsky
2018-05-06 17:03       ` Basil L. Contovounesios
2018-05-11  2:51         ` Noam Postavsky
2018-05-11  8:29           ` Basil L. Contovounesios
2018-05-07  6:26       ` martin rudalics
2018-05-07 17:59         ` Eli Zaretskii
2018-05-07 18:08           ` Noam Postavsky [this message]
2018-05-07 19:30             ` Eli Zaretskii
2018-05-08  1:40               ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV--2a8bJHOoMoQibSPiy8-3sewO4JvgTUJNToO9GS2P7ZA@mail.gmail.com \
    --to=npostavs@gmail.com \
    --cc=31373@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.