From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Pettersson Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dape Date: Tue, 7 Nov 2023 11:19:42 +0100 Message-ID: References: <46ea1ab1-e447-4c83-9c81-2f9bd149fe91@alphapapa.net> <6964ff20-921e-beff-43a0-9570ea79aa7d@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32242"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , John Yates , Krister Schuchardt , Adam Porter , emacs-devel@gnu.org, philipk@posteo.net To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 07 11:25:30 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0JGz-00080k-Nz for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Nov 2023 11:25:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0JC2-0002Z4-UG; Tue, 07 Nov 2023 05:20:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0JBe-0002H6-62 for emacs-devel@gnu.org; Tue, 07 Nov 2023 05:20:00 -0500 Original-Received: from mail-vs1-f49.google.com ([209.85.217.49]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0JBb-0004Pg-9U for emacs-devel@gnu.org; Tue, 07 Nov 2023 05:19:57 -0500 Original-Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-45d90e1333fso1514620137.3 for ; Tue, 07 Nov 2023 02:19:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699352394; x=1699957194; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MMJ1tLZWowpVWD6Npf+r/OS6olRppXroVMIVOG80D74=; b=gkXfJ0Omcb1OulwP8A+RtB/CSimnFRoakcDDwHI/5PxmncH4VoY1QE+BgORSIRlKzj 3fHRjxy25lAPTRgKFOLYZanaxDVaIf8dsGofuJSJ01+Rl8153WBO6+AftEQH3a2Vtbeh 2cruNrKS/VynAn3ii+Va1LJWZml1OiJRNRKVDIHUeRlIgYfeIk+ngy5y1vMSCE2zsicX 1aC8XHwbI0n88nsjpZ/c6XyyK/cTSs2wqF3vIv2GNbcTQsCtSIC/6mm1XSoMTT/v/4WE t+9oIeb6+07CG/tJ75be/xluAAiIMIaKb1k706pbJdDWQT6q9lMNLoAc1VlalGgBYGN6 9qyQ== X-Gm-Message-State: AOJu0YxkK88ojxELZfoZ6i5xpVUKto42A4Vb+iffdgzKsDCRGPnVyaHM XOpXWCgEz2WOrJpvwiVurnqZ8Z5K/SeUyw== X-Google-Smtp-Source: AGHT+IFLJp24IsD+TPjpjo6oNUAYbuYC3npnDBmsoL+nL6foQ0Amlzxw3Z6VhlaEHmWC0MvDSTuDQA== X-Received: by 2002:a67:b847:0:b0:44d:626b:94da with SMTP id o7-20020a67b847000000b0044d626b94damr27445543vsh.32.1699352393730; Tue, 07 Nov 2023 02:19:53 -0800 (PST) Original-Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com. [209.85.217.50]) by smtp.gmail.com with ESMTPSA id k33-20020ab01624000000b0079b3282b5f5sm1901769uae.2.2023.11.07.02.19.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Nov 2023 02:19:53 -0800 (PST) Original-Received: by mail-vs1-f50.google.com with SMTP id ada2fe7eead31-45d90e1333fso1514609137.3 for ; Tue, 07 Nov 2023 02:19:53 -0800 (PST) X-Received: by 2002:a67:e099:0:b0:45d:b5a2:1516 with SMTP id f25-20020a67e099000000b0045db5a21516mr6854117vsl.34.1699352392979; Tue, 07 Nov 2023 02:19:52 -0800 (PST) In-Reply-To: X-Gmail-Original-Message-ID: Received-SPF: pass client-ip=209.85.217.49; envelope-from=daniel.dpettersson.net@gmail.com; helo=mail-vs1-f49.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312290 Archived-At: > > On Thu, Nov 2, 2023 at 5:24=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > Do you know of any other significant/fundamental differences (say, such a= s a > message type which is neither a request, nor a response, nor a notificati= on)? Notification, request and response maps to events, request and response. The biggest difference might be the reverse request but that could be implemented as an notification/event in a pinch. There are two things that can be a bit of a challenge, maybe: - DAP servers are not that well behaved in general, with a pipe connection they like to use std out as they please (none DAP messages). - I don't know its a dape problem or not but it's not that hard to provoke some servers to send broken messages if they user chooses to continue the execution while the server is in the middle of responding This means that the parsing needs to do some cleanup during. > If I were to try to do these jsonrpc.el changes to accomodate DAP protoco= ls, > would you accept a PR to dape.el adding jsonrpc.el as a dependency to > dape.el? More then happy to offload some of the work ;) I think that would greatly improve the performance and stability of dape to reuse some well tested software. I also thin that dape might be able to reuse some parts of eglot, the repl completion for example, I don't know what the way forward would be for that.