From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Pettersson Newsgroups: gmane.emacs.bugs Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Date: Mon, 19 Sep 2022 22:27:39 +0200 Message-ID: References: <87a66x55hy.fsf@gnus.org> <87v8pjwz79.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9964"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , 57905@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 22:28:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaNNe-0002P0-0Z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 22:28:38 +0200 Original-Received: from localhost ([::1]:53646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaNNd-0004YH-3e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 16:28:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaNN4-0004Wq-8T for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 16:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaNN4-00005s-0w for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 16:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaNN3-00044z-SF for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 16:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Pettersson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57905-submit@debbugs.gnu.org id=B57905.166361927815670 (code B ref 57905); Mon, 19 Sep 2022 20:28:01 +0000 Original-Received: (at 57905) by debbugs.gnu.org; 19 Sep 2022 20:27:58 +0000 Original-Received: from localhost ([127.0.0.1]:55389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaNMz-00044g-PH for submit@debbugs.gnu.org; Mon, 19 Sep 2022 16:27:58 -0400 Original-Received: from mail-qt1-f170.google.com ([209.85.160.170]:41893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaNMy-00044U-2x for 57905@debbugs.gnu.org; Mon, 19 Sep 2022 16:27:56 -0400 Original-Received: by mail-qt1-f170.google.com with SMTP id c11so375000qtw.8 for <57905@debbugs.gnu.org>; Mon, 19 Sep 2022 13:27:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=FvJloCXMOjVc9ZmFeVDgwrFBw3wDvd9/mN8asoeKHis=; b=AQDe5PVDzTO+ylPVAqlKqj4QbjkgYEhBe8Z1UzHk06xQ/UW5Chp+8ke8FEmLLjlHN8 UPoPspMMhd4rzNvX14aG1rYYUpTqYVwxkNHOYHIt9NwJqIGoQ1RD12L60/kaLwCba/Sz GT62JMg0xmEAF762XwjNDZ5sSLq452GHYZFvy/pTviULdHJWbW26HLjgGrYyeB9kp3Ze Ffk9/nBr2yjbJRGDHPv91wZUZ3EGBkzpl0DRhmLpUxSIcXXOB5vQsk6t8jYX15EpyICn zpl5PedLQUL0D3REsxk/L1JbhUW73mwilw4AFLbBVUKTrrKjh0k2cKocpBC4Ul4Fd5Qn 7Ubg== X-Gm-Message-State: ACrzQf12ZFJ2a+VIg0keoGallQeV/IOO1xR7uXgIill16vuKwmuD4aWX eI61Q5LH1C6L8/kRijC3CzV6y6K/+xz5Nw== X-Google-Smtp-Source: AMsMyM7gSyR9HgzSML65uaJY9X9/wQ8nksrLuWVgR+yenZfDJ1YQfjQzlD3Mqv1fTtrqLbBfNA0EzQ== X-Received: by 2002:a05:622a:3cd:b0:344:9749:8228 with SMTP id k13-20020a05622a03cd00b0034497498228mr16713615qtx.512.1663619270564; Mon, 19 Sep 2022 13:27:50 -0700 (PDT) Original-Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id d1-20020a05620a240100b006cf14cc6740sm2872737qkn.70.2022.09.19.13.27.50 for <57905@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 13:27:50 -0700 (PDT) Original-Received: by mail-yb1-f174.google.com with SMTP id c9so471725ybf.5 for <57905@debbugs.gnu.org>; Mon, 19 Sep 2022 13:27:50 -0700 (PDT) X-Received: by 2002:a25:4985:0:b0:6b3:b7ca:6764 with SMTP id w127-20020a254985000000b006b3b7ca6764mr9190194yba.174.1663619270029; Mon, 19 Sep 2022 13:27:50 -0700 (PDT) In-Reply-To: <87v8pjwz79.fsf@gnus.org> X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243132 Archived-At: > Please don't use 'concat' to create a file name with leading > directories; instead, please use file-name-concat. Ah I had know idea of the existence of that function, that definitely seams like the better option. Thanks for spreading the word. > Some regression tests would be nice though. I've been trying to add > tests as I go through various parts of Eshell, but I haven't looked much > at the "interactive" bits like em-cmpl.el yet. 'eshell-test/forward-arg' > in test/lisp/eshell/eshell-tests.el might make for an ok basis to adapt > into some completion tests (which could probably then go into > .../em-cmpl-tests.el). I will take a look :) > Daniel, I've now pushed your patch to Emacs 29. > > This change was just small enough to apply without assigning copyright > to the FSF, but for future patches you want to submit, it might make > sense to get the paperwork started now, so that subsequent patches can > be applied speedily. Would you be willing to sign such paperwork? Great and sure.