From: Daniel Pettersson <daniel@dpettersson.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Jim Porter <jporterbugs@gmail.com>, 57905@debbugs.gnu.org
Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t
Date: Mon, 19 Sep 2022 22:27:39 +0200 [thread overview]
Message-ID: <CAM-j=qtq6H4x5dghg4TBX6u9pw9ABQReYG9E6mSmqjTqMXaQEQ@mail.gmail.com> (raw)
In-Reply-To: <87v8pjwz79.fsf@gnus.org>
> Please don't use 'concat' to create a file name with leading
> directories; instead, please use file-name-concat.
Ah I had know idea of the existence of that function, that definitely
seams like the better option. Thanks for spreading the word.
> Some regression tests would be nice though. I've been trying to add
> tests as I go through various parts of Eshell, but I haven't looked much
> at the "interactive" bits like em-cmpl.el yet. 'eshell-test/forward-arg'
> in test/lisp/eshell/eshell-tests.el might make for an ok basis to adapt
> into some completion tests (which could probably then go into
> .../em-cmpl-tests.el).
I will take a look :)
> Daniel, I've now pushed your patch to Emacs 29.
>
> This change was just small enough to apply without assigning copyright
> to the FSF, but for future patches you want to submit, it might make
> sense to get the paperwork started now, so that subsequent patches can
> be applied speedily. Would you be willing to sign such paperwork?
Great and sure.
next prev parent reply other threads:[~2022-09-19 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 22:55 bug#57905: [PATCH] Fix eshell directory and executable completion on action t Daniel Pettersson
2022-09-18 7:40 ` Eli Zaretskii
2022-09-18 10:41 ` Lars Ingebrigtsen
2022-09-19 0:31 ` Jim Porter
2022-09-19 8:22 ` Lars Ingebrigtsen
2022-09-19 20:27 ` Daniel Pettersson [this message]
2022-09-19 20:35 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-j=qtq6H4x5dghg4TBX6u9pw9ABQReYG9E6mSmqjTqMXaQEQ@mail.gmail.com' \
--to=daniel@dpettersson.net \
--cc=57905@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.