Re: [ELPA] New package: dape

[Daniel Pettersson <daniel@dpettersson.net>]

On Sun, Oct 15, 2023 at 3:55 PM Mauro Aranda <maurooaranda@gmail.com> wrote:

> I have some comments about the defcustoms in dape.el:
Super! I am not that familiar with customs.

> (keyword sexp) as the last :options looks really weird.  Are you sure
> that is the intention?
Removed :)

> If you're going to depend on 29.1, then perhaps it's better to use 'key,
> since a decision was made to obsolete 'key-sequence.  If something
> doesn't work with 'key but works with 'key-sequence, then please report
> it.
Makes sense.

> This doesn't allow for any customization at all when using Customize.  I
> think you want to use '(repeat function)

This has been changed to 'hooks.

>  > (defcustom dape-main-functions '("main")
>  >   "Functions to set breakpoints at startup if no other breakpoints
> are set."
>  >   :type '(list string))
> I think you want (repeat string) here.
Fixed!

>  > (defcustom dape-read-memory-default-count 1024
>  >   "The default count for `dape-read-memory'."
>  >   :type '(integer))
>
> Is natnum better suited here?
Sure, changed.

>  > (defcustom dape--debug-on
>  >   '(io info error std-server)
>  >   "Types of logs should be printed to *dape-debug*."
>  >   :type '(list (const :tag "dap IO" io)
>  >                (const :tag "info logging" info)
>  >                (const :tag "error logging" error)
>  >                (const :tag "dap tcp server stdout" std-server)))
>
> Similar to dape-buffers-on-start.
Fixed, `set' instead of `list'. Should do it right.

Great input!