From: Fujii Hironori <fujii.hironori@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 19910@debbugs.gnu.org
Subject: bug#19910: 24.4; Japanese font names are decoded incorrectly in Cygwin's emacs-w32 in LANG=ja_JP.UTF-8
Date: Sat, 28 Feb 2015 21:14:00 +0900 [thread overview]
Message-ID: <CALus1PkfjTojw-JqBeHkpg5hSTyo0g9i_VdLb7kqZAcu4EyvLQ@mail.gmail.com> (raw)
In-Reply-To: <83y4nj49zx.fsf@gnu.org>
Thank you for reviewing my patch, Eli.
On Sat, Feb 28, 2015 at 1:03 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> However, this goes too far: there's no need to replace all the
> functions with "wide" versions, only those functions that return font
> name strings from the system. For example, I don't think
> CreateFontIndirect needs to be switched to Unicode, does it? And CRT
> functions like _wcslwr and swprintf that work on wchar_t arguments
> aren't supported on Windows 9X, AFAIK, so we cannot call them. (One
> reason for using the minimum number of "wide" APIs is that we don't
> have good ways of testing the development code on Windows 9X.)
This is the code:
| 862 hfont = CreateFontIndirect (&logfont);
| (...)
| 912 = DECODE_SYSTEM (build_string (logfont.lfFaceName));
logfont.lfFaceName is ANSI text and DECODE_SYSTEM is the problem.
CreateFontIndirect should be wide.
> I would actually suggest to have a Cygwin-only branches of the code,
> where you can freely call the "wide" APIs without bothering about
> Windows 9X, since that's what the Cygwin-w32 build does elsewhere, and
> since this is a Cygwin-specific problem due to the difference between
> file-name encoding and the locale emulated by Cygwin. There are a
> bunch of macros like GUI_STR and GUI_ENCODE_FILE near the end of
> w32term.h that can be used to minimize #ifdef's to the absolute
> minimum.
If this approach is used, structs such as LOGFONT and ENUMLOGFONTEX
should be ranemed to GUI_FN(LOGFONT) and GUI_FN(ENUMLOGFONTEX).
This looks ugly.
The best way to solve this is defining _UNICODE.
Defining _UNICODE is already filed, but closed as wontfix.
#265 - Build error with _UNICODE on w32. - GNU bug report logs
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=265
If Bug#265 is resolved, this bug (Bug#19910) will be resolved automatically.
And, _UNICODE macro can be used not only for Cygwin, but also NTEmacs.
next prev parent reply other threads:[~2015-02-28 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 10:39 bug#19910: 24.4; Japanese font names are decoded incorrectly in Cygwin's emacs-w32 in LANG=ja_JP.UTF-8 Fujii Hironori
2015-02-20 11:21 ` Eli Zaretskii
2015-02-27 15:22 ` Fujii Hironori
2015-02-27 16:03 ` Eli Zaretskii
2015-02-28 12:14 ` Fujii Hironori [this message]
2015-02-28 12:46 ` Eli Zaretskii
2019-12-01 8:21 ` Stefan Kangas
2019-12-01 17:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALus1PkfjTojw-JqBeHkpg5hSTyo0g9i_VdLb7kqZAcu4EyvLQ@mail.gmail.com \
--to=fujii.hironori@gmail.com \
--cc=19910@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.