From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Urban Engberg Newsgroups: gmane.emacs.bugs Subject: bug#59232: Date: Wed, 20 Dec 2023 18:38:20 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001720d4060cf475a7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18797"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59232@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 20 23:10:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rG4lc-0004eA-T6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Dec 2023 23:10:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rG4lO-0003DQ-PV; Wed, 20 Dec 2023 17:10:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rG4lL-0003CL-J0 for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2023 17:09:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rG4lL-0000jW-BJ for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2023 17:09:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rG4lO-0002j2-Pd for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2023 17:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Urban Engberg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Dec 2023 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59232 X-GNU-PR-Package: emacs Original-Received: via spool by 59232-submit@debbugs.gnu.org id=B59232.170311015510395 (code B ref 59232); Wed, 20 Dec 2023 22:10:02 +0000 Original-Received: (at 59232) by debbugs.gnu.org; 20 Dec 2023 22:09:15 +0000 Original-Received: from localhost ([127.0.0.1]:41974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rG4kb-0002hT-Se for submit@debbugs.gnu.org; Wed, 20 Dec 2023 17:09:15 -0500 Original-Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:57444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rG0XB-0007c2-Uh for 59232@debbugs.gnu.org; Wed, 20 Dec 2023 12:39:09 -0500 Original-Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-54c7744a93fso7427781a12.2 for <59232@debbugs.gnu.org>; Wed, 20 Dec 2023 09:39:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=engbergs-dk.20230601.gappssmtp.com; s=20230601; t=1703093936; x=1703698736; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yx1uegaGVfGLJMqNLFOQl2OKc0MYMG8mF4OSkGJ0r8k=; b=uXEBmTvO2RVALdFsTaVWguUdggMBGvdpQT/N0NzH0SXfVS4clYvgxirKnMO6jls2SS oLAodZlvN7Bc98MXhtlxqcGL9qtvJQszTOX2AHzmM7etQeNFPWXk0nGzHwI/SoeGE0v4 fldedyFQ3615JO0yP1pTTUDK87KnxUc9A6Srs8kdScy0L7xV1eAWtGpqWNDz5HE4qG6Q zVHx5onQ3dduOOJJkSZh0ebMdPzSuVbx4N8gU2D9RAlHB+kh9Q/4UPikDn50rw7/IKIR uzbZoct37VfFgO3HGamLCBXup+aVHV7rNjboMoy90ycZIaJicTV+13Op6vnTL+M86WDR iy0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703093936; x=1703698736; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yx1uegaGVfGLJMqNLFOQl2OKc0MYMG8mF4OSkGJ0r8k=; b=m6At5BeyJ8bhqOTaYOpkNk4/5DmNBp9R0sls1ZfvCIjJsaUq6hxqWJGdEFQL+gru0L Z4Y5UT9t9VVZfXoCfyzRFcnKHbOouGQfPwG/OmJAGc/EwLehZrgsTTAbmDraE79I1o5+ e2GQPiCA2dHO/uHln2xszFVRJJ5/PZfdbG1c1/vm8ZxnEjjbEtqat/s3cRQV20gUkx14 fgoNkmonTuE4dx8MGCj6mrRhCQyK9ZwGuvMlSG+am67Jc64fQXbA1LDl200uran+6Ytn 4LydG4Q+7m0feYUQsH3waSnIfJMPFIX+9lOrWfgL9IkBiBYnpmUdC4ySuAMlVXuykFQm 5lDA== X-Gm-Message-State: AOJu0Yw5+TtcZ9ZDmbI94L2+3qH2r5q2sKuXIQPE0Q38bCsWMLPUJ5FO ZYBWGF1XaEAcYxQFkM2Qm4ItBlhIb1NfYXE/Bi4robVzt+nIcBqqF84= X-Google-Smtp-Source: AGHT+IE0QPt00AaH6TypHG/Hf3IhhwngeT5XKhQ7BMrpA4GUrR8IMMN+Id04ePf8dm+O1o+nHtc3lknQaq4Byah/XSA= X-Received: by 2002:a50:a41c:0:b0:553:b950:f9d4 with SMTP id u28-20020a50a41c000000b00553b950f9d4mr883016edb.80.1703093936262; Wed, 20 Dec 2023 09:38:56 -0800 (PST) In-Reply-To: X-Mailman-Approved-At: Wed, 20 Dec 2023 17:09:10 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276597 Archived-At: --0000000000001720d4060cf475a7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 20 Dec 2023 at 16:50, Dmitry Gutov wrote: > This kind of change is bound to make worse the apparent performance of > vc-annotate with SVN. So it would be great to understand the issue of > the problem first. > > Is that a network error? Do you see the same problem with your corporate > repo when calling the respective command in the command line? > > Worst case, we could create a user option, to only be used in affected > projects. > I agree, absolutely. This was just how far I had been able to do my analysis =E2=80=93 and I thought it might be helpful to others diagnosing t= he problem. I have done some more debugging am able to get as far as this snippet (from the function vc-do-command with arguments unfolded, when okstatus is 'async): (let ((process-connection-type nil)) (start-file-process "svn" (get-buffer "*Annotate Program.java (rev 23283)*") "svn" "--non-interactive" "annotate" "/home/.../Program.java")) When I run this command directly in Emacs (using eval-defun), around the first 100 lines of the svn output is written to the *annotate* buffer, after which I get the output Process svn exited abnormally with code 1 written to the buffer. If I set process-conection-type to t instead, the process finishes without problems. The svn command is run against an SSH-server inhouse and the annotate-command takes around 1 second when run from my shell, and I haven't seen it fail. I run svn version 1.14.2. If you have any ideas of what I should do from here, I'd be happy to assist= . --=20 urban@engbergs.dk, 5679+MHJ =C3=85rhus --0000000000001720d4060cf475a7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, 20 Dec 2023 at= 16:50, Dmitry Gutov <dmitry@gutov.d= ev> wrote:
Th= is kind of change is bound to make worse the apparent performance of
vc-= annotate with SVN. So it would be great to understand the issue of
the p= roblem first.

Is that a network error? Do you see the same problem w= ith your corporate
repo when calling the respective command in the comma= nd line?

Worst case, we could create a user option, to only be used = in affected
projects.

I agree, absolutely. This was just how far I had been able to do my ana= lysis =E2=80=93 and I thought it might be helpful to others diagnosing the = problem.

I have done some more debugging am able to get = as far as this snippet (from the function vc-do-command with arguments unfo= lded, when okstatus is 'async):

(let ((process-connection-type nil))
=C2=A0 (start-file-process
=C2=A0 =C2=A0"svn"
=C2=A0 =C2=A0(get-buffer "*Annotate Program.java (rev 23283)*")=
=C2=A0 =C2=A0"svn"
=C2=A0 =C2=A0"--non-interactive= " "annotate" "/home/.../Program.java"))

When I run th= is command directly in Emacs (using eval-defun), around the first 100 lines= of the svn output is written to the *annotate* buffer, after which I get t= he output

Process svn exited abnormally wi= th code 1

written to the buffer. If I set=C2=A0process-conection-type=C2= =A0to t instead, the process finishes without problems.

The svn command is run against an SSH-server inhouse and the annotate= -command takes around 1 second when run from my shell, and I haven't se= en it fail.

I run svn version 1.14.2.
If you have any ideas of what I should do from here, I'd b= e happy to assist.

--
--0000000000001720d4060cf475a7--