all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Puneeth Chaganti <punchagan@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [RFC] Change property drawer syntax
Date: Fri, 5 Dec 2014 20:03:04 +0530	[thread overview]
Message-ID: <CALnw1fSu5AqsEDO54fP=xX70_KiFgJyzHU_-VgOEqy4Oo2-yaw@mail.gmail.com> (raw)
In-Reply-To: <87mw7bnf7c.fsf@nicolasgoaziou.fr>

Hi Nicolas,

It looks the commit 8d8ad983823c63b13fd6b471ce9db8c2f95e3808 broke
generation of org sparse trees, when searching with properties that
are not all uppercase.   The fix seems to be just removing the
conversion of key to upcase in `org-entry-properties'.  Since the
comparison with special properties is being done by a case insensitive
check, this should be the only fix required?  There are no test
failures, and the conversion to uppercase seems to have been
introduced only in this change, so it should be OK?

diff --git a/lisp/org.el b/lisp/org.el
index e806440..8cbbcc4 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15703,7 +15703,7 @@ strings."
                    ;; after its extension.  We also forbid standard
                    ;; properties to be named as special properties.
                    (while (re-search-forward org-property-re end t)
-                     (let* ((key (upcase (org-match-string-no-properties 2)))
+                     (let* ((key (org-match-string-no-properties 2))
                             (extendp (org-string-match-p "\\+\\'" key))
                             (key-base (if extendp (substring key 0 -1) key))
                             (value (org-match-string-no-properties 3)))

Thanks,
Puneeth

  reply	other threads:[~2014-12-05 14:33 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 14:42 [RFC] Change property drawer syntax Nicolas Goaziou
2014-10-14 14:55 ` Andreas Leha
2014-10-14 15:55   ` Nicolas Goaziou
2014-10-14 16:18 ` Eric Abrahamsen
2014-10-14 19:26   ` Nicolas Goaziou
2014-10-14 16:25 ` Michael Brand
2014-10-14 19:38   ` Nicolas Goaziou
2014-10-15 17:25     ` Michael Brand
2014-10-15 20:52       ` Nicolas Goaziou
2014-10-15  2:58 ` Eric Abrahamsen
2014-10-15 10:11   ` Nicolas Goaziou
2014-10-15 11:22     ` Eric Abrahamsen
2014-10-15  7:38 ` Rainer M Krug
2014-10-15 10:14   ` Nicolas Goaziou
2014-10-15 11:27     ` Rainer M Krug
2014-10-20 22:35 ` Rasmus
2014-10-26 15:24 ` Nicolas Goaziou
2014-10-28 13:27   ` Nicolas Goaziou
2014-11-06 10:21     ` Sebastien Vauban
2014-11-08 13:46       ` Nicolas Goaziou
2014-11-10 10:19         ` Sebastien Vauban
2014-11-10 10:41           ` Nicolas Goaziou
2014-11-10 11:04             ` Sebastien Vauban
2014-11-10 11:51               ` Nicolas Goaziou
2014-11-10 12:55                 ` Sebastien Vauban
2014-11-12 10:40             ` Sebastien Vauban
2014-11-13 19:58               ` Nicolas Goaziou
     [not found]                 ` <87sihmq3dd.fsf-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org>
2014-11-26 14:09                   ` Sebastien Vauban
2014-10-31 13:10   ` Christian Egli
2014-10-31 16:10     ` John Hendy
2014-11-03  8:27       ` Christian Egli
2014-11-03  8:33         ` Nicolas Goaziou
2014-11-01 10:57     ` Nicolas Goaziou
2014-11-03  8:38       ` Christian Egli
2014-11-03 20:14         ` Nicolas Goaziou
2014-11-12 11:01 ` Sebastien Vauban
2014-11-12 11:11   ` Sebastien Vauban
2014-11-26 14:18     ` Sebastien Vauban
2014-11-26 23:37       ` Nicolas Goaziou
2014-11-27  9:24         ` Sebastien Vauban
2014-11-28 22:16           ` Nicolas Goaziou
2014-12-05 14:33             ` Puneeth Chaganti [this message]
2014-12-05 23:31               ` Nicolas Goaziou
2014-12-06  6:42                 ` Puneeth Chaganti
2014-12-06 20:36                   ` Nicolas Goaziou
2014-11-14  8:36   ` Nicolas Goaziou
     [not found]     ` <87ppcqnpq7.fsf-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org>
2014-11-14 13:58       ` Sebastien Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALnw1fSu5AqsEDO54fP=xX70_KiFgJyzHU_-VgOEqy4Oo2-yaw@mail.gmail.com' \
    --to=punchagan@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.