From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: table formula help... Date: Mon, 8 Dec 2014 19:02:53 +0100 Message-ID: References: <87ppbxfi5f.fsf@ericabrahamsen.net> <54838805.8090705@free.fr> <8761do6t01.fsf@ericabrahamsen.net> <5484CD5C.9070604@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy2e7-0007pu-HA for emacs-orgmode@gnu.org; Mon, 08 Dec 2014 13:02:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xy2e6-0002Ll-4M for emacs-orgmode@gnu.org; Mon, 08 Dec 2014 13:02:55 -0500 Received: from mail-qc0-x235.google.com ([2607:f8b0:400d:c01::235]:51632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy2e5-0002LE-W9 for emacs-orgmode@gnu.org; Mon, 08 Dec 2014 13:02:54 -0500 Received: by mail-qc0-f181.google.com with SMTP id m20so3933739qcx.12 for ; Mon, 08 Dec 2014 10:02:53 -0800 (PST) In-Reply-To: <5484CD5C.9070604@free.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Thierry Banel Cc: Org Mode Hi Thierry On Sun, Dec 7, 2014 at 10:57 PM, Thierry Banel wrote: > Done. > Probably this can be discussed further. I hope that there are more opinions than only mine. > For the time being, there is no longer any "NA". Good. My opinion is about to replace it with what. https://github.com/tbanel/orgaggregate#empty-and-malformed-input-cells says: An input cell may be empty. In this case, it is silently replaced by zero. In an output cell, if the computed result is zero, it not output, leaving a blank cell. This allows for empty input cells to result in empty output cells. I understand the intention very well (the proof is in the references at the bottom ;-) ). Nevertheless I find the compromise goes too far when in the following example the sum and mean for a0 and b0 are empty. I would prefer 0 there even when for the time being it is at the cost of that c results in a sum and mean of 0 too. It would mean to remove the above "In an output cell, if the computed result is zero, it not output, leaving a blank cell. [...]". Or - when you want to bother with the implementation - to change it into "If all input cells of a computation are empty then the result cell is left empty.". #+TBLNAME: original | Item | Value | |------+-------| | a2 | 1 | | a2 | 1 | | a0 | -1 | | a0 | 1 | | b2 | 2 | | b2 | | | b0 | 0 | | b0 | | | c | | | c | | #+BEGIN: aggregate :table original :cols "Item sum(Value) mean(Value)" | Item | sum(Value) | mean(Value) | |------+------------+-------------| | a2 | 2 | 1 | | a0 | | | | b2 | 2 | 1 | | b0 | | | | c | | | #+END Could you please add this example or something in the same sense to the unittests.org before any other change? https://github.com/tbanel/orgaggregate#empty-and-malformed-input-cells continues: The empty cell handling may be changed in the futur. For instance, we may want to compute an average aggregation ignoring empty cells (right now, empty cells contribute to the average by pulling it toward zero). As I understand orgaggregate already uses Calc vectors. Maybe then it could use and benefit from org-table-make-reference which has the necessary arguments and asks for a Lisp list? See testing/lisp/test-org-table.el: - The application of the mode string variations for TBLFM are in test-org-table/references/mode-string-*. - The same variations for org-table-make-reference are in test-org-table/org-table-make-reference/mode-string-* Michael