From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: org-pdfview-open doesn't work anymore Date: Fri, 5 Feb 2016 14:45:46 +0100 Message-ID: References: <87a8nfzp44.fsf@free.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b5d649a793e30052b0611c7 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRgho-0005wy-TS for emacs-orgmode@gnu.org; Fri, 05 Feb 2016 08:45:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRghn-0000L6-G5 for emacs-orgmode@gnu.org; Fri, 05 Feb 2016 08:45:48 -0500 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:33916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRghn-0000L1-4k for emacs-orgmode@gnu.org; Fri, 05 Feb 2016 08:45:47 -0500 Received: by mail-wm0-x22f.google.com with SMTP id 128so71287787wmz.1 for ; Fri, 05 Feb 2016 05:45:46 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode Cc: Julien Cubizolles --047d7b5d649a793e30052b0611c7 Content-Type: text/plain; charset=UTF-8 Hi Nicolas On Fri, Feb 5, 2016 at 9:33 AM, Michael Brand wrote: > Due to lexical binding in org.el there was a change in > `org-file-apps', see Org News for version 9.0 and e. g. this thread: > http://thread.gmane.org/gmane.emacs.orgmode/104272 > I think the most convenient would be if `org-open-file' tries to find > out that `cmd' in this case is a function with only one argument and > call it with just `file'. Only after a closer look I saw that the single parameter of `org-pdfview-open' is not `file' but `link'. It is probably better for `org-open-file' to not guess in case of `cmd' with a single parameter whether it is meant to be `file' or `link'. That leads me to suggest the attached patch to be reviewed that checks the function signature. Michael --047d7b5d649a793e30052b0611c7 Content-Type: text/x-patch; charset=US-ASCII; name="0001-org-file-apps-add-migration-hint-for-function-signat.patch" Content-Disposition: attachment; filename="0001-org-file-apps-add-migration-hint-for-function-signat.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ik9quzik0 RnJvbSA5Nzg4Y2IwM2QyNzE0Y2RlNTU1ZmJlMmFiYjU1ZGRkMzgzYTg4NWMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJyYW5kIDxtaWNoYWVsLmNoLmJyYW5kQGdtYWls LmNvbT4KRGF0ZTogRnJpLCA1IEZlYiAyMDE2IDE0OjQ0OjI2ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gYG9yZy1maWxlLWFwcHMnIGFkZCBtaWdyYXRpb24gaGludCBmb3IgZnVuY3Rpb24gc2lnbmF0 dXJlCgoqIGxpc3Avb3JnLmVsIChvcmctb3Blbi1maWxlKTogQWRkIGFuIGVycm9yIHdoZW4gdGhl IGZ1bmN0aW9uCnNpZ25hdHVyZSBkb2VzIG5vdCBtYXRjaC4KLS0tCiBsaXNwL29yZy5lbCB8IDE3 ICsrKysrKysrKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlzcC9vcmcuZWwKaW5kZXgg NWE2Yzc0ZS4uOWViYWJmOCAxMDA2NDQKLS0tIGEvbGlzcC9vcmcuZWwKKysrIGIvbGlzcC9vcmcu ZWwKQEAgLTExMzIzLDYgKzExMzIzLDE4IEBAIElmIHRoZSBmaWxlIGRvZXMgbm90IGV4aXN0LCBh biBlcnJvciBpcyB0aHJvd24uIgogCQkgICh3aGVuIChkZXJpdmVkLW1vZGUtcCAnb3JnLW1vZGUp IChvcmctcmV2ZWFsKSkpCiAJICAgIChzZWFyY2ggKG9yZy1saW5rLXNlYXJjaCBzZWFyY2gpKSkp CiAgICAgICgoZnVuY3Rpb25wIGNtZCkKKyAgICAgIDs7IEZJWE1FOiBSZW1vdmUgdGhpcyBjaGVj ayB3aGVuIG1vc3QgZGVmYXVsdCBpbnN0YWxsYXRpb25zIG9mCisgICAgICA7OyBFbWFjcyBoYXZl IGF0IGxlYXN0IE9yZyA5LjAuCisgICAgICAobGV0ICgoYXJnbGlzdCAoaGVscC1mdW5jdGlvbi1h cmdsaXN0IGNtZCkpKQorCSh3aGVuIChvciAobWVtcSAnJm9wdGlvbmFsIGFyZ2xpc3QpCisJCSAg KG1lbXEgJyZyZXN0IGFyZ2xpc3QpCisJCSAgKC89IDIgKGxlbmd0aCBhcmdsaXN0KSkpCisJICAo dXNlci1lcnJvcgorCSAgIChmb3JtYXQKKwkgICAgIiVzJXMlUyIKKwkgICAgIlBsZWFzZSBzZWUg T3JnIE5ld3MgZm9yIHZlcnNpb24gOS4wIGFib3V0IGBvcmctZmlsZS1hcHBzJywgIgorCSAgICAi dGhpcyBmdW5jdGlvbiBzaWduYXR1cmUgaXMgd3Jvbmc6ICIKKwkgICAgY21kKSkpKQogICAgICAg KHNhdmUtbWF0Y2gtZGF0YQogCShzZXQtbWF0Y2gtZGF0YSBsaW5rLW1hdGNoLWRhdGEpCiAJKGZ1 bmNhbGwgY21kIGZpbGUgbGluaykpKQpAQCAtMTEzMzMsNyArMTEzNDUsMTAgQEAgSWYgdGhlIGZp bGUgZG9lcyBub3QgZXhpc3QsIGFuIGVycm9yIGlzIHRocm93bi4iCiAgICAgICA7OyBgb3JnLWxp bmstZnJhbWUtc2V0dXAnIGZvciBhbiBvbGQgdXNhZ2Ugb2YgYG9yZy1maWxlLWFwcHMnCiAgICAg ICA7OyB3aXRoIHNleHAgaW5zdGVhZCBvZiBhIGZ1bmN0aW9uIGZvciBgY21kJy4KICAgICAgICh1 c2VyLWVycm9yCi0gICAgICAgIlBsZWFzZSBzZWUgT3JnIE5ld3MgZm9yIHZlcnNpb24gOS4wIGFi b3V0IGBvcmctZmlsZS1hcHBzJyIpKQorICAgICAgIChmb3JtYXQgIiVzJXMlUyIKKwkgICAgICAg IlBsZWFzZSBzZWUgT3JnIE5ld3MgZm9yIHZlcnNpb24gOS4wIGFib3V0IGBvcmctZmlsZS1hcHBz JywgIgorCSAgICAgICAidGhpcyB1c2FnZSBpcyB3cm9uZzogIgorCSAgICAgICBjbWQpKSkKICAg ICAgKHQgKGZ1bmNhbGwgKGNkciAoYXNzcSAnZmlsZSBvcmctbGluay1mcmFtZS1zZXR1cCkpIGZp bGUpKSkKICAgICAoYW5kIChkZXJpdmVkLW1vZGUtcCAnb3JnLW1vZGUpCiAJIChlcSBvbGQtbW9k ZSAnb3JnLW1vZGUpCi0tIAoyLjEuMy5kaXJ0eQoK --047d7b5d649a793e30052b0611c7--