From: Michael Brand <michael.ch.brand@gmail.com>
To: Julien Cubizolles <j.cubizolles@free.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: org-pdfview-open doesn't work anymore
Date: Fri, 5 Feb 2016 09:33:38 +0100 [thread overview]
Message-ID: <CALn3zogTXXjwOJh2tEDgAb9p9zqNAM+oJVjDC3eBG-KuiQqPFg@mail.gmail.com> (raw)
In-Reply-To: <87a8nfzp44.fsf@free.fr>
Hi Julien
On Fri, Feb 5, 2016 at 6:46 AM, Julien Cubizolles <j.cubizolles@free.fr> wrote:
> I've been using org-pdfview (from
> https://github.com/markus1189/org-pdfview) to have org-mode open pdf
> files generated during export.
>
> --8<---------------cut here---------------start------------->8---
> (pdf-tools-install)
> (eval-after-load 'org '(progn (require 'org-pdfview)
> (add-to-list 'org-file-apps '("\\.pdf\\'" . org-pdfview-open))
> ))
> --8<---------------cut here---------------end--------------->8---
>
> Since a recent upgrade, this fails with:
>
> --8<---------------cut here---------------start------------->8---
> (wrong-number-of-arguments #[(link) "\304\305 \"\2031\306\307 \"\310\306\311 \"!\310\306\312 \"!\313 \307\"\210\314
> !\210\315\316 \317 @_\320 \245!!+\207\304\321 \"\203N\306\307 \"\310\306\311 \"!\313 \307\"\210\314
> !*\207\313 \307\"\207" [link path page height string-match "\\(.*\\)::\\([0-9]*\\)\\+\\+\\([[0-9]\\.*[0-9]*\\)" match-string 1 string-to-number 2 3 org-open-file pdf-view-goto-page image-set-window-vscroll round pdf-view-image-size frame-char-height "\\(.*\\)::\\([0-9]+\\)$"] 4 ("/home/wilk/.emacs.d/elpa/org-pdfview-20160125.1254/org-pdfview.elc" . 662)] 2)
> org-pdfview-open("/home/wilk/enseignement/2015-2016/topos/topo-tipe-beamer.pdf" "/home/wilk/enseignement/2015-2016/topos/topo-tipe-beamer.pdf")
> --8<---------------cut here---------------end--------------->8---
>
> Is it a bug in Org-mode or should I report the issue to the org-pdfview
> author ?
Due to lexical binding in org.el there was a change in
`org-file-apps', see Org News for version 9.0 and e. g. this thread:
http://thread.gmane.org/gmane.emacs.orgmode/104272
I think the most convenient would be if `org-open-file' tries to find
out that `cmd' in this case is a function with only one argument and
call it with just `file'.
@Nicolas: Is this reasonable for you to implement?
Michael
next prev parent reply other threads:[~2016-02-05 8:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 5:46 org-pdfview-open doesn't work anymore Julien Cubizolles
2016-02-05 8:33 ` Michael Brand [this message]
2016-02-05 13:36 ` Nicolas Goaziou
2016-02-10 12:55 ` Julien Cubizolles
2016-02-05 13:45 ` Michael Brand
2016-02-05 17:22 ` Nicolas Goaziou
2016-02-05 18:47 ` Michael Brand
2016-02-05 22:43 ` Nicolas Goaziou
2016-02-06 8:08 ` Michael Brand
2016-02-06 16:41 ` Nicolas Goaziou
2016-02-07 10:13 ` Michael Brand
2016-02-07 11:06 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALn3zogTXXjwOJh2tEDgAb9p9zqNAM+oJVjDC3eBG-KuiQqPFg@mail.gmail.com \
--to=michael.ch.brand@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=j.cubizolles@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.