From: "Andrew W. Nosenko" <andrew.w.nosenko@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: hochberg@dmhsoftware.com, 8439@debbugs.gnu.org,
Jari Aalto <jari.aalto@cante.net>
Subject: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v2)
Date: Sat, 20 Oct 2012 00:47:55 +0300 [thread overview]
Message-ID: <CALa-7vz8FCYQSjHn557ww0hZChLFgjVuxWnNLVJ4ju3D4iOXBQ@mail.gmail.com> (raw)
In-Reply-To: <83a9vi23mi.fsf@gnu.org>
On Fri, Oct 19, 2012 at 12:49 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Jari Aalto <jari.aalto@cante.net>
>> Date: Fri, 19 Oct 2012 10:39:36 +0300
>> Cc: Yigal Hochberg <hochberg@dmhsoftware.com>
>>
>>
>> With some more field testing, the following patch works better.
>>
>> 1. New variable ffap-paths-with-spaces controls if the behavior is in use.
>> By default it is set to "t" in Windows/Cygwin where spaces in paths
>> are encountered.
>
> GNU Coding Standards frown upon using "path" for anything except
> PATH-style lists of directories. Use "file name" or "leading
> directories" instead.
>
>> 2. The "path skipping" is based on finding longest distance:
>>
>> - from first "drive letter", "/" or "\"
>> - until last "/", "\" followed by last non-matching-char-not-usually-found-in-file-names
>
> What will this do to text such as the one below?
>
> C:\emacs\bin\prog1.exe on Windows or /usr/bin/prog1 on Unix.
Eli, excuse me very much, but you cheating. Even under Unix (where
spaces inside filenames are very unusual) people instinctively trying
heavy to distinguish/decorate them from outside/descriptive text. The
only one problem that there no consensus about how to do it. What
characters pair to use? <>? ""? ''? But anyway just separate filename
with possible spaces just by spaces... It's out of my ability to
imagine. Therefore, I would to discard this example as rare. After
all, any heuristic have his own false positives (and it is the reason,
why I said "cheating": for every heuristic it's always possible to
imagine a situation/input data when heuristic will fail).
But, if there no way to make false positives amount small enough, I
would to propose an idea for extension: find-file-at-region(). You
just select a region of text, and Emacs tries to interprets it as
default value for find-file().
>
>> 3. In Cygwin Emacs the paths are expected to be in "/cygdrive/<letter>/"
>> format.
>
> What about Posix-standard /foo/bar/baz, which is the usual case on
> Cygwin?
>
>
>
--
Andrew W. Nosenko <andrew.w.nosenko@gmail.com>
next prev parent reply other threads:[~2012-10-19 21:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 15:24 bug#8439: [PATCH] ffap.el -- detect paths with spaces Jari Aalto
2011-07-03 23:29 ` Lars Magne Ingebrigtsen
2012-10-19 7:39 ` bug#8439: [PATCH] ffap.el -- detect paths with spaces (v2) Jari Aalto
2012-10-19 9:49 ` Eli Zaretskii
2012-10-19 10:05 ` jari
2012-10-19 11:15 ` Yigal Hochberg
2012-10-19 11:22 ` Eli Zaretskii
2012-10-19 12:15 ` Nicolas Richard
2012-10-19 21:47 ` Andrew W. Nosenko [this message]
2012-10-19 22:23 ` Eli Zaretskii
2012-10-19 22:36 ` Yigal Hochberg
2012-10-19 22:57 ` Andrew W. Nosenko
2012-10-19 23:24 ` Yigal Hochberg
2012-10-20 1:45 ` Stefan Monnier
2012-10-20 11:01 ` Juri Linkov
2012-10-19 8:35 ` Jari Aalto
2012-10-20 1:44 ` Stefan Monnier
2012-10-20 1:49 ` Daniel Colascione
2012-10-20 7:56 ` bug#8439: [PATCH] ffap.el -- detect paths with spaces (v3) jari
2012-10-20 8:45 ` bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) jari
2012-10-20 10:20 ` Eli Zaretskii
2012-10-21 0:18 ` Stefan Monnier
2012-10-21 8:07 ` Jari Aalto
2019-11-23 13:31 ` bug#6695: " Lars Ingebrigtsen
2020-08-14 13:08 ` Lars Ingebrigtsen
2020-08-15 9:07 ` Eli Zaretskii
2020-08-15 10:13 ` Lars Ingebrigtsen
2012-10-20 8:11 ` bug#8439: [PATCH] ffap.el -- detect paths with spaces (v2) Eli Zaretskii
2012-10-21 0:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALa-7vz8FCYQSjHn557ww0hZChLFgjVuxWnNLVJ4ju3D4iOXBQ@mail.gmail.com \
--to=andrew.w.nosenko@gmail.com \
--cc=8439@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=hochberg@dmhsoftware.com \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.