all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jake Nelson <jake.nelson@gmail.com>
To: 39345@debbugs.gnu.org
Subject: bug#39345: 28.0.50; rcirc-authenticate-before-join due to case sensitive mismatch
Date: Wed, 29 Jan 2020 09:29:26 -0500	[thread overview]
Message-ID: <CALS194MGMFZc=rZwOoumjStS2F9dFHA-xCeNsqahS=cDgCMX6Q@mail.gmail.com> (raw)

1. join irc.freenode.net with a lowercase nick "examplenick"
2. authenticate to nickserv
3. nickserv echos back  "-NickServ- You are now identified for
"Examplenick" capitalizing the nickname.
4. rcirc-authenticate-before-join does not trigger, so no channels are
auto-joined.

The existing check is case sensitive.  The patch below fixes the issue
for me on freenode.

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index 5722582ab6..b516c8d0a6 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -2624,12 +2624,12 @@ rcirc-check-auth-status
         (when (or
                (and ;; nickserv
                 (string= sender "NickServ")
-                (string= target rcirc-nick)
-                (member message
+                (string= (downcase target) (downcase rcirc-nick))
+                (member (downcase message)
                         (list
-                         (format "You are now identified for
\C-b%s\C-b." rcirc-nick)
-                        (format "You are successfully identified as
\C-b%s\C-b." rcirc-nick)
-                         "Password accepted - you are now recognized."
+                         (downcase (format "You are now identified
for \C-b%s\C-b." rcirc-nick))
+                        (downcase (format "You are successfully
identified as \C-b%s\C-b." rcirc-nick))
+                         (downcase "Password accepted - you are now
recognized.")
                          )))
                (and ;; quakenet
                 (string= sender "Q")





             reply	other threads:[~2020-01-29 14:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 14:29 Jake Nelson [this message]
2020-01-29 15:20 ` bug#39345: 28.0.50; rcirc-authenticate-before-join due to case sensitive mismatch Noam Postavsky
2020-01-29 17:59   ` Jake Nelson
2020-03-13  1:30     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALS194MGMFZc=rZwOoumjStS2F9dFHA-xCeNsqahS=cDgCMX6Q@mail.gmail.com' \
    --to=jake.nelson@gmail.com \
    --cc=39345@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.