From: Eli Barzilay <eli@barzilay.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 41347@debbugs.gnu.org, Chris Zheng <chriszheng99@gmail.com>
Subject: bug#41347: 28.0.50; calculator.el: Cannot input negative exponents
Date: Sun, 17 May 2020 16:26:39 -0400 [thread overview]
Message-ID: <CALO-gutjnuBvtkPoa-4zTdKgwWaL=cWxaYRKjRBDXATah6YkoQ@mail.gmail.com> (raw)
In-Reply-To: <60FECFFF-BF00-4D6A-9297-105B1E1B69C8@acm.org>
On Sun, May 17, 2020 at 7:08 AM Mattias Engdegård <mattiase@acm.org> wrote:
>
> > @@ -863,7 +863,7 @@ calculator-string-to-number
> > (let* ((str (replace-regexp-in-string
> > "\\.\\([^0-9].*\\)?$" ".0\\1" str))
> > (str (replace-regexp-in-string
> > - "[eE][+-]?\\([^0-9].*\\)?$" "e0\\1" str)))
> > + "[eE]\\([+-]?\\)?$" "e\\10" str)))
> > (float (string-to-number str)))))
>
> Thanks for the report and the suggested patch! However, I'm not sure
> what either of these replace-regexp-in-string calls are good for. The
> first one possibly to accept 1.e23 instead of 1e23; the second one is
> less clear. Frankly, I think we can drop both.
>
> Eli, do you remember?
Sidenote: there's not much point in the double "?" in "\\([+-]?\\)?".
But more to the point, I don't remember why I switched to the regexp
mess in the first place. The original code:
(car (read-from-string
(cond ((equal "." str) "0.0")
((string-match "[eE][+-]?$" str) (concat str "0"))
((string-match "\\.[0-9]\\|[eE]" str) str)
((string-match "\\." str)
;; do this because Emacs reads "23." as an integer
(concat str "0"))
((stringp str) (concat str ".0"))
(t "0.0"))))
makes the intention clear -- the idea is to mimic common calculators
where you can type "3." or "3e" and get 3. (Re the fix from a short
while ago, the comment also shows that the original intention was to
always get a float.)
It looks like going back to a simplified (due to the float) version of
this would be better. Also testing that the thing I mentioned in the
log still works ("e+" using "+" as an operator).
--
((x=>x(x))(x=>x(x))) Eli Barzilay:
http://barzilay.org/ Maze is Life!
next prev parent reply other threads:[~2020-05-17 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 5:53 bug#41347: 28.0.50; calculator.el: Cannot input negative exponents Chris Zheng
2020-05-17 11:08 ` Mattias Engdegård
2020-05-17 11:57 ` Andreas Schwab
2020-05-17 12:18 ` Mattias Engdegård
2020-05-17 20:26 ` Eli Barzilay [this message]
2020-05-18 9:28 ` Mattias Engdegård
2020-05-18 15:01 ` Chris Zheng
2020-05-18 15:11 ` Mattias Engdegård
2020-05-18 19:19 ` Eli Barzilay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALO-gutjnuBvtkPoa-4zTdKgwWaL=cWxaYRKjRBDXATah6YkoQ@mail.gmail.com' \
--to=eli@barzilay.org \
--cc=41347@debbugs.gnu.org \
--cc=chriszheng99@gmail.com \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.