bug#34074: 27.0.5; flymake-proc delete temporary directory failed

bug#34074: 27.0.5; flymake-proc delete temporary directory failed

[林宝龙]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

The temporary-file-directory on my host is "/tmp/", current function
trancates the first charactor of the directory name, cause the directory
not exist error.

Below patch removes the folder separator of the temporary-file-directory,
works fine in my environment.

diff --git a/lisp/progmodes/flymake-proc.el b/lisp/progmodes/flymake-proc.el
index 7cdbb266fe..f0b979185e 100644
--- a/lisp/progmodes/flymake-proc.el
+++ b/lisp/progmodes/flymake-proc.el
@@ -886,7 +886,7 @@ can also be executed interactively independently of

 (defun flymake-proc--delete-temp-directory (dir-name)
   "Attempt to delete temp dir created by
`flymake-proc-create-temp-with-folder-structure', do not fail on error."
-  (let* ((temp-dir    temporary-file-directory)
+  (let* ((temp-dir    (directory-file-name temporary-file-directory))
         (suffix      (substring dir-name (1+ (length temp-dir)))))

     (while (> (length suffix) 0)

[-- Attachment #2: Type: text/html, Size: 1226 bytes --]

bug#34074: 27.0.5; flymake-proc delete temporary directory failed

[João Távora]

林宝龙 <lbl52001@gmail.com> writes:

> The temporary-file-directory on my host is "/tmp/", current function
> trancates the first charactor of the directory name, cause the
> directory not exist error.
>
> Below patch removes the folder separator of the temporary-file-directory, works fine in my environment.

Thanks, I pushed a slightly safer fix in

commit 80cbfb61c5a562d51197d6f3068fa5f4cda432b0
Author: João Távora <joaotavora@gmail.com>
Date:   Thu Jan 17 14:38:44 2019 +0000

    Fix flymake-proc--delete-temp-directory if temp dir ends in slash