all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 67480@debbugs.gnu.org, Mou Tong <mou.tong@outlook.com>
Subject: bug#67480: 30.0.50; Cannot start eglot
Date: Tue, 28 Nov 2023 15:10:55 +0000	[thread overview]
Message-ID: <CALDnm53y+PqJidu_brnLq32pxkVKVf8xEWO3vSqRCYt+vK7LXg@mail.gmail.com> (raw)
In-Reply-To: <jwvbkbeueyr.fsf-monnier+emacs@gnu.org>

On Tue, Nov 28, 2023 at 2:52 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> diff --git a/lisp/jsonrpc.el b/lisp/jsonrpc.el
> index 52ffb220d8b..4298d75c5bf 100644
> --- a/lisp/jsonrpc.el
> +++ b/lisp/jsonrpc.el
> @@ -71,6 +71,7 @@ jsonrpc-connection
>      :accessor jsonrpc--request-continuations
>      :documentation "A hash table of request ID to continuation lambdas.")
>     (-events-buffer
> +    :initform nil
>      :accessor jsonrpc--events-buffer
>      :documentation "A buffer pretty-printing the JSONRPC events")
>     (-events-buffer-scrollback-size

Seem sensible, and feel free to push, please.

But it'd also be nice to have a backtrace to that error to
see why jsonrpc.el is trying to access the jsonrpc--events-buffer
"too early".

And kudos for going through these EIEIO bugs, even if in backward
incompatible ways ;-).  Accessor functions definitely must go thru
the slot-value protocol.

João





  reply	other threads:[~2023-11-28 15:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  8:12 bug#67480: 30.0.50; Cannot start eglot Mou Tong
2023-11-27 13:09 ` Eli Zaretskii
2023-11-28  6:06   ` Mou Tong
2023-11-28 14:24     ` Eli Zaretskii
2023-11-28 14:42   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 18:54     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-28 14:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-28 15:10   ` João Távora [this message]
2023-11-28 15:48     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-28 17:27       ` João Távora
2023-11-29  0:40         ` João Távora
2023-12-01 16:04           ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm53y+PqJidu_brnLq32pxkVKVf8xEWO3vSqRCYt+vK7LXg@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=67480@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=mou.tong@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.