Re: master 5044c19 2/2: project.el: A project has only one main root now

Re: master 5044c19 2/2: project.el: A project has only one main root now

[João Távora]

dgutov@yandex.ru (Dmitry Gutov) writes:

> branch: master
> commit 5044c19001fe608f2eac621add2e05cbca6c804b
> Author: Dmitry Gutov <dgutov@yandex.ru>
> Commit: Dmitry Gutov <dgutov@yandex.ru>
>
>     project.el: A project has only one main root now
>     
>     Practice shows that the vast majority of projects only use one main
>     root.  The users of this API very often make this assumption as well.
>     The rest of the "roots" should be possible to express through
>     project-external-roots.

I welcome this change, it makes perfect sense and simplifies a bit of of
Eglot. So thanks!

However, it is breaking Eglot's tests.  Why?  Well Eglot runs its tests
against master and has recently decided to make every warning a test
failure (and project-roots is an obsoleted variable).

Perhaps Eglot should do neighter of those things, but perhaps if you
bumped the version in project.el to 0.3.0 then Eglot could just start
relying on that.  Or aren't you confident enough in this new API?

João

Re: master 5044c19 2/2: project.el: A project has only one main root now

[Dmitry Gutov]

On 25.05.2020 20:17, João Távora wrote:
> However, it is breaking Eglot's tests.  Why?  Well Eglot runs its tests
> against master and has recently decided to make every warning a test
> failure (and project-roots is an obsoleted variable).

I like this idea on paper, but pretty sure you're going to have this 
situation again. Some obsolete functions will remain outside of core 
packages, right? And yet necessary to support older Emacs releases.

> Perhaps Eglot should do neighter of those things, but perhaps if you
> bumped the version in project.el to 0.3.0 then Eglot could just start
> relying on that.  Or aren't you confident enough in this new API?

I'll bump it now. There will be other breakages in the future, though. ;)

Re: master 5044c19 2/2: project.el: A project has only one main root now

[João Távora]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 25.05.2020 20:17, João Távora wrote:
> I like this idea on paper, but pretty sure you're going to have this
> situation again. Some obsolete functions will remain outside of core 
> packages, right? And yet necessary to support older Emacs releases.

Yes, I'm not particularly convinced by the idea myself.  Anyway when
Eglot goes in the core that problem will be gone.  At any rate, the
"warning means error" will be a policy of Emacs tests, not Eglot's.
eglot-tests.el will be an abiding citizen of test/lisp like every other
one.

>> Perhaps Eglot should do neighter of those things, but perhaps if you
>> bumped the version in project.el to 0.3.0 then Eglot could just start
>> relying on that.  Or aren't you confident enough in this new API?
>
> I'll bump it now. There will be other breakages in the future,
> though. ;)

Thanks,
João

Re: master 5044c19 2/2: project.el: A project has only one main root now

[Dmitry Gutov]

On 25.05.2020 22:52, João Távora wrote:
> Anyway when
> Eglot goes in the core that problem will be gone.

It won't support previous versions of Emacs?

Re: master 5044c19 2/2: project.el: A project has only one main root now

[João Távora]

On Mon, May 25, 2020 at 9:00 PM Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 25.05.2020 22:52, João Távora wrote:
> > Anyway when
> > Eglot goes in the core that problem will be gone.
>
> It won't support previous versions of Emacs?

Of course it will, but it will not be tested against them, as in `make check`.
Unless I'm mistaken. jsonrpc.el support Emacs 25. Are we testing against it?

Even if it is, which I doubt, and even if the current policy is
"error on warn", which I also doubt, we could change that
for old Emacs versions.

João

Re: master 5044c19 2/2: project.el: A project has only one main root now

[Dmitry Gutov]

On 25.05.2020 23:24, João Távora wrote:
> Of course it will, but it will not be tested against them, as in `make check`.

Most of the time, when a package has to use an "obsolete" function, is 
because the "new" one is not yet available in older versions of Emacs 
that it still wants to support.

Re: master 5044c19 2/2: project.el: A project has only one main root now

[João Távora]

On Mon, May 25, 2020 at 10:52 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> On 25.05.2020 23:24, João Távora wrote:
> > Of course it will, but it will not be tested against them, as in `make check`.
>
> Most of the time, when a package has to use an "obsolete" function, is
> because the "new" one is not yet available in older versions of Emacs
> that it still wants to support.

But in this case, :core packages take care of that nicely.  For other cases,
(no :core packages),  I see what you mean.  I doubt we're using that
"error on warn" policy in Emacs tests.

João