all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, dalal.chinmay.0101@gmail.com,
	 emacs-devel@gnu.org, dimitri@belopopsky.com, luangruo@yahoo.com
Subject: Re: Eglot "inlay hints" landed
Date: Fri, 24 Feb 2023 12:26:19 +0000	[thread overview]
Message-ID: <CALDnm53q60YSCn_D_c6daquiy1mzHGYpdcigmW9pnq-gpPFNVg@mail.gmail.com> (raw)
In-Reply-To: <83o7pjnvre.fsf@gnu.org>

On Fri, Feb 24, 2023 at 11:33 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: João Távora <joaotavora@gmail.com>
> > Date: Fri, 24 Feb 2023 10:42:26 +0000
> > Cc: Stefan Monnier <monnier@iro.umontreal.ca>, dalal.chinmay.0101@gmail.com,
> >       emacs-devel@gnu.org, dimitri@belopopsky.com, luangruo@yahoo.com
> >
> > On Fri, Feb 24, 2023 at 7:35 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > >
> > > If a jit-lock client is smart enough, it should itself install an
> > > after-change function to remove the 'fontified property from the
> > > portions of buffer text affected by a change that are before the first
> > > changed position (or maybe even in other buffers).
> >
> > Thanks, I was going to ask about that. I suppose this is how one
> > marks sections of a buffer "dirty" or invalidatest them so that
> > jit-lock knows it must run over them again when it sees fit.
> >
> > If it works with other buffers as well, it might provide an
> > elegant solution to the "A affects B" scenario we discussed
> > earlier.
>
> I don't see why it wouldn't work.

Yes.  I never said it wouldn't :-) (and you never said I said,
I'm just clarifying :-).

Anyway, there is also this to this topic.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_inlayHint_refresh

an "inlay hint refresh request" from the server.  A separate
capability apparently designed to cover this case.  I don't
know how it fits into the equation but I would think it was
designed for editors with none of our jit-capabilities.  Maybe
it's mostly useless to us now, especially given its poor
interface (it's just a bare request with no parameters).

It does illustrate the typical LSP line of reasoning: "the server
knows best, because the server knows the language".  IOWs the LSP
server knowledge stands for Emacs  major-mode knowledge.  The
difference here is that the interfaces to extract that knowledge
from the server are very limited or poorly designed.

João



  reply	other threads:[~2023-02-24 12:26 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-11  8:13 bug#61412: [PATCH] Add inlay hints to eglot Chinmay Dalal
2023-02-11 11:50 ` Chinmay Dalal
2023-02-11 15:23 ` bug#61412: Question about implementation Chinmay Dalal
2023-02-13 15:35 ` bug#61412: Hover github discussion Chinmay Dalal
2023-02-15 13:58   ` Eli Zaretskii
2023-02-15 15:05     ` João Távora
2023-02-15 15:38       ` Eli Zaretskii
2023-02-15 12:56 ` bug#61412: [PATCH v2] Add inlay hints to eglot Chinmay Dalal
2023-02-15 13:08 ` bug#61412: [PATCH v3] " Chinmay Dalal
2023-02-15 16:24 ` bug#61412: Inlay activation Chinmay Dalal
2023-02-15 18:09   ` Eli Zaretskii
2023-02-15 18:48     ` Chinmay Dalal
2023-02-15 19:01       ` João Távora
2023-02-15 19:17         ` Chinmay Dalal
2023-02-15 19:41       ` Eli Zaretskii
2023-02-15 20:17         ` Chinmay Dalal
2023-02-21 15:13           ` bug#61412: Inlay hints implementation João Távora
2023-02-21 15:21             ` Eli Zaretskii
2023-02-21 18:42             ` Dimitri Belopopsky
2023-02-21 21:26               ` João Távora
2023-02-25  0:21                 ` João Távora
2023-02-25  7:59                   ` Eli Zaretskii
2023-02-25 10:19                     ` João Távora
2023-02-22 19:42               ` Eglot "inlay hints" landed João Távora
2023-02-23  1:45                 ` [SPAM UNSURE] " Stephen Leake
2023-02-23  5:29                 ` Chinmay Dalal
2023-02-23  6:31                   ` Eli Zaretskii
2023-02-23  9:55                     ` Chinmay Dalal
2023-02-23 10:03                       ` João Távora
2023-02-23 10:55                         ` Dimitri Belopopsky
2023-02-23 11:07                           ` João Távora
2023-02-23 12:03                           ` João Távora
2023-02-23 13:25                             ` Dimitri Belopopsky
2023-02-23 11:05                       ` Eli Zaretskii
2023-02-23 11:23                         ` João Távora
2023-02-23 12:36                           ` Eli Zaretskii
2023-02-23 12:57                             ` João Távora
2023-02-23 14:48                               ` Eli Zaretskii
2023-02-23 16:09                                 ` João Távora
2023-02-23 17:17                                   ` Eli Zaretskii
2023-02-23 17:46                                     ` João Távora
2023-02-23 18:01                                       ` Eli Zaretskii
2023-02-23 19:26                                         ` João Távora
2023-02-23 19:54                                           ` Eli Zaretskii
2023-02-23 20:03                                             ` João Távora
2023-02-23 19:27                                       ` Stefan Monnier
2023-02-23 19:39                                         ` João Távora
2023-02-23 19:53                                           ` Stefan Monnier
2023-02-23 20:09                                             ` João Távora
2023-02-23 22:19                                               ` Stefan Monnier
2023-02-23 23:59                                                 ` João Távora
2023-02-24  1:08                                                   ` Stefan Monnier
2023-02-24  2:28                                                     ` João Távora
2023-02-24  7:35                                                     ` Eli Zaretskii
2023-02-24 10:42                                                       ` João Távora
2023-02-24 11:33                                                         ` Eli Zaretskii
2023-02-24 12:26                                                           ` João Távora [this message]
2023-02-23 10:17                 ` Tassilo Horn
2023-02-23 12:55                 ` Chinmay Dalal
2023-02-23 19:50                 ` Nikola Pajkovsky
2023-02-23 21:35                   ` João Távora
2023-02-23 21:45                     ` Nikola Pajkovsky
2023-02-24  4:20                     ` Chinmay Dalal
2023-02-24  5:04                       ` Chinmay Dalal
2023-02-24  9:59                       ` João Távora
2023-02-24 11:03                         ` Nikola Pajkovsky
2023-02-27 22:50                 ` Johann Klähn
2023-02-21 15:33 ` bug#61412: Inlay hints implementation Chinmay Dalal
2023-02-21 15:57 ` Chinmay Dalal
2023-02-22 15:26 ` Chinmay Dalal
2023-02-22 16:51   ` Chinmay Dalal
2023-02-22 23:17   ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm53q60YSCn_D_c6daquiy1mzHGYpdcigmW9pnq-gpPFNVg@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=dalal.chinmay.0101@gmail.com \
    --cc=dimitri@belopopsky.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.