From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 44ebd9cbd56 2/2: Eglot: explain how to update Eglot in manual (bug#62720) Date: Thu, 4 May 2023 02:09:59 +0100 Message-ID: References: <168263878553.23108.4718240877999827191@vcs2.savannah.gnu.org> <20230427233949.44D31C22A13@vcs2.savannah.gnu.org> <20f53b0a-d6ff-8ec0-2f8c-e0e22b2d49dc@gutov.dev> <6a09451b-88dd-ff00-2bdc-cb34d457adef@gutov.dev> <4e327f05-705c-4a29-a216-0cb296bee91a@app.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36524"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 04 03:11:26 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puNVG-0009K6-JG for ged-emacs-devel@m.gmane-mx.org; Thu, 04 May 2023 03:11:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puNUA-000079-0U; Wed, 03 May 2023 21:10:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puNU5-00006U-PD for emacs-devel@gnu.org; Wed, 03 May 2023 21:10:13 -0400 Original-Received: from mail-oo1-xc2e.google.com ([2607:f8b0:4864:20::c2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puNU4-0005zy-5u for emacs-devel@gnu.org; Wed, 03 May 2023 21:10:13 -0400 Original-Received: by mail-oo1-xc2e.google.com with SMTP id 006d021491bc7-541b5cfa9d8so3109330eaf.0 for ; Wed, 03 May 2023 18:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683162610; x=1685754610; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K/vz3IbG/ygpGJGvK1LJKIrD3lgtkTRug+SaglHiVHA=; b=XEx+JNDojyd0bmTL0loqgAuIfmj802NXXVde357KvxDm0tzhVh+R//zdEK1Evg5pdx EkYn1gLdCxJ9TgsQUgm54o+s5CytphAmIPxniI5JWKTu9CgnvB8L05qrH/6t4Ygl8rY2 zvZ55ytPa/cxDi/7tOrS8tT11U8VYeJhdT9z9fHc/admhOP3Ue0wiz0PLGNbVVqs7hf2 Q5aVBVLDaG5djq/x6lVjiBRoqfka5PBwLY1mex/QAslqElsdUSjIe+znSrycmhxfQiMz Wbu1nar0SDPMLJqMF1xuC15D5Q6ypCtZa4ItdD3hjLbWadD7ZsAnVZetTgt9/gJ4Thbf uQ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683162610; x=1685754610; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K/vz3IbG/ygpGJGvK1LJKIrD3lgtkTRug+SaglHiVHA=; b=L/jA2P+RtA21+vnWJwE33KA6Qt1jn1Jgub7YgujyG9QCnQd6VzDEZ/+LtQdUeiujPr Mrl+dtZiy4qsu9NFIR5HFvFqZlRspAI+3IIWY/XebUtWyyyOJ1ZpdSZHZtHGykPBxMe2 LUHMN9Rkyobmiv9EQM6gNX6mt4i8cHhDGEKDo9EdaLSruObe0B8A8s+Dt1Aae86Qym1k +ROtcJtYqWJZeM3H4Dlc0EzshOw+Efd1uaZGZJndFTn67Xu5RCFfJF4lHcxch9a032Wu uqxOWvVM4JshjK5m0ft5QXXwMRdAgJ5ahrpiljEBFQ98g8aEZOTH136CQM7u81pjeCMr RpbQ== X-Gm-Message-State: AC+VfDz8ZIfJo1zeVL+2ZTtEbtVLCkA65N+QZp7zZOHC3ydfAOQNwwB7 Nq/wm36x+VHQ7KIkrUqms6AZXeEdmV4ezTHuNxo5hsJY X-Google-Smtp-Source: ACHHUZ514FKeD5ktvbXN51oHnxr9xgbs2MWIdSbYPFfNbeuc8XPcduSesc3mj76IIVFGRJ4BFS79JcqquKlGWSGNzDg= X-Received: by 2002:a05:6808:1454:b0:38c:1e92:606 with SMTP id x20-20020a056808145400b0038c1e920606mr676616oiv.17.1683162610700; Wed, 03 May 2023 18:10:10 -0700 (PDT) In-Reply-To: <4e327f05-705c-4a29-a216-0cb296bee91a@app.fastmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::c2e; envelope-from=joaotavora@gmail.com; helo=mail-oo1-xc2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305809 Archived-At: On Thu, May 4, 2023 at 1:57=E2=80=AFAM Dmitry wrote: > > On Thu, May 4, 2023, at 3:50 AM, Jo=C3=A3o T=C3=A1vora wrote: > > Anyway, I would rather not have people that have already gotten 1.15 and > using it (not many) seeing eglot-update change to eglot-upgrade. > By 1.20 noone will remember, but I think we should at least add a > compatibility alias (eglot-upgrade being the advertised one, and keep > eglot-update for 3/4 versions). > > That would make the situation even more of a mess, wouldn't it? Unless yo= u intend to drop the alias after a couple of Eglot's releases. But that wou= ldn't be possible because both names would have appeared in Emacs 29. Why messy? "update" and "upgrade" and used interchangeably anyway in speech/writing. But if it's "less messy" to revert eglot-update then no problem. > > Up to you either way. > > Please add the compatibility alias, if you can. > > > >> Two more things: > > >> > > >> - Commit 44ebd9cbd56 also removed the call to (eldoc) from the end o= f > > >> eglot-completion-at-point which has been there for a few years. Was = that > > >> intentional? Didn't look like it. > > > Not intentional no. Well, at least not for that commit. > > > Not pretty, but I wouldn't worry about it. > > > > So it's not a breakage? Okay then. > > No, it was actually intended (not for that commit of course). > > As long as it was intended for Emacs 29. There's no harm in having it in Emacs 29 (that's where I tested it).