Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

[Dmitry Gutov]

On 10.10.2021 16:33, Jo�o T�vora wrote:
> +    (shorthand
> +     completion-shorthand-try-completion completion-shorthand-all-completions
> +     "Completion of symbol shorthands setup in `read-symbol-shorthands'.

Why not make it a "private" style, at least?

Given that we're likely to go in a different direction on master.

Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

On Sun, Oct 10, 2021 at 10:10 PM Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 10.10.2021 16:33, Jo�o T�vora wrote:
> > +    (shorthand
> > +     completion-shorthand-try-completion
> completion-shorthand-all-completions
> > +     "Completion of symbol shorthands setup in `read-symbol-shorthands'.
>
> Why not make it a "private" style, at least?
>
> Given that we're likely to go in a different direction on master.
>

We don't know how "likely" that is yet.  Eli asked me to push this patch.
I personally think it's good for master (which I why I didn't mark it
"dont merge").

João

[-- Attachment #2: Type: text/html, Size: 1052 bytes --]

Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

[Dmitry Gutov]

On 11.10.2021 00:16, João Távora wrote:
> On Sun, Oct 10, 2021 at 10:10 PM Dmitry Gutov <dgutov@yandex.ru 
> <mailto:dgutov@yandex.ru>> wrote:
> 
>     On 10.10.2021 16:33, Jo�o T�vora wrote:
>      > +    (shorthand
>      > +     completion-shorthand-try-completion
>     completion-shorthand-all-completions
>      > +     "Completion of symbol shorthands setup in
>     `read-symbol-shorthands'.
> 
>     Why not make it a "private" style, at least?
> 
>     Given that we're likely to go in a different direction on master.
> 
> 
> We don't know how "likely" that is yet.  Eli asked me to push this patch.
> I personally think it's good for master (which I why I didn't mark it
> "dont merge").

It is of course good for master (because if there are any problems with 
it, we can change it before Emacs 29 is released).

OTOH, anything we release "publicly" in Emacs 28 now comes with a 
promise of later support.

Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

On Sun, Oct 10, 2021 at 10:29 PM Dmitry Gutov <dgutov@yandex.ru> wrote:

>
> OTOH, anything we release "publicly" in Emacs 28 now comes with a
> promise of later support.
>

Why don't you state exactly what problematic scenario you're thinking of?

João

[-- Attachment #2: Type: text/html, Size: 635 bytes --]

Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

[Dmitry Gutov]

On 11.10.2021 00:31, João Távora wrote:
> Why don't you state exactly what problematic scenario you're thinking of?

People relying on the 'shorthand' style while we try to remove it.

Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

On Sun, Oct 10, 2021 at 10:45 PM Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 11.10.2021 00:31, João Távora wrote:
> > Why don't you state exactly what problematic scenario you're thinking of?
>
> People relying on the 'shorthand' style while we try to remove it.
>

Presumably, we're going to replace it with something better, so
I don't see any problem.

João

[-- Attachment #2: Type: text/html, Size: 751 bytes --]

Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

[Dmitry Gutov]

On 11.10.2021 00:47, João Távora wrote:
> On Sun, Oct 10, 2021 at 10:45 PM Dmitry Gutov <dgutov@yandex.ru 
> <mailto:dgutov@yandex.ru>> wrote:
> 
>     On 11.10.2021 00:31, João Távora wrote:
>      > Why don't you state exactly what problematic scenario you're
>     thinking of?
> 
>     People relying on the 'shorthand' style while we try to remove it.
> 
> Presumably, we're going to replace it with something better, so
> I don't see any problem.

Presumably, we're likely to replace it with no style at all, which can 
break personal configurations (referencing a non-existent style).

Re: emacs-28 4c7e74c: Complete shorthands to longhands for symbol-completing tables

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

On Sun, Oct 10, 2021 at 10:55 PM Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 11.10.2021 00:47, João Távora wrote:
> > On Sun, Oct 10, 2021 at 10:45 PM Dmitry Gutov <dgutov@yandex.ru
> > <mailto:dgutov@yandex.ru>> wrote:
> >
> >     On 11.10.2021 00:31, João Távora wrote:
> >      > Why don't you state exactly what problematic scenario you're
> >     thinking of?
> >
> >     People relying on the 'shorthand' style while we try to remove it.
> >
> > Presumably, we're going to replace it with something better, so
> > I don't see any problem.
>
> Presumably, we're likely to replace it with no style at all, which can
> break personal configurations (referencing a non-existent style).
>

Really, we are?  That's news to me and my crystal ball. But if we do, we
just noop the style and done.

João

[-- Attachment #2: Type: text/html, Size: 1403 bytes --]